QUIC: consider max_ack_delay=16384 invalid.

As per RFC 9000:

   Values of 2^14 or greater are invalid.

diff --git a/src/event/quic/ngx_event_quic.c b/src/event/quic/ngx_event_quic.c
index f0dd943a6e7e59a517afd613a1acd5addcff9350..0d61be8372dad1a856bb2370d9faaedf2aebceba 100644 (file)
--- a/src/event/quic/ngx_event_quic.c
+++ b/src/event/quic/ngx_event_quic.c
@@ -176,7 +176,7 @@ ngx_quic_apply_transport_params(ngx_connection_t *c, ngx_quic_tp_t *ctp)
         return NGX_ERROR;
     }
 
-    if (ctp->max_ack_delay > 16384) {
+    if (ctp->max_ack_delay >= 16384) {
         qc->error = NGX_QUIC_ERR_TRANSPORT_PARAMETER_ERROR;
         qc->error_reason = "invalid max_ack_delay";
 

diff --git a/src/http/modules/ngx_http_quic_module.c b/src/http/modules/ngx_http_quic_module.c
index 2354dfd8bb290a641a616b270172aff83eae46b4..d933dd1f9a8b02aabc46a015ac3604d73e2573a7 100644 (file)
--- a/src/http/modules/ngx_http_quic_module.c
+++ b/src/http/modules/ngx_http_quic_module.c
@@ -394,7 +394,7 @@ ngx_http_quic_max_ack_delay(ngx_conf_t *cf, void *post, void *data)
 {
     ngx_msec_t *sp = data;
 
-    if (*sp > 16384) {
+    if (*sp >= 16384) {
         ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
                            "\"quic_max_ack_delay\" must be less than 16384");
 

diff --git a/src/stream/ngx_stream_quic_module.c b/src/stream/ngx_stream_quic_module.c
index 6567b16cf3260572c1fcfed84de67ddd127eacce..01caa95555bff41fef04973742333fe954c086e3 100644 (file)
--- a/src/stream/ngx_stream_quic_module.c
+++ b/src/stream/ngx_stream_quic_module.c
@@ -354,7 +354,7 @@ ngx_stream_quic_max_ack_delay(ngx_conf_t *cf, void *post, void *data)
 {
     ngx_msec_t *sp = data;
 
-    if (*sp > 16384) {
+    if (*sp >= 16384) {
         ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
                            "\"quic_max_ack_delay\" must be less than 16384");