diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2012-07-12 14:30:04 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2012-07-12 14:30:04 -0400 |
| commit | d066cc548de7f21e84aeb27bd43388ba82534759 (patch) | |
| tree | 222d2e7483d49fb4b573bae829123160fb91f350 | |
| parent | a9287de1760450e7fe3b4309ee1ba7ea2af39217 (diff) | |
| download | postgresql-d066cc548de7f21e84aeb27bd43388ba82534759.tar.gz postgresql-d066cc548de7f21e84aeb27bd43388ba82534759.zip | |
Fix walsender processes to establish a SIGALRM handler.
Walsenders must have working SIGALRM handling during InitPostgres,
but they set the handler to SIG_IGN so that nothing would happen
if a timeout was reached. This could result in two failure modes:
* If a walsender participated in a deadlock during its authentication
transaction, and was the last to wait in the deadly embrace, the deadlock
would not get cleared automatically. This would require somebody to be
trying to take out AccessExclusiveLock on multiple system catalogs, so
it's not very probable.
* If a client failed to respond to a walsender's authentication challenge,
the intended disconnect after AuthenticationTimeout wouldn't happen, and
the walsender would wait indefinitely for the client.
For the moment, fix in back branches only, since this is fixed in a
different way in the timeout-infrastructure patch that's awaiting
application to HEAD. If we choose not to apply that, then we'll need
to do this in HEAD as well.
| -rw-r--r-- | src/backend/replication/walsender.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c index 1648eedf90d..c5391676c4a 100644 --- a/src/backend/replication/walsender.c +++ b/src/backend/replication/walsender.c @@ -1284,7 +1284,7 @@ WalSndSignals(void) pqsignal(SIGINT, SIG_IGN); /* not used */ pqsignal(SIGTERM, WalSndShutdownHandler); /* request shutdown */ pqsignal(SIGQUIT, WalSndQuickDieHandler); /* hard crash time */ - pqsignal(SIGALRM, SIG_IGN); + pqsignal(SIGALRM, handle_sig_alarm); pqsignal(SIGPIPE, SIG_IGN); pqsignal(SIGUSR1, WalSndXLogSendHandler); /* request WAL sending */ pqsignal(SIGUSR2, WalSndLastCycleHandler); /* request a last cycle and |