diff options
| author | Bruce Momjian <bruce@momjian.us> | 2020-06-15 20:59:40 -0400 |
|---|---|---|
| committer | Bruce Momjian <bruce@momjian.us> | 2020-06-15 20:59:40 -0400 |
| commit | 39c698cff8a004c0027ffeb8c97b754d08a9a544 (patch) | |
| tree | 50d7b26f2d44ced40e7b954a9f018c76fb731163 | |
| parent | 4c897197d7939d290781edae6bc53f91f5fcb09b (diff) | |
| download | postgresql-39c698cff8a004c0027ffeb8c97b754d08a9a544.tar.gz postgresql-39c698cff8a004c0027ffeb8c97b754d08a9a544.zip | |
pg_upgrade: set vacuum_defer_cleanup_age to zero
Non-zero vacuum_defer_cleanup_age values cause pg_upgrade freezing of
the system catalogs to be incomplete, or do nothing. This will cause
the upgrade to fail in confusing ways.
Reported-by: Laurenz Albe
Discussion: https://postgr.es/m/7d6f6c22ba05ce0c526e9e8b7bfa8105e7da45e6.camel@cybertec.at
Backpatch-through: 9.5
| -rw-r--r-- | src/bin/pg_upgrade/server.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/bin/pg_upgrade/server.c b/src/bin/pg_upgrade/server.c index c59da91f9df..17a9b7436ad 100644 --- a/src/bin/pg_upgrade/server.c +++ b/src/bin/pg_upgrade/server.c @@ -231,6 +231,9 @@ start_postmaster(ClusterInfo *cluster, bool throw_error) * we only modify the new cluster, so only use it there. If there is a * crash, the new cluster has to be recreated anyway. fsync=off is a big * win on ext4. + * + * Force vacuum_defer_cleanup_age to 0 on the new cluster, so that + * vacuumdb --freeze actually freezes the tuples. */ snprintf(cmd, sizeof(cmd), "\"%s/pg_ctl\" -w -l \"%s\" -D \"%s\" -o \"-p %d%s%s %s%s\" start", @@ -239,7 +242,7 @@ start_postmaster(ClusterInfo *cluster, bool throw_error) BINARY_UPGRADE_SERVER_FLAG_CAT_VER) ? " -b" : " -c autovacuum=off -c autovacuum_freeze_max_age=2000000000", (cluster == &new_cluster) ? - " -c synchronous_commit=off -c fsync=off -c full_page_writes=off" : "", + " -c synchronous_commit=off -c fsync=off -c full_page_writes=off -c vacuum_defer_cleanup_age=0" : "", cluster->pgopts ? cluster->pgopts : "", socket_string); /* |