aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2020-09-06 12:55:13 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2020-09-06 12:56:10 -0400
commite0b4c7dd0b61461da8e4a74a98326e4b591fd575 (patch)
tree1e32933d960cce22fd6d99a36de70eeb8438c0ed
parentbe6667081e233d5868dd7e59ca2226348a489fb5 (diff)
downloadpostgresql-e0b4c7dd0b61461da8e4a74a98326e4b591fd575.tar.gz
postgresql-e0b4c7dd0b61461da8e4a74a98326e4b591fd575.zip
Fix misleading error message about inconsistent moving-aggregate types.
We reported the wrong types when complaining that an aggregate's moving-aggregate implementation is inconsistent with its regular implementation. This was wrong since the feature was introduced, so back-patch to all supported branches. Jeff Janes Discussion: https://postgr.es/m/CAMkU=1x808LH=LPhZp9mNSP0Xd1xDqEd+XeGcvEe48dfE6xV=A@mail.gmail.com
-rw-r--r--src/backend/catalog/pg_aggregate.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/catalog/pg_aggregate.c b/src/backend/catalog/pg_aggregate.c
index 009ac398ee4..dc637e34bb1 100644
--- a/src/backend/catalog/pg_aggregate.c
+++ b/src/backend/catalog/pg_aggregate.c
@@ -475,8 +475,8 @@ AggregateCreate(const char *aggName,
ereport(ERROR,
(errcode(ERRCODE_INVALID_FUNCTION_DEFINITION),
errmsg("moving-aggregate implementation returns type %s, but plain implementation returns type %s",
- format_type_be(aggmTransType),
- format_type_be(aggTransType))));
+ format_type_be(rettype),
+ format_type_be(finaltype))));
}
/* handle sortop, if supplied */