diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2022-11-21 15:37:48 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2022-11-21 15:37:48 -0500 |
| commit | 47a22dc2cb89aca2e54c9cf9fe2da4a5e8ba4cb4 (patch) | |
| tree | 639fb84d3255c9d27a53e60fcb8be51c9d95f57c | |
| parent | 5cda142bb9d2bd7e7ed1c22ae89afe58abfa8d7b (diff) | |
| download | postgresql-47a22dc2cb89aca2e54c9cf9fe2da4a5e8ba4cb4.tar.gz postgresql-47a22dc2cb89aca2e54c9cf9fe2da4a5e8ba4cb4.zip | |
Revert "Prevent instability in contrib/pageinspect's regression test."
This reverts commit 5cda142bb9d2bd7e7ed1c22ae89afe58abfa8d7b
(in v14 only).
It turns out that that fails under force_parallel_mode = regress,
because pageinspect's disk-access functions are marked parallel
safe, which they are not if you try to use them on a temp table.
The cost of fixing that pre-v15 seems to exceed the value of
making this test case fully stable, so we will just leave things
as-is in v14.
| -rw-r--r-- | contrib/pageinspect/expected/page.out | 3 | ||||
| -rw-r--r-- | contrib/pageinspect/sql/page.sql | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/contrib/pageinspect/expected/page.out b/contrib/pageinspect/expected/page.out index 9e4e70ce7c5..8134eda1d7e 100644 --- a/contrib/pageinspect/expected/page.out +++ b/contrib/pageinspect/expected/page.out @@ -1,6 +1,5 @@ CREATE EXTENSION pageinspect; --- Use a temp table so that effects of VACUUM are predictable -CREATE TEMP TABLE test1 (a int, b int); +CREATE TABLE test1 (a int, b int); INSERT INTO test1 VALUES (16777217, 131584); VACUUM (DISABLE_PAGE_SKIPPING) test1; -- set up FSM -- The page contents can vary, so just test that it can be read diff --git a/contrib/pageinspect/sql/page.sql b/contrib/pageinspect/sql/page.sql index 5bff568d3b5..b5c41cc8ac5 100644 --- a/contrib/pageinspect/sql/page.sql +++ b/contrib/pageinspect/sql/page.sql @@ -1,7 +1,6 @@ CREATE EXTENSION pageinspect; --- Use a temp table so that effects of VACUUM are predictable -CREATE TEMP TABLE test1 (a int, b int); +CREATE TABLE test1 (a int, b int); INSERT INTO test1 VALUES (16777217, 131584); VACUUM (DISABLE_PAGE_SKIPPING) test1; -- set up FSM |