aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlvaro Herrera <alvherre@alvh.no-ip.org>2011-03-17 12:28:46 -0300
committerAlvaro Herrera <alvherre@alvh.no-ip.org>2011-03-17 12:33:25 -0300
commit7135bc5d6665fb9cf9452b660c0f7c3daa4a439b (patch)
tree99461005d90c14231a2cab0477cfa49832495b59
parent08fc2d4f99b3a651f4b088a70c1aa21556343b69 (diff)
downloadpostgresql-7135bc5d6665fb9cf9452b660c0f7c3daa4a439b.tar.gz
postgresql-7135bc5d6665fb9cf9452b660c0f7c3daa4a439b.zip
Fix PL/Python memory leak involving array slices
Report and patch from Daniel Popowich, bug #5842 (with some debugging help from Alex Hunsaker)
-rw-r--r--src/pl/plpython/plpython.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/src/pl/plpython/plpython.c b/src/pl/plpython/plpython.c
index 79203f1c0e0..d126d875e58 100644
--- a/src/pl/plpython/plpython.c
+++ b/src/pl/plpython/plpython.c
@@ -2328,14 +2328,9 @@ PLy_result_ass_item(PyObject *arg, Py_ssize_t idx, PyObject *item)
static PyObject *
PLy_result_slice(PyObject *arg, Py_ssize_t lidx, Py_ssize_t hidx)
{
- PyObject *rv;
PLyResultObject *ob = (PLyResultObject *) arg;
- rv = PyList_GetSlice(ob->rows, lidx, hidx);
- if (rv == NULL)
- return NULL;
- Py_INCREF(rv);
- return rv;
+ return PyList_GetSlice(ob->rows, lidx, hidx);
}
static int