diff options
| author | Thomas Munro <tmunro@postgresql.org> | 2023-07-03 16:20:01 +1200 |
|---|---|---|
| committer | Thomas Munro <tmunro@postgresql.org> | 2023-07-04 09:10:37 +1200 |
| commit | d34aa0a2f4f36e25d49d43cd1836e20f9c96899e (patch) | |
| tree | 20f8f165bc948c18c13a44bf6e59e7a28752d1f8 /src/backend/access/gin/ginget.c | |
| parent | ab265e98500bfbc70b39c18a13b8ae43b34d5721 (diff) | |
| download | postgresql-d34aa0a2f4f36e25d49d43cd1836e20f9c96899e.tar.gz postgresql-d34aa0a2f4f36e25d49d43cd1836e20f9c96899e.zip | |
Fix race in SSI interaction with gin fast path.
The ginfast.c code previously checked for conflicts in before locking
the relevant buffer, leaving a window where a RW conflict could be
missed. Re-order.
There was also a place where buffer ID and block number were confused
while trying to predicate-lock a page, noted by visual inspection.
Back-patch to all supported releases. Fixes one more problem discovered
with the reproducer from bug #17949, in this case when Dmitry tried
other index types.
Reported-by: Artem Anisimov <artem.anisimov.255@gmail.com>
Reported-by: Dmitry Dolgov <9erthalion6@gmail.com>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/17949-a0f17035294a55e2%40postgresql.org
Diffstat (limited to 'src/backend/access/gin/ginget.c')
| -rw-r--r-- | src/backend/access/gin/ginget.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/backend/access/gin/ginget.c b/src/backend/access/gin/ginget.c index fc85ba99ac1..00fd6a9f3c2 100644 --- a/src/backend/access/gin/ginget.c +++ b/src/backend/access/gin/ginget.c @@ -140,7 +140,9 @@ collectMatchBitmap(GinBtreeData *btree, GinBtreeStack *stack, * Predicate lock entry leaf page, following pages will be locked by * moveRightIfItNeeded() */ - PredicateLockPage(btree->index, stack->buffer, snapshot); + PredicateLockPage(btree->index, + BufferGetBlockNumber(stack->buffer), + snapshot); for (;;) { |