diff options
| author | Michael Paquier <michael@paquier.xyz> | 2019-07-10 15:15:03 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2019-07-10 15:15:03 +0900 |
| commit | 4d713595914beb705539ca5cd09c8b3a95f65c70 (patch) | |
| tree | ef29c01e48ff2d4f9b39c287630fa09d9ef80d2d /src/backend/access/gist/gistbuildbuffers.c | |
| parent | b8ef33b2d14519da0d038e9d63f51a6714ef764a (diff) | |
| download | postgresql-4d713595914beb705539ca5cd09c8b3a95f65c70.tar.gz postgresql-4d713595914beb705539ca5cd09c8b3a95f65c70.zip | |
Fix variable initialization when using buffering build with GiST
This can cause valgrind to complain, as the flag marking a buffer as a
temporary copy was not getting initialized.
While on it, fill in with zeros newly-created buffer pages. This does
not matter when loading a block from a temporary file, but it makes the
push of an index tuple into a new buffer page safer.
This has been introduced by 1d27dcf, so backpatch all the way down to
9.4.
Author: Alexander Lakhin
Discussion: https://postgr.es/m/15899-0d24fb273b3dd90c@postgresql.org
Backpatch-through: 9.4
Diffstat (limited to 'src/backend/access/gist/gistbuildbuffers.c')
| -rw-r--r-- | src/backend/access/gist/gistbuildbuffers.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/backend/access/gist/gistbuildbuffers.c b/src/backend/access/gist/gistbuildbuffers.c index d71354140ed..38f786848de 100644 --- a/src/backend/access/gist/gistbuildbuffers.c +++ b/src/backend/access/gist/gistbuildbuffers.c @@ -138,6 +138,7 @@ gistGetNodeBuffer(GISTBuildBuffers *gfbb, GISTSTATE *giststate, nodeBuffer->pageBlocknum = InvalidBlockNumber; nodeBuffer->pageBuffer = NULL; nodeBuffer->queuedForEmptying = false; + nodeBuffer->isTemp = false; nodeBuffer->level = level; /* @@ -186,8 +187,8 @@ gistAllocateNewPageBuffer(GISTBuildBuffers *gfbb) { GISTNodeBufferPage *pageBuffer; - pageBuffer = (GISTNodeBufferPage *) MemoryContextAlloc(gfbb->context, - BLCKSZ); + pageBuffer = (GISTNodeBufferPage *) MemoryContextAllocZero(gfbb->context, + BLCKSZ); pageBuffer->prev = InvalidBlockNumber; /* Set page free space */ |