diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2020-10-07 18:41:39 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2020-10-07 18:42:49 -0400 |
| commit | abfce4e46870dfab0e16afae254802b4eb920377 (patch) | |
| tree | a430352aea097533c7c196715c986d991e6b8c93 /src/backend/access/gist/gistold.c | |
| parent | 0bfe356c55947c7a81b5fd2e3e56c55d2ab994d9 (diff) | |
| download | postgresql-abfce4e46870dfab0e16afae254802b4eb920377.tar.gz postgresql-abfce4e46870dfab0e16afae254802b4eb920377.zip | |
Fix optimization hazard in gram.y's makeOrderedSetArgs(), redux.
It appears that commit cf63c641c, which intended to prevent
misoptimization of the result-building step in makeOrderedSetArgs,
didn't go far enough: buildfarm member hornet's version of xlc
is now optimizing back to the old, broken behavior in which
list_length(directargs) is fetched only after list_concat() has
changed that value. I'm not entirely convinced whether that's
an undeniable compiler bug or whether it can be justified by a
sufficiently aggressive interpretation of C sequence points.
So let's just change the code to make it harder to misinterpret.
Back-patch to all supported versions, just in case.
Discussion: https://postgr.es/m/1830491.1601944935@sss.pgh.pa.us
Diffstat (limited to 'src/backend/access/gist/gistold.c')
0 files changed, 0 insertions, 0 deletions