diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2016-03-29 11:54:58 -0400 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2016-03-29 11:54:58 -0400 |
commit | 6cd30292bfc38edcae0c1d9c127265cfe665a569 (patch) | |
tree | abad4920c68ccfc51b99427f716bd58ccf53c013 /src/backend/access/gist/giststrat.c | |
parent | 158a0fb254578e93cec7a940c780426217b79343 (diff) | |
download | postgresql-6cd30292bfc38edcae0c1d9c127265cfe665a569.tar.gz postgresql-6cd30292bfc38edcae0c1d9c127265cfe665a569.zip |
Avoid possibly-unsafe use of Windows' FormatMessage() function.
Whenever this function is used with the FORMAT_MESSAGE_FROM_SYSTEM flag,
it's good practice to include FORMAT_MESSAGE_IGNORE_INSERTS as well.
Otherwise, if the message contains any %n insertion markers, the function
will try to fetch argument strings to substitute --- which we are not
passing, possibly leading to a crash. This is exactly analogous to the
rule about not giving printf() a format string you're not in control of.
Noted and patched by Christian Ullrich.
Back-patch to all supported branches.
Diffstat (limited to 'src/backend/access/gist/giststrat.c')
0 files changed, 0 insertions, 0 deletions