diff options
author | Amit Kapila <akapila@postgresql.org> | 2019-11-12 08:30:16 +0530 |
---|---|---|
committer | Amit Kapila <akapila@postgresql.org> | 2019-11-12 08:30:16 +0530 |
commit | 14aec03502302eff6c67981d8fd121175c436ce9 (patch) | |
tree | d2960e19d086498964a5eeeb68082ac42fee20f2 /src/backend/access | |
parent | b6423e92abfadaa1ed9642319872aa1654403cd6 (diff) | |
download | postgresql-14aec03502302eff6c67981d8fd121175c436ce9.tar.gz postgresql-14aec03502302eff6c67981d8fd121175c436ce9.zip |
Make the order of the header file includes consistent in backend modules.
Similar to commits 7e735035f2 and dddf4cdc33, this commit makes the order
of header file inclusion consistent for backend modules.
In the passing, removed a couple of duplicate inclusions.
Author: Vignesh C
Reviewed-by: Kuntal Ghosh and Amit Kapila
Discussion: https://postgr.es/m/CALDaNm2Sznv8RR6Ex-iJO6xAdsxgWhCoETkaYX=+9DW3q0QCfA@mail.gmail.com
Diffstat (limited to 'src/backend/access')
32 files changed, 49 insertions, 78 deletions
diff --git a/src/backend/access/brin/brin_minmax.c b/src/backend/access/brin/brin_minmax.c index ad0d18ed39f..655c0b54b53 100644 --- a/src/backend/access/brin/brin_minmax.c +++ b/src/backend/access/brin/brin_minmax.c @@ -10,19 +10,18 @@ */ #include "postgres.h" -#include "access/genam.h" #include "access/brin_internal.h" #include "access/brin_tuple.h" +#include "access/genam.h" #include "access/stratnum.h" -#include "catalog/pg_type.h" #include "catalog/pg_amop.h" +#include "catalog/pg_type.h" #include "utils/builtins.h" #include "utils/datum.h" #include "utils/lsyscache.h" #include "utils/rel.h" #include "utils/syscache.h" - typedef struct MinmaxOpaque { Oid cached_subtype; diff --git a/src/backend/access/brin/brin_pageops.c b/src/backend/access/brin/brin_pageops.c index f907b4bc297..c4cbe843c16 100644 --- a/src/backend/access/brin/brin_pageops.c +++ b/src/backend/access/brin/brin_pageops.c @@ -10,8 +10,8 @@ */ #include "postgres.h" -#include "access/brin_pageops.h" #include "access/brin_page.h" +#include "access/brin_pageops.h" #include "access/brin_revmap.h" #include "access/brin_xlog.h" #include "access/xloginsert.h" @@ -22,7 +22,6 @@ #include "storage/smgr.h" #include "utils/rel.h" - /* * Maximum size of an entry in a BRIN_PAGETYPE_REGULAR page. We can tolerate * a single item per page, unlike other index AMs. diff --git a/src/backend/access/brin/brin_tuple.c b/src/backend/access/brin/brin_tuple.c index 2b3861710c3..6d24e53dc92 100644 --- a/src/backend/access/brin/brin_tuple.c +++ b/src/backend/access/brin/brin_tuple.c @@ -31,14 +31,13 @@ */ #include "postgres.h" -#include "access/htup_details.h" #include "access/brin_tuple.h" +#include "access/htup_details.h" #include "access/tupdesc.h" #include "access/tupmacs.h" #include "utils/datum.h" #include "utils/memutils.h" - static inline void brin_deconstruct_tuple(BrinDesc *brdesc, char *tp, bits8 *nullbits, bool nulls, Datum *values, bool *allnulls, bool *hasnulls); diff --git a/src/backend/access/brin/brin_validate.c b/src/backend/access/brin/brin_validate.c index 012933833bd..02337a767ce 100644 --- a/src/backend/access/brin/brin_validate.c +++ b/src/backend/access/brin/brin_validate.c @@ -22,9 +22,8 @@ #include "catalog/pg_opfamily.h" #include "catalog/pg_type.h" #include "utils/builtins.h" -#include "utils/syscache.h" #include "utils/regproc.h" - +#include "utils/syscache.h" /* * Validator for a BRIN opclass. diff --git a/src/backend/access/gin/ginbtree.c b/src/backend/access/gin/ginbtree.c index 4c29261256a..20adfa21948 100644 --- a/src/backend/access/gin/ginbtree.c +++ b/src/backend/access/gin/ginbtree.c @@ -17,8 +17,8 @@ #include "access/gin_private.h" #include "access/ginxlog.h" #include "access/xloginsert.h" -#include "storage/predicate.h" #include "miscadmin.h" +#include "storage/predicate.h" #include "utils/memutils.h" #include "utils/rel.h" diff --git a/src/backend/access/gin/ginfast.c b/src/backend/access/gin/ginfast.c index 439a91b3e61..3d2153bad04 100644 --- a/src/backend/access/gin/ginfast.c +++ b/src/backend/access/gin/ginfast.c @@ -20,19 +20,19 @@ #include "access/gin_private.h" #include "access/ginxlog.h" -#include "access/xloginsert.h" #include "access/xlog.h" -#include "commands/vacuum.h" +#include "access/xloginsert.h" #include "catalog/pg_am.h" +#include "commands/vacuum.h" #include "miscadmin.h" -#include "utils/memutils.h" -#include "utils/rel.h" -#include "utils/acl.h" #include "postmaster/autovacuum.h" #include "storage/indexfsm.h" #include "storage/lmgr.h" #include "storage/predicate.h" +#include "utils/acl.h" #include "utils/builtins.h" +#include "utils/memutils.h" +#include "utils/rel.h" /* GUC parameter */ int gin_pending_list_limit = 0; diff --git a/src/backend/access/gin/gininsert.c b/src/backend/access/gin/gininsert.c index d2905818b26..1ad6228914a 100644 --- a/src/backend/access/gin/gininsert.c +++ b/src/backend/access/gin/gininsert.c @@ -16,18 +16,17 @@ #include "access/gin_private.h" #include "access/ginxlog.h" -#include "access/xloginsert.h" #include "access/tableam.h" +#include "access/xloginsert.h" #include "catalog/index.h" #include "miscadmin.h" #include "storage/bufmgr.h" -#include "storage/smgr.h" #include "storage/indexfsm.h" #include "storage/predicate.h" +#include "storage/smgr.h" #include "utils/memutils.h" #include "utils/rel.h" - typedef struct { GinState ginstate; diff --git a/src/backend/access/gin/ginvalidate.c b/src/backend/access/gin/ginvalidate.c index 63bd7f2adce..5d96f29cdef 100644 --- a/src/backend/access/gin/ginvalidate.c +++ b/src/backend/access/gin/ginvalidate.c @@ -23,9 +23,8 @@ #include "catalog/pg_type.h" #include "utils/builtins.h" #include "utils/lsyscache.h" -#include "utils/syscache.h" #include "utils/regproc.h" - +#include "utils/syscache.h" /* * Validator for a GIN opclass. diff --git a/src/backend/access/gist/gist.c b/src/backend/access/gist/gist.c index 0cc87911d6b..8d9c8d025dc 100644 --- a/src/backend/access/gist/gist.c +++ b/src/backend/access/gist/gist.c @@ -18,15 +18,14 @@ #include "access/gistscan.h" #include "catalog/pg_collation.h" #include "miscadmin.h" +#include "nodes/execnodes.h" #include "storage/lmgr.h" #include "storage/predicate.h" -#include "nodes/execnodes.h" #include "utils/builtins.h" #include "utils/index_selfuncs.h" #include "utils/memutils.h" #include "utils/rel.h" - /* non-export function prototypes */ static void gistfixsplit(GISTInsertState *state, GISTSTATE *giststate); static bool gistinserttuple(GISTInsertState *state, GISTInsertStack *stack, diff --git a/src/backend/access/gist/gistget.c b/src/backend/access/gist/gistget.c index 22d790d8221..98b68920138 100644 --- a/src/backend/access/gist/gistget.c +++ b/src/backend/access/gist/gistget.c @@ -17,11 +17,11 @@ #include "access/genam.h" #include "access/gist_private.h" #include "access/relscan.h" +#include "lib/pairingheap.h" #include "miscadmin.h" +#include "pgstat.h" #include "storage/lmgr.h" #include "storage/predicate.h" -#include "pgstat.h" -#include "lib/pairingheap.h" #include "utils/float.h" #include "utils/memutils.h" #include "utils/rel.h" diff --git a/src/backend/access/gist/gistutil.c b/src/backend/access/gist/gistutil.c index a23dec76a2e..553a6d67b12 100644 --- a/src/backend/access/gist/gistutil.c +++ b/src/backend/access/gist/gistutil.c @@ -22,10 +22,9 @@ #include "storage/indexfsm.h" #include "storage/lmgr.h" #include "utils/float.h" -#include "utils/syscache.h" -#include "utils/snapmgr.h" #include "utils/lsyscache.h" - +#include "utils/snapmgr.h" +#include "utils/syscache.h" /* * Write itup vector to page, has no control of free space. diff --git a/src/backend/access/hash/hash.c b/src/backend/access/hash/hash.c index 6c058362bd1..a0597a0c6e5 100644 --- a/src/backend/access/hash/hash.c +++ b/src/backend/access/hash/hash.c @@ -31,8 +31,6 @@ #include "utils/builtins.h" #include "utils/index_selfuncs.h" #include "utils/rel.h" -#include "miscadmin.h" - /* Working state for hashbuild and its callback */ typedef struct diff --git a/src/backend/access/hash/hash_xlog.c b/src/backend/access/hash/hash_xlog.c index 86e7210acb8..c1d248ae5e0 100644 --- a/src/backend/access/hash/hash_xlog.c +++ b/src/backend/access/hash/hash_xlog.c @@ -17,11 +17,11 @@ #include "access/bufmask.h" #include "access/hash.h" #include "access/hash_xlog.h" -#include "access/xlogutils.h" -#include "access/xlog.h" #include "access/transam.h" -#include "storage/procarray.h" +#include "access/xlog.h" +#include "access/xlogutils.h" #include "miscadmin.h" +#include "storage/procarray.h" /* * replay a hash index meta page diff --git a/src/backend/access/hash/hashinsert.c b/src/backend/access/hash/hashinsert.c index 89876d2ccd0..e0ca1b03de7 100644 --- a/src/backend/access/hash/hashinsert.c +++ b/src/backend/access/hash/hashinsert.c @@ -18,10 +18,10 @@ #include "access/hash.h" #include "access/hash_xlog.h" #include "miscadmin.h" -#include "utils/rel.h" -#include "storage/lwlock.h" #include "storage/buf_internals.h" +#include "storage/lwlock.h" #include "storage/predicate.h" +#include "utils/rel.h" static void _hash_vacuum_one_page(Relation rel, Relation hrel, Buffer metabuf, Buffer buf); diff --git a/src/backend/access/hash/hashpage.c b/src/backend/access/hash/hashpage.c index 838ee68c867..63697bfeb56 100644 --- a/src/backend/access/hash/hashpage.c +++ b/src/backend/access/hash/hashpage.c @@ -32,9 +32,8 @@ #include "access/hash_xlog.h" #include "miscadmin.h" #include "storage/lmgr.h" -#include "storage/smgr.h" #include "storage/predicate.h" - +#include "storage/smgr.h" static bool _hash_alloc_buckets(Relation rel, BlockNumber firstblock, uint32 nblocks); diff --git a/src/backend/access/hash/hashsearch.c b/src/backend/access/hash/hashsearch.c index 79ae499198d..725e6148c6d 100644 --- a/src/backend/access/hash/hashsearch.c +++ b/src/backend/access/hash/hashsearch.c @@ -18,8 +18,8 @@ #include "access/relscan.h" #include "miscadmin.h" #include "pgstat.h" -#include "utils/rel.h" #include "storage/predicate.h" +#include "utils/rel.h" static bool _hash_readpage(IndexScanDesc scan, Buffer *bufP, ScanDirection dir); diff --git a/src/backend/access/hash/hashutil.c b/src/backend/access/hash/hashutil.c index 3fb92eab618..c5005f47540 100644 --- a/src/backend/access/hash/hashutil.c +++ b/src/backend/access/hash/hashutil.c @@ -17,9 +17,9 @@ #include "access/hash.h" #include "access/reloptions.h" #include "access/relscan.h" +#include "storage/buf_internals.h" #include "utils/lsyscache.h" #include "utils/rel.h" -#include "storage/buf_internals.h" #define CALC_NEW_BUCKET(old_bucket, lowmask) \ old_bucket | (lowmask + 1) diff --git a/src/backend/access/heap/heapam_handler.c b/src/backend/access/heap/heapam_handler.c index 7081172dcc2..92073fec54d 100644 --- a/src/backend/access/heap/heapam_handler.c +++ b/src/backend/access/heap/heapam_handler.c @@ -19,8 +19,6 @@ */ #include "postgres.h" -#include "miscadmin.h" - #include "access/genam.h" #include "access/heapam.h" #include "access/heaptoast.h" @@ -35,10 +33,10 @@ #include "catalog/storage_xlog.h" #include "commands/progress.h" #include "executor/executor.h" +#include "miscadmin.h" #include "pgstat.h" #include "storage/bufmgr.h" #include "storage/bufpage.h" -#include "storage/bufmgr.h" #include "storage/lmgr.h" #include "storage/predicate.h" #include "storage/procarray.h" @@ -46,7 +44,6 @@ #include "utils/builtins.h" #include "utils/rel.h" - static void reform_and_rewrite_tuple(HeapTuple tuple, Relation OldHeap, Relation NewHeap, Datum *values, bool *isnull, RewriteState rwstate); diff --git a/src/backend/access/heap/pruneheap.c b/src/backend/access/heap/pruneheap.c index a0d22173cef..6d62a969727 100644 --- a/src/backend/access/heap/pruneheap.c +++ b/src/backend/access/heap/pruneheap.c @@ -16,15 +16,15 @@ #include "access/heapam.h" #include "access/heapam_xlog.h" -#include "access/transam.h" #include "access/htup_details.h" +#include "access/transam.h" #include "access/xlog.h" #include "catalog/catalog.h" #include "miscadmin.h" #include "pgstat.h" #include "storage/bufmgr.h" -#include "utils/snapmgr.h" #include "utils/rel.h" +#include "utils/snapmgr.h" /* Working data for heap_page_prune and subroutines */ typedef struct diff --git a/src/backend/access/heap/rewriteheap.c b/src/backend/access/heap/rewriteheap.c index d41dbcf5f72..d285b1f3907 100644 --- a/src/backend/access/heap/rewriteheap.c +++ b/src/backend/access/heap/rewriteheap.c @@ -105,8 +105,6 @@ #include <sys/stat.h> #include <unistd.h> -#include "miscadmin.h" - #include "access/heapam.h" #include "access/heapam_xlog.h" #include "access/heaptoast.h" @@ -114,25 +112,19 @@ #include "access/transam.h" #include "access/xact.h" #include "access/xloginsert.h" - #include "catalog/catalog.h" - #include "lib/ilist.h" - +#include "miscadmin.h" #include "pgstat.h" - #include "replication/logical.h" #include "replication/slot.h" - #include "storage/bufmgr.h" #include "storage/fd.h" +#include "storage/procarray.h" #include "storage/smgr.h" - #include "utils/memutils.h" #include "utils/rel.h" -#include "storage/procarray.h" - /* * State associated with a rewrite operation. This is opaque to the user * of the rewrite facility. diff --git a/src/backend/access/nbtree/nbtxlog.c b/src/backend/access/nbtree/nbtxlog.c index dd5315c1aad..44f62839500 100644 --- a/src/backend/access/nbtree/nbtxlog.c +++ b/src/backend/access/nbtree/nbtxlog.c @@ -20,8 +20,8 @@ #include "access/transam.h" #include "access/xlog.h" #include "access/xlogutils.h" -#include "storage/procarray.h" #include "miscadmin.h" +#include "storage/procarray.h" /* * _bt_restore_page -- re-enter all the index tuples on a page diff --git a/src/backend/access/spgist/spgquadtreeproc.c b/src/backend/access/spgist/spgquadtreeproc.c index e50108e1cae..992c5581af5 100644 --- a/src/backend/access/spgist/spgquadtreeproc.c +++ b/src/backend/access/spgist/spgquadtreeproc.c @@ -16,14 +16,13 @@ #include "postgres.h" #include "access/spgist.h" -#include "access/stratnum.h" #include "access/spgist_private.h" +#include "access/stratnum.h" #include "catalog/pg_type.h" #include "utils/builtins.h" #include "utils/float.h" #include "utils/geo_decls.h" - Datum spg_quad_config(PG_FUNCTION_ARGS) { diff --git a/src/backend/access/transam/clog.c b/src/backend/access/transam/clog.c index 595c860aaaf..7f7eb21b4f4 100644 --- a/src/backend/access/transam/clog.c +++ b/src/backend/access/transam/clog.c @@ -39,8 +39,8 @@ #include "access/xloginsert.h" #include "access/xlogutils.h" #include "miscadmin.h" -#include "pgstat.h" #include "pg_trace.h" +#include "pgstat.h" #include "storage/proc.h" /* diff --git a/src/backend/access/transam/parallel.c b/src/backend/access/transam/parallel.c index 55d129a64f7..d1472364295 100644 --- a/src/backend/access/transam/parallel.c +++ b/src/backend/access/transam/parallel.c @@ -19,9 +19,9 @@ #include "access/session.h" #include "access/xact.h" #include "access/xlog.h" -#include "catalog/pg_enum.h" #include "catalog/index.h" #include "catalog/namespace.h" +#include "catalog/pg_enum.h" #include "commands/async.h" #include "executor/execParallel.h" #include "libpq/libpq.h" @@ -43,7 +43,6 @@ #include "utils/snapmgr.h" #include "utils/typcache.h" - /* * We don't want to waste a lot of memory on an error queue which, most of * the time, will process only a handful of small messages. However, it is diff --git a/src/backend/access/transam/rmgr.c b/src/backend/access/transam/rmgr.c index 9368b56c4ce..58091f6b520 100644 --- a/src/backend/access/transam/rmgr.c +++ b/src/backend/access/transam/rmgr.c @@ -7,14 +7,14 @@ */ #include "postgres.h" +#include "access/brin_xlog.h" #include "access/clog.h" #include "access/commit_ts.h" +#include "access/generic_xlog.h" #include "access/ginxlog.h" #include "access/gistxlog.h" -#include "access/generic_xlog.h" #include "access/hash_xlog.h" #include "access/heapam_xlog.h" -#include "access/brin_xlog.h" #include "access/multixact.h" #include "access/nbtxlog.h" #include "access/spgxlog.h" diff --git a/src/backend/access/transam/slru.c b/src/backend/access/transam/slru.c index e38f9199ddb..59bad09fc95 100644 --- a/src/backend/access/transam/slru.c +++ b/src/backend/access/transam/slru.c @@ -54,11 +54,10 @@ #include "access/slru.h" #include "access/transam.h" #include "access/xlog.h" +#include "miscadmin.h" #include "pgstat.h" #include "storage/fd.h" #include "storage/shmem.h" -#include "miscadmin.h" - #define SlruFileName(ctl, path, seg) \ snprintf(path, MAXPGPATH, "%s/%04X", (ctl)->Dir, seg) diff --git a/src/backend/access/transam/twophase.c b/src/backend/access/transam/twophase.c index 546bd43ce8b..712e842b904 100644 --- a/src/backend/access/transam/twophase.c +++ b/src/backend/access/transam/twophase.c @@ -85,8 +85,8 @@ #include "access/xact.h" #include "access/xlog.h" #include "access/xloginsert.h" -#include "access/xlogutils.h" #include "access/xlogreader.h" +#include "access/xlogutils.h" #include "catalog/pg_type.h" #include "catalog/storage.h" #include "funcapi.h" @@ -108,7 +108,6 @@ #include "utils/memutils.h" #include "utils/timestamp.h" - /* * Directory where Two-phase commit files reside within PGDATA */ diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c index e5e2902465a..8fe38c33c6d 100644 --- a/src/backend/access/transam/xact.c +++ b/src/backend/access/transam/xact.c @@ -40,6 +40,7 @@ #include "libpq/be-fsstubs.h" #include "libpq/pqsignal.h" #include "miscadmin.h" +#include "pg_trace.h" #include "pgstat.h" #include "replication/logical.h" #include "replication/logicallauncher.h" @@ -65,8 +66,6 @@ #include "utils/snapmgr.h" #include "utils/timeout.h" #include "utils/timestamp.h" -#include "pg_trace.h" - /* * User-tweakable parameters diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 55d01a86c73..3b766e66b9e 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -42,15 +42,16 @@ #include "commands/tablespace.h" #include "common/controldata_utils.h" #include "miscadmin.h" +#include "pg_trace.h" #include "pgstat.h" #include "port/atomics.h" #include "postmaster/bgwriter.h" -#include "postmaster/walwriter.h" #include "postmaster/startup.h" +#include "postmaster/walwriter.h" #include "replication/basebackup.h" #include "replication/logical.h" -#include "replication/slot.h" #include "replication/origin.h" +#include "replication/slot.h" #include "replication/snapbuild.h" #include "replication/walreceiver.h" #include "replication/walsender.h" @@ -74,7 +75,6 @@ #include "utils/relmapper.h" #include "utils/snapmgr.h" #include "utils/timestamp.h" -#include "pg_trace.h" extern uint32 bootstrap_data_checksum_version; diff --git a/src/backend/access/transam/xlogfuncs.c b/src/backend/access/transam/xlogfuncs.c index 8f179887ab1..1fccf29a36a 100644 --- a/src/backend/access/transam/xlogfuncs.c +++ b/src/backend/access/transam/xlogfuncs.c @@ -27,17 +27,16 @@ #include "miscadmin.h" #include "pgstat.h" #include "replication/walreceiver.h" +#include "storage/fd.h" +#include "storage/ipc.h" #include "storage/smgr.h" #include "utils/builtins.h" +#include "utils/guc.h" #include "utils/memutils.h" #include "utils/numeric.h" -#include "utils/guc.h" #include "utils/pg_lsn.h" #include "utils/timestamp.h" #include "utils/tuplestore.h" -#include "storage/fd.h" -#include "storage/ipc.h" - /* * Store label file and tablespace map during non-exclusive backups. diff --git a/src/backend/access/transam/xloginsert.c b/src/backend/access/transam/xloginsert.c index 3ec67d468b5..aa9dca00366 100644 --- a/src/backend/access/transam/xloginsert.c +++ b/src/backend/access/transam/xloginsert.c @@ -26,11 +26,11 @@ #include "catalog/pg_control.h" #include "common/pg_lzcompress.h" #include "miscadmin.h" +#include "pg_trace.h" #include "replication/origin.h" #include "storage/bufmgr.h" #include "storage/proc.h" #include "utils/memutils.h" -#include "pg_trace.h" /* Buffer size required to store a compressed version of backup block image */ #define PGLZ_MAX_BLCKSZ PGLZ_MAX_OUTPUT(BLCKSZ) diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/transam/xlogreader.c index 6d8581919c9..7f24f0cb95f 100644 --- a/src/backend/access/transam/xlogreader.c +++ b/src/backend/access/transam/xlogreader.c @@ -18,9 +18,9 @@ #include "postgres.h" #include "access/transam.h" -#include "access/xlogrecord.h" #include "access/xlog_internal.h" #include "access/xlogreader.h" +#include "access/xlogrecord.h" #include "catalog/pg_control.h" #include "common/pg_lzcompress.h" #include "replication/origin.h" @@ -30,7 +30,6 @@ #include "utils/memutils.h" #endif - static void report_invalid_record(XLogReaderState *state, const char *fmt,...) pg_attribute_printf(2, 3); static bool allocate_recordbuf(XLogReaderState *state, uint32 reclength); |