diff options
| author | David Rowley <drowley@postgresql.org> | 2022-09-29 11:43:40 +1300 |
|---|---|---|
| committer | David Rowley <drowley@postgresql.org> | 2022-09-29 11:43:40 +1300 |
| commit | f7ae8a2e186ca27f4ea64fddc21bfabaf0618507 (patch) | |
| tree | d359f0db9dd606274a2fd8f5fed9c29810e68a79 /src/backend/executor/nodeModifyTable.c | |
| parent | 517fab6a405628a7e4d2aad4cb19ab652adea720 (diff) | |
| download | postgresql-f7ae8a2e186ca27f4ea64fddc21bfabaf0618507.tar.gz postgresql-f7ae8a2e186ca27f4ea64fddc21bfabaf0618507.zip | |
Restrict Datum sort optimization to byval types only
91e9e89dc modified nodeSort.c so that it used datum sorts when the
targetlist of the outer node contained only a single column. That commit
failed to recognise that the Datum returned by tuplesort_getdatum() must
be pfree'd when the type is a byref type. Ronan Dunklau did originally
propose the patch with that restriction, but that, probably through my own
fault, got lost during further development work.
Due to the timing of this report (PG15 RC1 is almost out the door), let's
just restrict the datum sort optimization to apply for byval types only.
We might want to look harder into making this work for byref types in
PG16.
Reported-by: Önder Kalacı
Diagnosis-by: Tom Lane
Discussion: https://postgr.es/m/CACawEhVxe0ufR26UcqtU7GYGRuubq3p6ZWPGXL4cxy_uexpAAQ@mail.gmail.com
Backpatch-through: 15, where 91e9e89dc was introduced.
Diffstat (limited to 'src/backend/executor/nodeModifyTable.c')
0 files changed, 0 insertions, 0 deletions