diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2020-07-24 15:43:56 -0400 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2020-07-24 15:43:56 -0400 |
commit | 70eca6a9a6df679a86f30442194cc6b858b82000 (patch) | |
tree | 056b8e983b7f7e16b5239df806b42992bef14ea7 /src/backend/executor/nodeSetOp.c | |
parent | 92fe6895d66da93a3c920089cfbbe4eb2db2145e (diff) | |
download | postgresql-70eca6a9a6df679a86f30442194cc6b858b82000.tar.gz postgresql-70eca6a9a6df679a86f30442194cc6b858b82000.zip |
Replace TS_execute's TS_EXEC_CALC_NOT flag with TS_EXEC_SKIP_NOT.
It's fairly silly that ignoring NOT subexpressions is TS_execute's
default behavior. It's wrong on its face and it encourages errors
of omission. Moreover, the only two remaining callers that aren't
specifying CALC_NOT are in ts_headline calculations, and it's very
arguable that those are bugs: if you've specified "!foo" in your
query, why would you want to get a headline that includes "foo"?
Hence, rip that out and change the default behavior to be to calculate
NOT accurately. As a concession to the slim chance that there is still
somebody somewhere who needs the incorrect behavior, provide a new
SKIP_NOT flag to explicitly request that.
Back-patch into v13, mainly because it seems better to change this
at the same time as the previous commit's rejiggering of TS_execute
related APIs. Any outside callers affected by this change are
probably also affected by that one.
Discussion: https://postgr.es/m/CALT9ZEE-aLotzBg-pOp2GFTesGWVYzXA3=mZKzRDa_OKnLF7Mg@mail.gmail.com
Diffstat (limited to 'src/backend/executor/nodeSetOp.c')
0 files changed, 0 insertions, 0 deletions