diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2021-10-06 15:50:24 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2021-10-06 15:50:24 -0400 |
| commit | 88807757d7409fa655458679a78a52b4406cf601 (patch) | |
| tree | 4e9455ff6b3e532e79e44f65f92f0203ecfc2b5b /src/backend/parser/parse_target.c | |
| parent | b2a0f1673371fd0156685b44b06a818609ed7c95 (diff) | |
| download | postgresql-88807757d7409fa655458679a78a52b4406cf601.tar.gz postgresql-88807757d7409fa655458679a78a52b4406cf601.zip | |
Fix null-pointer crash in postgres_fdw's conversion_error_callback.
Commit c7b7311f6 adjusted conversion_error_callback to always use
information from the query's rangetable, to avoid doing catalog lookups
in an already-failed transaction. However, as a result of the utterly
inadequate documentation for make_tuple_from_result_row, I failed to
realize that fsstate could be NULL in some contexts. That led to a
crash if we got a conversion error in such a context. Fix by falling
back to the previous coding when fsstate is NULL. Improve the
commentary, too.
Per report from Andrey Borodin. Back-patch to 9.6, like the previous
patch.
Discussion: https://postgr.es/m/08916396-55E4-4D68-AB3A-BD6066F9E5C0@yandex-team.ru
Diffstat (limited to 'src/backend/parser/parse_target.c')
0 files changed, 0 insertions, 0 deletions