aboutsummaryrefslogtreecommitdiff
path: root/src/backend/rewrite/rewriteHandler.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2021-02-07 12:54:08 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2021-02-07 12:54:08 -0500
commitf94924f01e48b08c677eeeab20108bbbc0be52e6 (patch)
tree7b1c0cd99a385bef504b516b16fdd8712f56fb22 /src/backend/rewrite/rewriteHandler.c
parentce5f27fcae61526603915a266f36a3b2c6f6c6de (diff)
downloadpostgresql-f94924f01e48b08c677eeeab20108bbbc0be52e6.tar.gz
postgresql-f94924f01e48b08c677eeeab20108bbbc0be52e6.zip
Revert "Propagate CTE property flags when copying a CTE list into a rule."
This reverts commit ed290896335414c6c069b9ccae1f3dcdd2fac6ba and equivalent back-branch commits. The issue is subtler than I thought, and it's far from new, so just before a release deadline is no time to be fooling with it. We'll consider what to do at a bit more leisure. Discussion: https://postgr.es/m/CAJcOf-fAdj=nDKMsRhQzndm-O13NY4dL6xGcEvdX5Xvbbi0V7g@mail.gmail.com
Diffstat (limited to 'src/backend/rewrite/rewriteHandler.c')
-rw-r--r--src/backend/rewrite/rewriteHandler.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/src/backend/rewrite/rewriteHandler.c b/src/backend/rewrite/rewriteHandler.c
index e6bdf15e2df..ebb29e9aa3d 100644
--- a/src/backend/rewrite/rewriteHandler.c
+++ b/src/backend/rewrite/rewriteHandler.c
@@ -525,9 +525,6 @@ rewriteRuleAction(Query *parsetree,
*
* This could possibly be fixed by using some sort of internally
* generated ID, instead of names, to link CTE RTEs to their CTEs.
- * However, decompiling the results would be quite confusing; note the
- * merge of hasRecursive flags below, which could change the apparent
- * semantics of such redundantly-named CTEs.
*/
foreach(lc, parsetree->cteList)
{
@@ -549,9 +546,6 @@ rewriteRuleAction(Query *parsetree,
/* OK, it's safe to combine the CTE lists */
sub_action->cteList = list_concat(sub_action->cteList,
copyObject(parsetree->cteList));
- /* ... and don't forget about the associated flags */
- sub_action->hasRecursive |= parsetree->hasRecursive;
- sub_action->hasModifyingCTE |= parsetree->hasModifyingCTE;
}
/*