diff options
| author | Robert Haas <rhaas@postgresql.org> | 2017-10-27 22:22:39 +0200 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2017-10-29 20:48:51 +0530 |
| commit | a87c0c7631d2ec738e78b909f5dcea16ea1e832f (patch) | |
| tree | 017d6129948881942c7f3fc35b519b3be4e4f7f5 /src/backend | |
| parent | 69125c883df30e6232412d35bf7c89b8c3ad1305 (diff) | |
| download | postgresql-a87c0c7631d2ec738e78b909f5dcea16ea1e832f.tar.gz postgresql-a87c0c7631d2ec738e78b909f5dcea16ea1e832f.zip | |
Allow parallel query for prepared statements with generic plans.
This was always intended to work, but due to an oversight in
max_parallel_hazard_walker, it didn't. In testing, we missed the
fact that it was only working for custom plans, where the parameter
value has been substituted for the parameter itself early enough
that everything worked. In a generic plan, the Param node survives
and must be treated as parallel-safe. SerializeParamList provides
for the transmission of parameter values to workers.
Amit Kapila with help from Kuntal Ghosh. Some changes by me.
Discussion: http://postgr.es/m/CAA4eK1+_BuZrmVCeua5Eqnm4Co9DAXdM5HPAOE2J19ePbR912Q@mail.gmail.com
Diffstat (limited to 'src/backend')
| -rw-r--r-- | src/backend/optimizer/util/clauses.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/backend/optimizer/util/clauses.c b/src/backend/optimizer/util/clauses.c index 8b4425dcf90..fa53b7a8c50 100644 --- a/src/backend/optimizer/util/clauses.c +++ b/src/backend/optimizer/util/clauses.c @@ -1223,13 +1223,17 @@ max_parallel_hazard_walker(Node *node, max_parallel_hazard_context *context) /* * We can't pass Params to workers at the moment either, so they are also - * parallel-restricted, unless they are PARAM_EXEC Params listed in - * safe_param_ids, meaning they could be generated within the worker. + * parallel-restricted, unless they are PARAM_EXTERN Params or are + * PARAM_EXEC Params listed in safe_param_ids, meaning they could be + * generated within the worker. */ else if (IsA(node, Param)) { Param *param = (Param *) node; + if (param->paramkind == PARAM_EXTERN) + return false; + if (param->paramkind != PARAM_EXEC || !list_member_int(context->safe_param_ids, param->paramid)) { |