diff options
| author | Peter Eisentraut <peter_e@gmx.net> | 2011-12-27 21:19:09 +0200 |
|---|---|---|
| committer | Peter Eisentraut <peter_e@gmx.net> | 2011-12-27 21:19:09 +0200 |
| commit | 037a82704ce644e2b1c3946345b54444caddb1a5 (patch) | |
| tree | d89abc55ac119b86d69c01f819ab8fb22a1382c6 /src/backend | |
| parent | d383c23f6fbc4a79dae66483cf4f7051121008ad (diff) | |
| download | postgresql-037a82704ce644e2b1c3946345b54444caddb1a5.tar.gz postgresql-037a82704ce644e2b1c3946345b54444caddb1a5.zip | |
Standardize treatment of strcmp() return value
Always compare the return value to 0, don't use cute tricks like
if (!strcmp(...)).
Diffstat (limited to 'src/backend')
| -rw-r--r-- | src/backend/libpq/auth.c | 2 | ||||
| -rw-r--r-- | src/backend/utils/adt/formatting.c | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/backend/libpq/auth.c b/src/backend/libpq/auth.c index ca2bba99d8c..d94b483dc16 100644 --- a/src/backend/libpq/auth.c +++ b/src/backend/libpq/auth.c @@ -1464,7 +1464,7 @@ pg_SSPI_recvauth(Port *port) */ if (port->hba->krb_realm && strlen(port->hba->krb_realm)) { - if (pg_strcasecmp(port->hba->krb_realm, domainname)) + if (pg_strcasecmp(port->hba->krb_realm, domainname) != 0) { elog(DEBUG2, "SSPI domain (%s) and configured domain (%s) don't match", diff --git a/src/backend/utils/adt/formatting.c b/src/backend/utils/adt/formatting.c index be0966ca90e..96c89931b50 100644 --- a/src/backend/utils/adt/formatting.c +++ b/src/backend/utils/adt/formatting.c @@ -1012,7 +1012,7 @@ index_seq_search(char *str, const KeyWord *kw, const int *index) do { - if (!strncmp(str, k->name, k->len)) + if (strncmp(str, k->name, k->len) == 0) return k; k++; if (!k->name) @@ -1032,7 +1032,7 @@ suff_search(char *str, KeySuffix *suf, int type) if (s->type != type) continue; - if (!strncmp(str, s->name, s->len)) + if (strncmp(str, s->name, s->len) == 0) return s; } return NULL; |