aboutsummaryrefslogtreecommitdiff
path: root/src/backend
diff options
context:
space:
mode:
authorDaniel Gustafsson <dgustafsson@postgresql.org>2022-09-12 12:59:06 +0200
committerDaniel Gustafsson <dgustafsson@postgresql.org>2022-09-12 12:59:06 +0200
commit13b8a1c19626d425176b1e00a8104db1e339aaf3 (patch)
tree4ce661fbfb177895ec72ecb741012fa9c16fc932 /src/backend
parentbe0b0528cb64d49750fcb632faa2cfcd8d920be2 (diff)
downloadpostgresql-13b8a1c19626d425176b1e00a8104db1e339aaf3.tar.gz
postgresql-13b8a1c19626d425176b1e00a8104db1e339aaf3.zip
Fix NaN comparison in circle_same test
Commit c4c340088 changed geometric operators to use float4 and float8 functions, and handle NaN's in a better way. The circle sameness test had a typo in the code which resulted in all comparisons with the left circle having a NaN radius considered same. postgres=# select '<(0,0),NaN>'::circle ~= '<(0,0),1>'::circle; ?column? ---------- t (1 row) This fixes the sameness test to consider the radius of both the left and right circle. Backpatch to v12 where this was introduced. Author: Ranier Vilela <ranier.vf@gmail.com> Discussion: https://postgr.es/m/CAEudQAo8dK=yctg2ZzjJuzV4zgOPBxRU5+Kb+yatFiddtQk6Rw@mail.gmail.com Backpatch-through: v12
Diffstat (limited to 'src/backend')
-rw-r--r--src/backend/utils/adt/geo_ops.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/adt/geo_ops.c b/src/backend/utils/adt/geo_ops.c
index bfd9ff6a36c..c93a8441aee 100644
--- a/src/backend/utils/adt/geo_ops.c
+++ b/src/backend/utils/adt/geo_ops.c
@@ -4763,7 +4763,7 @@ circle_same(PG_FUNCTION_ARGS)
CIRCLE *circle1 = PG_GETARG_CIRCLE_P(0);
CIRCLE *circle2 = PG_GETARG_CIRCLE_P(1);
- PG_RETURN_BOOL(((isnan(circle1->radius) && isnan(circle1->radius)) ||
+ PG_RETURN_BOOL(((isnan(circle1->radius) && isnan(circle2->radius)) ||
FPeq(circle1->radius, circle2->radius)) &&
point_eq_point(&circle1->center, &circle2->center));
}