diff options
Diffstat (limited to 'src/backend')
-rw-r--r-- | src/backend/commands/copy.c | 3 | ||||
-rw-r--r-- | src/backend/commands/trigger.c | 11 | ||||
-rw-r--r-- | src/backend/executor/execMain.c | 39 |
3 files changed, 25 insertions, 28 deletions
diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c index f22d0a07987..137b1ef42d9 100644 --- a/src/backend/commands/copy.c +++ b/src/backend/commands/copy.c @@ -2773,6 +2773,9 @@ CopyFrom(CopyState cstate) ExecDropSingleTupleTableSlot(cstate->partition_tuple_slot); } + /* Close any trigger target relations */ + ExecCleanUpTriggerState(estate); + FreeExecutorState(estate); /* diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c index 819395a9678..1566fb46074 100644 --- a/src/backend/commands/trigger.c +++ b/src/backend/commands/trigger.c @@ -4110,16 +4110,7 @@ afterTriggerInvokeEvents(AfterTriggerEventList *events, if (local_estate) { - ListCell *l; - - foreach(l, estate->es_trig_target_relations) - { - ResultRelInfo *resultRelInfo = (ResultRelInfo *) lfirst(l); - - /* Close indices and then the relation itself */ - ExecCloseIndices(resultRelInfo); - heap_close(resultRelInfo->ri_RelationDesc, NoLock); - } + ExecCleanUpTriggerState(estate); FreeExecutorState(estate); } diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c index 2535d2ee695..fb2ba3302c0 100644 --- a/src/backend/executor/execMain.c +++ b/src/backend/executor/execMain.c @@ -1447,6 +1447,24 @@ ExecGetTriggerResultRel(EState *estate, Oid relid) } /* + * Close any relations that have been opened by ExecGetTriggerResultRel(). + */ +void +ExecCleanUpTriggerState(EState *estate) +{ + ListCell *l; + + foreach(l, estate->es_trig_target_relations) + { + ResultRelInfo *resultRelInfo = (ResultRelInfo *) lfirst(l); + + /* Close indices and then the relation itself */ + ExecCloseIndices(resultRelInfo); + heap_close(resultRelInfo->ri_RelationDesc, NoLock); + } +} + +/* * ExecContextForcesOids * * This is pretty grotty: when doing INSERT, UPDATE, or CREATE TABLE AS, @@ -1610,16 +1628,8 @@ ExecEndPlan(PlanState *planstate, EState *estate) resultRelInfo++; } - /* - * likewise close any trigger target relations - */ - foreach(l, estate->es_trig_target_relations) - { - resultRelInfo = (ResultRelInfo *) lfirst(l); - /* Close indices and then the relation itself */ - ExecCloseIndices(resultRelInfo); - heap_close(resultRelInfo->ri_RelationDesc, NoLock); - } + /* likewise close any trigger target relations */ + ExecCleanUpTriggerState(estate); /* * close any relations selected FOR [KEY] UPDATE/SHARE, again keeping @@ -3173,14 +3183,7 @@ EvalPlanQualEnd(EPQState *epqstate) ExecResetTupleTable(estate->es_tupleTable, false); /* close any trigger target relations attached to this EState */ - foreach(l, estate->es_trig_target_relations) - { - ResultRelInfo *resultRelInfo = (ResultRelInfo *) lfirst(l); - - /* Close indices and then the relation itself */ - ExecCloseIndices(resultRelInfo); - heap_close(resultRelInfo->ri_RelationDesc, NoLock); - } + ExecCleanUpTriggerState(estate); MemoryContextSwitchTo(oldcontext); |