aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
...
* Fix division by zero in the new range type histogram creation.Heikki Linnakangas2012-08-30
| | | | Report and analysis by Matthias.
* Add missing period to detail message.Robert Haas2012-08-30
| | | | Per note from Peter Eisentraut.
* Document that COPY OUT requires an absolute pathname.Robert Haas2012-08-30
| | | | As suggested by Etsuro Fujita, but with somewhat different wording.
* Remove old documentation warnings about the use of bigint.Bruce Momjian2012-08-30
|
* Fix logic bug in gistchoose and gistRelocateBuildBuffersOnSplit.Robert Haas2012-08-30
| | | | | | | | | | | | Every time the best-tuple-found-so-far changes, we need to reset all the penalty values in which_grow[] to the penalties for the new best tuple. The old code failed to do this, resulting in inferior index quality. The original patch from Alexander Korotkov was just two lines; I took the liberty of fleshing that out by adding a bunch of comments that I hope will make this logic easier for others to understand than it was for me.
* Improve EXPLAIN's ability to cope with LATERAL references in plans.Tom Lane2012-08-30
| | | | | | | | | | push_child_plan/pop_child_plan didn't bother to adjust the "ancestors" list of parent plan nodes when descending to a child plan node. I think this was okay when it was written, but it's not okay in the presence of LATERAL references, since a subplan node could easily be returning a LATERAL value back up to the same nestloop node that provides the value. Per changed regression test results, the omission led to failure to interpret Param nodes that have perfectly good interpretations.
* Comment fixes.Robert Haas2012-08-30
| | | | Jeff Davis, somewhat edited by me
* Document that xslt-related RPMs may be needed to build docs.Robert Haas2012-08-30
|
* Also check for Python platform-specific include directoryPeter Eisentraut2012-08-29
| | | | | | | | | | | | Python can be built to have two separate include directories: one for platform-independent files and one for platform-specific files. So far, this has apparently never mattered for a PL/Python build. But with the new multi-arch Python packages in Debian and Ubuntu, this is becoming the standard configuration on these platforms, so we must check these directories separately to be able to build there. Also add a bit of reporting in configure to be able to see better what is going on with this.
* Adjust definition of cheapest_total_path to work better with LATERAL.Tom Lane2012-08-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the initial cut at LATERAL, I kept the rule that cheapest_total_path was always unparameterized, which meant it had to be NULL if the relation has no unparameterized paths. It turns out to work much more nicely if we always have *some* path nominated as cheapest-total for each relation. In particular, let's still say it's the cheapest unparameterized path if there is one; if not, take the cheapest-total-cost path among those of the minimum available parameterization. (The first rule is actually a special case of the second.) This allows reversion of some temporary lobotomizations I'd put in place. In particular, the planner can now consider hash and merge joins for joins below a parameter-supplying nestloop, even if there aren't any unparameterized paths available. This should bring planning of LATERAL-containing queries to the same level as queries not using that feature. Along the way, simplify management of parameterized paths in add_path() and friends. In the original coding for parameterized paths in 9.2, I tried to minimize the logic changes in add_path(), so it just treated parameterization as yet another dimension of comparison for paths. We later made it ignore pathkeys (sort ordering) of parameterized paths, on the grounds that ordering isn't a useful property for the path on the inside of a nestloop, so we might as well get rid of useless parameterized paths as quickly as possible. But we didn't take that reasoning as far as we should have. Startup cost isn't a useful property inside a nestloop either, so add_path() ought to discount startup cost of parameterized paths as well. Having done that, the secondary sorting I'd implemented (in add_parameterized_path) is no longer needed --- any parameterized path that survives add_path() at all is worth considering at higher levels. So this should be a bit faster as well as simpler.
* Document that NOTIFY events are visible to all users.Bruce Momjian2012-08-29
|
* Report postmaster.pid file as empty if it is empty, rather thanBruce Momjian2012-08-29
| | | | reporting in contains invalid data.
* Optimize SP-GiST insertions.Heikki Linnakangas2012-08-29
| | | | | | | This includes two micro-optimizations to the tight inner loop in descending the SP-GiST tree: 1. avoid an extra function call to index_getprocinfo when calling user-defined choose function, and 2. avoid a useless palloc+pfree when node labels are not used.
* Fix assorted compilation failures in contribAlvaro Herrera2012-08-28
| | | | Evidently I failed to test a compile after my earlier header shuffling.
* Add strerror() string to chdir() error messagePeter Eisentraut2012-08-28
|
* Split heapam_xlog.h from heapam.hAlvaro Herrera2012-08-28
| | | | | | | | | | | | The heapam XLog functions are used by other modules, not all of which are interested in the rest of the heapam API. With this, we let them get just the XLog stuff in which they are interested and not pollute them with unrelated includes. Also, since heapam.h no longer requires xlog.h, many files that do include heapam.h no longer get xlog.h automatically, including a few headers. This is useful because heapam.h is getting pulled in by execnodes.h, which is in turn included by a lot of files.
* remove catcache.h from syscache.hAlvaro Herrera2012-08-28
| | | | | Instead, place a forward struct declaration for struct catclist in syscache.h. This reduces header proliferation somewhat.
* Split resowner.hAlvaro Herrera2012-08-28
| | | | | This lets files that are mere users of ResourceOwner not automatically include the headers for stuff that is managed by the resowner mechanism.
* add #includes to plpy_subxactobject.h to make it compile standaloneAlvaro Herrera2012-08-28
|
* Remove pg_stat_statements--1.0.sql, too.Tom Lane2012-08-28
| | | | Per Peter Geoghegan.
* Remove hstore--1.0.sql.Tom Lane2012-08-28
| | | | | Since we're not installing this file anymore, it has no reason to exist, other than as historical reference; but we have an SCM for that.
* Adjust pg_test_timing to show shortest test durations first, placeBruce Momjian2012-08-28
| | | | percentage column before count column. Docs updated.
* Prevent psql tab completion in SET from adding TO when the equals signBruce Momjian2012-08-28
| | | | | | has no space before it. Report by Erik Rijkers
* Update doc mention of how to compute bigint advisory lock value, per TomBruce Momjian2012-08-28
| | | | Lane's correction.
* syncrep.h must include xlogdefs.hAlvaro Herrera2012-08-28
|
* Small punctuation fixesPeter Eisentraut2012-08-28
|
* Document how to create advisory lock "bigint" values in SQL.Bruce Momjian2012-08-27
| | | | David E. Wheeler
* Improve a couple of 9.2 release note entries.Tom Lane2012-08-27
| | | | | Clarify the compatibility notes about EXTRACT() and about statistics timing columns.
* Add section IDs to subsections of syntax.sgml that lacked them.Tom Lane2012-08-27
| | | | | | | This is so that these sections will have stable HTML tags that one can link to, rather than things like "AEN1902". Perhaps we should mount a campaign to do this everywhere, but I've found myself pointing at syntax.sgml subsections often enough to be sure it's useful here.
* Document the lack of reading the PGDATABASE environment variable inBruce Momjian2012-08-27
| | | | pg_restore.
* pg_upgrade: Fix exec_prog API to be less flakyAlvaro Herrera2012-08-27
| | | | | | | | | | The previous signature made it very easy to pass something other than the printf-format specifier in the corresponding position, without any warning from the compiler. While at it, move some of the escaping, redirecting and quoting responsibilities from the callers into exec_prog() itself. This makes the callsites cleaner.
* Fix thinko in commentAlvaro Herrera2012-08-27
| | | | It was confusing symlinks with hard links.
* Remove analyze_new_cluster.sh on make clean, tooAlvaro Herrera2012-08-27
|
* Fix DROP INDEX CONCURRENTLY IF EXISTS.Tom Lane2012-08-27
| | | | | | | | This threw ERROR, not the expected NOTICE, if the index didn't exist. The bug was actually visible in not-as-expected regression test output, so somebody wasn't paying too close attention in commit 8cb53654dbdb4c386369eb988062d0bbb6de725e. Per report from Brendan Byrd.
* Have pgindent requre pg_bsd_indent version 1.2 now that a new versionBruce Momjian2012-08-27
| | | | | | has been created by adding #include <stdlib.h> to parse.c. per request from Kevin Grittner.
* Collect and use histograms of lower and upper bounds for range types.Heikki Linnakangas2012-08-27
| | | | | | | | | | | | | | | This enables selectivity estimation of the <<, >>, &<, &> and && operators, as well as the normal inequality operators: <, <=, >=, >. "range @> element" is also supported, but the range-variant @> and <@ operators are not, because they cannot be sensibly estimated with lower and upper bound histograms alone. We would need to make some assumption about the lengths of the ranges for that. Alexander's patch included a separate histogram of lengths for that, but I left that out of the patch for simplicity. Hopefully that will be added as a followup patch. The fraction of empty ranges is also calculated and used in estimation. Alexander Korotkov, heavily modified by me.
* pg_basebackup: Correct error messagePeter Eisentraut2012-08-27
| | | | | It still thought that the --xlog-method option argument could be empty, as in a previous version of this feature.
* Update FreeBSD kernel configuration documentation.Bruce Momjian2012-08-26
| | | | Brad Davis
* Fix up planner infrastructure to support LATERAL properly.Tom Lane2012-08-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch takes care of a number of problems having to do with failure to choose valid join orders and incorrect handling of lateral references pulled up from subqueries. Notable changes: * Add a LateralJoinInfo data structure similar to SpecialJoinInfo, to represent join ordering constraints created by lateral references. (I first considered extending the SpecialJoinInfo structure, but the semantics are different enough that a separate data structure seems better.) Extend join_is_legal() and related functions to prevent trying to form unworkable joins, and to ensure that we will consider joins that satisfy lateral references even if the joins would be clauseless. * Fill in the infrastructure needed for the last few types of relation scan paths to support parameterization. We'd have wanted this eventually anyway, but it is necessary now because a relation that gets pulled up out of a UNION ALL subquery may acquire a reltargetlist containing lateral references, meaning that its paths *have* to be parameterized whether or not we have any code that can push join quals down into the scan. * Compute data about lateral references early in query_planner(), and save in RelOptInfo nodes, to avoid repetitive calculations later. * Assorted corner-case bug fixes. There's probably still some bugs left, but this is a lot closer to being real than it was before.
* Clarify documentation that primary key and unique constraints are copiedBruce Momjian2012-08-26
| | | | | | for CREATE TABLE LIKE ... INCLUDING INDEXES. Per report from david.sahagian@emc.com
* Use psql_error() for most psql error calls, per request from Magnus.Bruce Momjian2012-08-25
|
* Document clearly that psql \! parameter interpretation limitations areBruce Momjian2012-08-25
| | | | the same as \copy.
* Allow text timezone designations, e.g. "America/Chicago", when using theBruce Momjian2012-08-25
| | | | ISO "T" timestamptz format.
* Some spelling adjustments in release notesPeter Eisentraut2012-08-24
|
* Normalize some British spellingsPeter Eisentraut2012-08-24
|
* Fix issues with checks for unsupported transaction states in Hot Standby.Tom Lane2012-08-24
| | | | | | | | | | | | | | | | | | | | | | | | | The GUC check hooks for transaction_read_only and transaction_isolation tried to check RecoveryInProgress(), so as to disallow setting read/write mode or serializable isolation level (respectively) in hot standby sessions. However, GUC check hooks can be called in many situations where we're not connected to shared memory at all, resulting in a crash in RecoveryInProgress(). Among other cases, this results in EXEC_BACKEND builds crashing during child process start if default_transaction_isolation is serializable, as reported by Heikki Linnakangas. Protect those calls by silently allowing any setting when not inside a transaction; which is okay anyway since these GUCs are always reset at start of transaction. Also, add a check to GetSerializableTransactionSnapshot() to complain if we are in hot standby. We need that check despite the one in check_XactIsoLevel() because default_transaction_isolation could be serializable. We don't want to complain any sooner than this in such cases, since that would prevent running transactions at all in such a state; but a transaction can be run, if SET TRANSACTION ISOLATION is done before setting a snapshot. Per report some months ago from Robert Haas. Back-patch to 9.1, since these problems were introduced by the SSI patch. Kevin Grittner and Tom Lane, with ideas from Heikki Linnakangas
* Put options on man page and in help output in slightly better orderPeter Eisentraut2012-08-24
|
* libpq: Fix memory leak in URI parserPeter Eisentraut2012-08-23
| | | | | | When an invalid query parameter is reported, some memory leaks. found by Coverity
* Fix cascading privilege revoke to notice when privileges are still held.Tom Lane2012-08-23
| | | | | | | | | | | | If we revoke a grant option from some role X, but X still holds the option via another grant, we should not recursively revoke the privilege from role(s) Y that X had granted it to. This was supposedly fixed as one aspect of commit 4b2dafcc0b1a579ef5daaa2728223006d1ff98e9, but I must not have tested it, because in fact that code never worked: it forgot to shift the grant-option bits back over when masking the bits being revoked. Per bug #6728 from Daniel German. Back-patch to all active branches, since this has been wrong since 8.0.
* Fix typo in example.Heikki Linnakangas2012-08-23
|