aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Prevent CVS from mangling scriptAndrew Dunstan2008-06-15
|
* Add script to find .c and .h files that are missing CVS PostgreSQL markersAndrew Dunstan2008-06-15
| | | | | and add them. Avoids third party files or those that would cause regression failures.
* Make DROP INDEX lock the parent table before locking the index. This behaviorTom Lane2008-06-15
| | | | | | is necessary to avoid deadlock against ordinary queries, but we'd broken it with recent changes that made the DROP machinery lock the index before arriving at index_drop. Per intermittent buildfarm failures.
* Fix 64-bit problem in recent patch.Tom Lane2008-06-15
|
* Rearrange ALTER TABLE syntax processing as per my recent proposal: theTom Lane2008-06-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | grammar allows ALTER TABLE/INDEX/SEQUENCE/VIEW interchangeably for all subforms of those commands, and then we sort out what's really legal at execution time. This allows the ALTER SEQUENCE/VIEW reference pages to fully document all the ALTER forms available for sequences and views respectively, and eliminates a longstanding cause of confusion for users. The net effect is that the following forms are allowed that weren't before: ALTER SEQUENCE OWNER TO ALTER VIEW ALTER COLUMN SET/DROP DEFAULT ALTER VIEW OWNER TO ALTER VIEW SET SCHEMA (There's no actual functionality gain here, but formerly you had to say ALTER TABLE instead.) Interestingly, the grammar tables actually get smaller, probably because there are fewer special cases to keep track of. I did not disallow using ALTER TABLE for these operations. Perhaps we should, but there's a backwards-compatibility issue if we do; in fact it would break existing pg_dump scripts. I did however tighten up ALTER SEQUENCE and ALTER VIEW to reject non-sequences and non-views in the new cases as well as a couple of cases where they didn't before. The patch doesn't change pg_dump to use the new syntaxes, either.
* In log_filename documentation, mention that strftime is not used directly toAlvaro Herrera2008-06-14
| | | | | | expand the pattern specifier. Per gripe from Josh Drake.
* Refactor the handling of the various DropStmt variants so that when multipleTom Lane2008-06-14
| | | | | | | | | | | | | objects are specified, we drop them all in a single performMultipleDeletions call. This makes the RESTRICT/CASCADE checks more relaxed: it's not counted as a cascade if one of the later objects has a dependency on an earlier one. NOTICE messages about such cases go away, too. In passing, fix the permissions check for DROP CONVERSION, which for some reason was never made role-aware, and omitted the namespace-owner exemption too. Alex Hunsaker, with further fiddling by me.
* Modify TODO entry to be a function:Bruce Momjian2008-06-13
| | | | | | > o Add functions to syntax check configuration files > < * Add pg_ctl option to do a syntax check of postgresql.conf
* Improve the various elog messages in tuptoaster.c to report which TOAST tableTom Lane2008-06-13
| | | | | | | | | the problem happened in. These are all supposedly can't-happen cases, but when they do happen it's useful to know where. Back-patch to 8.3, but not further because the patch doesn't apply cleanly further back. Given the lack of response to my proposal of this, there doesn't seem to be enough interest to justify much back-porting effort.
* Use macro to document size of ecpg sqlerrmc string.Bruce Momjian2008-06-12
|
* Update item to mention target list problem:Bruce Momjian2008-06-12
| | | | | | | < * Allow INSERT/UPDATE ... RETURNING inside a SELECT 'FROM' clause > * Allow INSERT/UPDATE ... RETURNING inside a SELECT 'FROM' clause or > target list > http://archives.postgresql.org/pgsql-hackers/2008-06/msg00124.php
* Refactor XLogOpenRelation() and XLogReadBuffer() in preparation for relationHeikki Linnakangas2008-06-12
| | | | | | | | | | forks. XLogOpenRelation() and the associated light-weight relation cache in xlogutils.c is gone, and XLogReadBuffer() now takes a RelFileNode as argument, instead of Relation. For functions that still need a Relation struct during WAL replay, there's a new function called CreateFakeRelcacheEntry() that returns a fake entry like XLogOpenRelation() used to.
* Improve reporting of dependencies in DROP to work like the scheme that weTom Lane2008-06-11
| | | | | | devised for pg_shdepend, namely the individual dependencies are reported as DETAIL lines rather than coming out as separate NOTICEs. The client-side report is capped at 100 lines, but the server log always gets a full report.
* Add:Bruce Momjian2008-06-11
| | | | > * Add pg_ctl option to do a syntax check of postgresql.conf
* Fix spelling mistake in postgresql.conf.Bruce Momjian2008-06-11
| | | | Greg Sabino Mullane
* Update "help" output to reflect that \timing now takes an optional on/offHeikki Linnakangas2008-06-11
| | | | argument.
* Add optional on/off argument to \timing.Heikki Linnakangas2008-06-11
| | | | David Fetter.
* Fix bug in the WAL recovery code to finish an incomplete split.Heikki Linnakangas2008-06-11
| | | | | | | CacheInvalidateRelcache() crashes if called in WAL recovery, because the invalidation infrastructure hasn't been initialized yet. Back-patch to 8.2, where the bug was introduced.
* Editorialization for the text emitted by the "help" psql command.Neil Conway2008-06-10
| | | | | | Basically just reuse the same text that psql emitted as part of its startup banner in prior versions, and make some whitespace more consistent with the conventions in other psql command output.
* Create a script to handle stamping release version numbers into files,Tom Lane2008-06-10
| | | | replacing the tedious and error-prone manual process we've been using.
* Comment fix, should say TSQuery instead of TSVector.Heikki Linnakangas2008-06-10
| | | | Per Jan Urbanski.
* Make XML building work silently on VPATH builds (untested on regular builds).Alvaro Herrera2008-06-10
|
* Fix unportable (and incorrect anyway) usage of LL constant suffix thatTom Lane2008-06-09
| | | | recently snuck into cash.c. Per report from Edmundo Robles Lopez.
* Update Japanese FAQ.Bruce Momjian2008-06-09
| | | | Jun Kuwamura
* Fix datetime input functions to correctly detect integer overflow whenTom Lane2008-06-09
| | | | | running on a 64-bit platform ... strtol() will happily return 64-bit output in that case. Per bug #4231 from Geoff Tolley.
* Fix an ALTER TABLE test case so that it actually tests what the comment says itTom Lane2008-06-09
| | | | is testing. Ah, the perils of making keywords optional ...
* Further tweak for comment in CheckDeadLock(), per Tom.Neil Conway2008-06-09
|
* Fix typo in comment.Neil Conway2008-06-09
|
* Fix breakage caused by conflicting patches, as evidenced by the buildfarm.Alvaro Herrera2008-06-08
|
* Rewrite DROP's dependency traversal algorithm into an honest two-passTom Lane2008-06-08
| | | | | | | | | | | | | algorithm, replacing the original intention of a one-pass search, which had been hacked up over time to be partially two-pass in hopes of handling various corner cases better. It still wasn't quite there, especially as regards emitting unwanted NOTICE messages. More importantly, this approach lets us fix a number of open bugs concerning concurrent DROP scenarios, because we can take locks during the first pass and avoid traversing to dependent objects that were just deleted by someone else. There is more that can be done here, but I'll go ahead and commit the base patch before working on the options.
* Move BufferGetPageSize and BufferGetPage from bufpage.h to bufmgr.h. It isAlvaro Herrera2008-06-08
| | | | | | | | | | more logical that way, and also it reduces the amount of unnecessary includes in bufpage.h, which is widely used. Zdenek Kotala. My previous patch to bufpage.h should also have credited him as author, but I forgot (sorry about that).
* Update release notes for ALTER AGGREGATE fix.Tom Lane2008-06-08
|
* ALTER AGGREGATE OWNER seems to have been missed by the last couple ofTom Lane2008-06-08
| | | | | | | patches that dealt with object ownership. It wasn't updating pg_shdepend nor adjusting the aggregate's ACL. In 8.2 and up, fix this permanently by making it use AlterFunctionOwner_oid. In 8.1, the function code wasn't factored that way, so just copy and paste.
* Update release notes for 8.3.3 et al.Tom Lane2008-06-07
|
* Change xlog.h to xlogdefs.h in bufpage.h, and fix fallout.Alvaro Herrera2008-06-06
|
* Fix pg_get_ruledef() so that negative numeric constants are parenthesized.Tom Lane2008-06-06
| | | | | | | | | | This is needed because :: casting binds more tightly than minus, so for example -1::integer is not the same as (-1)::integer, and there are cases where the difference is important. In particular this caused a failure in SELECT DISTINCT ... ORDER BY ... where expressions that should have matched were seen as different by the parser; but I suspect that there could be other cases where failure to parenthesize leads to subtler semantic differences in reloaded rules. Per report from Alexandr Popov.
* Fix missing "not", per Frank Millman (bug #4212).Alvaro Herrera2008-06-05
|
* Modify vacuum() to accept a single relation OID instead of a list (which weAlvaro Herrera2008-06-05
| | | | always pass as a single element anyway.) In passing, fix an outdated comment.
* Fix some string building in getObjectDescription.Alvaro Herrera2008-06-05
|
* Added lost sysmbol SQL_SQL to list of allowed variable names.Michael Meskes2008-06-04
|
* Draft release notes for upcoming back-branch updates.Tom Lane2008-06-04
|
* Fix initdb to reject a relative path for -X (--xlogdir) argument. ThisTom Lane2008-06-02
| | | | | | | doesn't work, and the real reason why not is it's unclear where the path is relative to (initdb's CWD, or the data directory?). We could make an arbitrary decision, but it seems best to make the user be unambiguous. Per gripe from Devrim.
* Update time zone data files to tzdata release 2008c (DST law changes inTom Lane2008-06-01
| | | | Morocco, Iraq, Choibalsan, Pakistan, Syria, Cuba, Argentina/San_Luis).
* Refactor SPI_cursor_open/SPI_cursor_open_with_args so that the latter setsTom Lane2008-06-01
| | | | | | | | the PARAM_FLAG_CONST flag on the parameters that are passed into the portal, while the former's behavior is unchanged. This should only affect the case where the portal is executing an EXPLAIN; it will cause the generated plan to look more like what would be generated if the portal were actually executing the command being explained. Per gripe from Pavel.
* Marginal improvements to the documentation for PGOPTIONS.Tom Lane2008-06-01
|
* Done: -Remove psql newline patch when we find out why mingw outputs an ↵Andrew Dunstan2008-05-31
| | | | extra newline
* Copy refint.so and autoinc.so into the src/test/regress directory duringTom Lane2008-05-30
| | | | | | | | | | | | "make all", and then reference them there during the actual tests. This makes the handling of these files more parallel to that of regress.so, and in particular simplifies use of the regression tests outside the original build tree. The PGDG and Red Hat RPMs have been doing this via patches for a very long time. Inclusion of the change in core was requested by Jørgen Austvik of Sun, and I can't see any reason not to. I attempted to fix the MSVC scripts for this too, but they may need further tweaking ...
* Improve the documentation comment for replace(). Robert TreatTom Lane2008-05-29
|
* Tweak libpq to avoid crashing due to incorrect buffer size calculation whenTom Lane2008-05-29
| | | | | | | | | | | | | | we are on a 64-bit machine (ie, size_t is wider than int) and someone passes in a query string that approaches or exceeds INT_MAX bytes. Also, just for paranoia's sake, guard against similar overflows in sizing the input buffer. The backend will not in the foreseeable future be prepared to send or receive strings exceeding 1GB, so I didn't take the more invasive step of switching all the buffer index variables from int to size_t; though someday we might want to do that. I have a suspicion that this is not the only such bug in libpq, but this fix is enough to take care of the crash reported by Francisco Reyes.
* Fix some bugs introduced by the 8.2-era conversion of cube functions to V1Tom Lane2008-05-29
| | | | | | | | | | | | | calling convention. cube_inter and cube_distance could attempt to pfree their input arguments, and cube_dim returned a value from a struct it might have just pfree'd (which would only really cause a problem in a debug build, but it's still wrong). Per bug #4208 and additional code reading. In HEAD and 8.3, I also made a batch of cosmetic changes to bring these functions into line with the preferred coding style for V1 functions, ie declare and fetch all the arguments at the top so readers can easily see what they are.