aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Documentation fixes for FILLFACTOR patch. Minor other editorialization.Tom Lane2006-07-04
|
* Modify:Bruce Momjian2006-07-04
| | | | | < o -Add PQescapeIdentifier() > o Add PQescapeIdentifierConn()
* Remove libpq's PQescapeIdentifier(), not safe from injection attacks.Bruce Momjian2006-07-04
|
* Fix typos in comments.Neil Conway2006-07-04
|
* Code review for FILLFACTOR patch. Change WITH grammar as per earlierTom Lane2006-07-03
| | | | | | | | | | | | | | | | discussion (including making def_arg allow reserved words), add missed opt_definition for UNIQUE case. Put the reloptions support code in a less random place (I chose to make a new file access/common/reloptions.c). Eliminate header inclusion creep. Make the index options functions safely user-callable (seems like client apps might like to be able to test validity of options before trying to make an index). Reduce overhead for normal case with no options by allowing rd_options to be NULL. Fix some unmaintainably klugy code, including getting rid of Natts_pg_class_fixed at long last. Some stylistic cleanup too, and pay attention to keeping comments in sync with code. Documentation still needs work, though I did fix the omissions in catalogs.sgml and indexam.sgml.
* Fix broken markup.Tom Lane2006-07-03
|
* Do a pass of code review for the ALTER TABLE ADD INHERITS patch. KeepNeil Conway2006-07-02
| | | | | | | | | the read lock we hold on the table's parent relation until commit. Update equalfuncs.c for the new field in AlterTableCmd. Various improvements to comments, variable names, and error reporting. There is room for further improvement here, but this is at least a step in the right direction.
* Add FILLFACTOR to CREATE INDEX.Bruce Momjian2006-07-02
| | | | ITAGAKI Takahiro
* Done:Bruce Momjian2006-07-02
| | | | > * -Add fillfactor to control reserved free space during index creation
* Done:Bruce Momjian2006-07-02
| | | | | | | | | | < o Add ALTER TABLE tab ADD/DROP INHERITS parent < < This allows tables to be added/removed from an inheritance < hierarchy. This is particularly useful for table partitioning. < http://archives.postgresql.org/pgsql-hackers/2006-05/msg00988.php < > o -Add ALTER TABLE tab INHERIT / NO INHERIT parent
* ALTER TABLE ... ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)Bruce Momjian2006-07-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Open items: There were a few tangentially related issues that have come up that I think are TODOs. I'm likely to tackle one or two of these next so I'm interested in hearing feedback on them as well. . Constraints currently do not know anything about inheritance. Tom suggested adding a coninhcount and conislocal like attributes have to track their inheritance status. . Foreign key constraints currently do not get copied to new children (and therefore my code doesn't verify them). I don't think it would be hard to add them and treat them like CHECK constraints. . No constraints at all are copied to tables defined with LIKE. That makes it hard to use LIKE to define new partitions. The standard defines LIKE and specifically says it does not copy constraints. But the standard already has an option called INCLUDING DEFAULTS; we could always define a non-standard extension LIKE table INCLUDING CONSTRAINTS that gives the user the option to request a copy including constraints. . Personally, I think the whole attislocal thing is bunk. The decision about whether to drop a column from children tables or not is something that should be up to the user and trying to DWIM based on whether there was ever a local definition or the column was acquired purely through inheritance is hardly ever going to match up with user expectations. . And of course there's the whole unique and primary key constraint issue. I think to get any traction at all on this you have a prerequisite of a real partitioned table implementation where the system knows what the partition key is so it can recognize when it's a leading part of an index key. Greg Stark
* Fix oversight in planning for multiple indexscans driven byTom Lane2006-07-01
| | | | | | | | ScalarArrayOpExpr index quals: we were estimating the right total number of rows returned, but treating the index-access part of the cost as if a single scan were fetching that many consecutive index tuples. Actually we should treat it as a multiple indexscan, and if there are enough of 'em the Mackert-Lohman discount should kick in.
* Revise the planner's handling of "pseudoconstant" WHERE clauses, that isTom Lane2006-07-01
| | | | | | | | | | | | | | | | | | | clauses containing no variables and no volatile functions. Such a clause can be used as a one-time qual in a gating Result plan node, to suppress plan execution entirely when it is false. Even when the clause is true, putting it in a gating node wins by avoiding repeated evaluation of the clause. In previous PG releases, query_planner() would do this for pseudoconstant clauses appearing at the top level of the jointree, but there was no ability to generate a gating Result deeper in the plan tree. To fix it, get rid of the special case in query_planner(), and instead process pseudoconstant clauses through the normal RestrictInfo qual distribution mechanism. When a pseudoconstant clause is found attached to a path node in create_plan(), pull it out and generate a gating Result at that point. This requires special-casing pseudoconstants in selectivity estimation and cost_qual_eval, but on the whole it's pretty clean. It probably even makes the planner a bit faster than before for the normal case of no pseudoconstants, since removing pull_constant_clauses saves one useless traversal of the qual tree. Per gripe from Phil Frost.
* Fix memory leak introduced in the prior commit, detected by Tom Lane.Alvaro Herrera2006-06-30
|
* Fix use-after-free error reported by Neil Conway.Alvaro Herrera2006-06-30
|
* Update item for GUID:Bruce Momjian2006-06-30
| | | | | < * Add 128-bit Universally Unique Identifier (UUID) > * Add Globally/Universally Unique Identifier (GUID/UUID)
* Remove the separate 'stats buffer' process, letting backend stats messagesTom Lane2006-06-29
| | | | | | | | | be delivered directly to the collector process. The extra process context swaps required to transfer data through the buffer process seem to outweigh any value the buffering might have. Per recent discussion and tests. I modified Bruce's draft patch to use poll() rather than select() where available (this makes a noticeable difference on my system), and fixed up the EXEC_BACKEND case.
* Change TRUNCATE's method for searching for foreign-key references so thatTom Lane2006-06-29
| | | | | | the order in which it visits tables is not dependent on the physical order of pg_constraint entries, and neither are the error messages it gives. This should correct recently-noticed instability in regression tests.
* Change URL for SITC:Bruce Momjian2006-06-29
| | | | | < http://momjian.us/cgi-bin/pgsitc > http://archives.postgresql.org/pgsql-hackers/2006-06/msg01534.php
* Add:Bruce Momjian2006-06-29
| | | | > * Add 128-bit Universally Unique Identifier (UUID)
* Add missing #include directive: pg_constraint.h declares some functionsNeil Conway2006-06-28
| | | | | whose prototypes include the "List" type, so it ought to include the list header file.
* Fix typo in comment.Neil Conway2006-06-28
|
* Editorialization for the additions to the CREATE TABLE reference pageNeil Conway2006-06-28
| | | | | | made as part of the recent INCLUDING CONSTRAINTS patch. The text could stand further improvement, but this is at least a step in the right direction.
* Add URL for SITCBruce Momjian2006-06-28
| | | | > http://momjian.us/cgi-bin/pgsitc
* Improve planner estimates for size of tuple hash tables.Tom Lane2006-06-28
|
* Fix hash aggregation to suppress unneeded columns from being stored inTom Lane2006-06-28
| | | | | | | | | tuple hash table entries. This addresses the problem previously noted that use of a 'physical tlist' in the input scan node could bloat the hash table entries far beyond what the planner expects. It's a better answer than my previous thought of undoing the physical tlist optimization, because we can also remove columns that are needed to compute the aggregate functions but aren't part of the grouping column set.
* Adjust TupleHashTables to use MinimalTuple format for contained tuples.Tom Lane2006-06-28
|
* Update:Bruce Momjian2006-06-28
| | | | | | | | | < o Add support for WITH HOLD cursors > o Add support for WITH HOLD and SCROLL cursors > > PL/pgSQL cursors should support the same syntax as > backend cursors. >
* Update Russian FAQ.Bruce Momjian2006-06-28
| | | | Viktor Vislobokov
* Forget to add new file :((Teodor Sigaev2006-06-28
|
* ChangesTeodor Sigaev2006-06-28
| | | | | | | | | | | | | | | | | | | | * new split algorithm (as proposed in http://archives.postgresql.org/pgsql-hackers/2006-06/msg00254.php) * possible call pickSplit() for second and below columns * add spl_(l|r)datum_exists to GIST_SPLITVEC - pickSplit should check its values to use already defined spl_(l|r)datum for splitting. pickSplit should set spl_(l|r)datum_exists to 'false' (if they was 'true') to signal to caller about using spl_(l|r)datum. * support for old pickSplit(): not very optimal but correct split * remove 'bytes' field from GISTENTRY: in any case size of value is defined by it's type. * split GIST_SPLITVEC to two structures: one for using in picksplit and second - for internal use. * some code refactoring * support of subsplit to rtree opclasses TODO: add support of subsplit to contrib modules
* Remove embedded newline in string literal --- seems to make newer gccTom Lane2006-06-27
| | | | versions very unhappy, and shouldn't be there anyway.
* Add GUC update_process_title to control whether 'ps' display is updatedBruce Momjian2006-06-27
| | | | for every command, default to on.
* Convert hash join code to use MinimalTuple format in tuple hash tableTom Lane2006-06-27
| | | | and batch files. Should reduce memory and I/O demands for such joins.
* Default stats_command_string to 'on', now that its overhead is minimal.Bruce Momjian2006-06-27
|
* Put #ifdef NOT_USED around posix_fadvise call. We may want to resurrectTom Lane2006-06-27
| | | | | | this someday, but right now it seems that posix_fadvise is immature to the point of being broken on many platforms ... and we don't have any benchmark evidence proving it's worth spending time on.
* Revert patch, doesn't do what it should:Bruce Momjian2006-06-27
| | | | | | * %Disallow changing default expression of a SERIAL column Dhanaraj M
* Extend the MinimalTuple concept to tuplesort.c, thereby reducing theTom Lane2006-06-27
| | | | | | | | | per-tuple space overhead for sorts in memory. I chose to replace the previous patch that tried to write out the bare minimum amount of data when sorting on disk; instead, just dump the MinimalTuples as-is. This wastes 3 to 10 bytes per tuple depending on architecture and null-bitmap length, but the simplification in the writetup/readtup routines seems worth it.
* Will revert in next patch more cleanly.Bruce Momjian2006-06-27
| | | | > * -Disallow changing DEFAULT expression of a SERIAL column
* Not done:Bruce Momjian2006-06-27
| | | | | < * -Disallow changing DEFAULT expression of a SERIAL column > * %Disallow changing DEFAULT expression of a SERIAL column
* Clamp last_anl_tuples to n_live_tuples, in case we vacuum a table withoutAlvaro Herrera2006-06-27
| | | | | | | | analyzing, so that future analyze threshold calculations don't get confused. Also, make sure we correctly track the decrease of live tuples cause by deletes. Per report from Dylan Hansen, patches by Tom Lane and me.
* Add INCLUDING CONSTRAINTS to CREATE TABLE LIKE.Bruce Momjian2006-06-27
| | | | Greg Stark
* Done:Bruce Momjian2006-06-27
| | | | | | | | | < * %Disallow changing DEFAULT expression of a SERIAL column? < < This should be done only if the existing SERIAL problems cannot be < fixed. < > * -Disallow changing DEFAULT expression of a SERIAL column
* Disallow changing/dropping default expression of a SERIAL columnBruce Momjian2006-06-27
| | | | Dhanaraj M
* Fix for recent Win32 pg_dump tar temp file patch.Bruce Momjian2006-06-27
| | | | Hiroshi Saito
* Create infrastructure for 'MinimalTuple' representation of in-memoryTom Lane2006-06-27
| | | | | | | | tuples with less header overhead than a regular HeapTuple, per my recent proposal. Teach TupleTableSlot code how to deal with these. As proof of concept, change tuplestore.c to store MinimalTuples instead of HeapTuples. Future patches will expand the concept to other places where it is useful.
* On Win32, use loop to create pg_dump temporary tar file in the currentBruce Momjian2006-06-27
| | | | | | directory, not in device root, for permission reasons. Backpatch to 8.1.X.
* Done:Bruce Momjian2006-06-27
| | | | > o -Add PQescapeIdentifier()
* Add PQescapeIdentifier() to libpqBruce Momjian2006-06-27
| | | | Christopher Kings-Lynne
* Fix blank line.Bruce Momjian2006-06-26
|
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-05 16:26:36 +0000