aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Update wording from David Fetter.Bruce Momjian2008-04-25
|
* Update to remove passive wording from FAQ, David FetterBruce Momjian2008-04-25
|
* Update TODO item:Bruce Momjian2008-04-24
| | | | | > * Allow adding/renaming/removing enumerated values to an existing > enumerated data type
* Remove transformAlterTableStmt's kluge to replace ColumnDef.is_not_nullTom Lane2008-04-24
| | | | | | | | | flags by separate AT_SetNotNull subcommands. That was always ugly and inefficient, and it's now clear that it was merely a partial workaround for the bug just identified in ATExecAddColumn. This is just code beautification not a bug fix, so no back-patch. Brendan Jurd, with some trivial additional cleanup by me.
* Update:Bruce Momjian2008-04-24
| | | | | < * Allow adding enumerated values to an existing enumerated data > * Allow adding/removing enumerated values to an existing enumerated data
* Fix ALTER TABLE ADD COLUMN ... PRIMARY KEY so that the new column is correctlyTom Lane2008-04-24
| | | | | | | | | | checked to see if it's been initialized to all non-nulls. The implicit NOT NULL constraint was not being checked during the ALTER (in fact, not even if there was an explicit NOT NULL too), because ATExecAddColumn neglected to set the flag needed to make the test happen. This has been broken since the capability was first added, in 8.0. Brendan Jurd, per a report from Kaloyan Iliev.
* Add embedded usage mention to FAQ, per Greg Smith.Bruce Momjian2008-04-24
|
* Add to TODO:Bruce Momjian2008-04-24
| | | | | | | | > * Allow prepared transactions with temporary tables created and dropped > in the same transaction, and when an ON COMMIT DELETE ROWS temporary > table is accessed > > http://archives.postgresql.org/pgsql-hackers/2008-03/msg00047.php
* Add TODO item:Bruce Momjian2008-04-24
| | | | | | | > > o Impove COPY performance > > http://archives.postgresql.org/pgsql-hackers/2008-02/msg00954.php
* Add URL for:Bruce Momjian2008-04-24
| | | | | | | | * Allow index scans to return matching index keys, not just the matching heap locations > > http://archives.postgresql.org/pgsql-hackers/2008-04/msg01657.php >
* Add to TODO:Bruce Momjian2008-04-24
| | | | | > * Allow index scans to return matching index keys, not just the matching > heap locations
* Add to TODO:Bruce Momjian2008-04-24
| | | | | | < > * Allow adding enumerated values to an existing enumerated data > type
* Remove, item done, description unclear:Bruce Momjian2008-04-24
| | | | | | < * Allow index scans to return matching index keys < < http://archives.postgresql.org/pgsql-hackers/2007-03/msg01079.php
* Update TODO description for GIT:Bruce Momjian2008-04-24
| | | | | * Consider smaller indexes that record a range of values per heap page, rather than having one index entry for every heap row
* Update error messages, per notes from Tom.Magnus Hagander2008-04-24
| | | | Laurenz Albe
* Add GIT URL:Bruce Momjian2008-04-24
| | | | > http://archives.postgresql.org/pgsql-hackers/2008-04/msg01589.php
* Add to TODO:Bruce Momjian2008-04-24
| | | | | < > o Add prompt escape to display the client and server versions
* Add URL for MERGE:Bruce Momjian2008-04-23
| | | | > http://archives.postgresql.org/pgsql-hackers/2008-04/msg01475.php
* Prevent shutdown in normal mode if online backup is running, andMagnus Hagander2008-04-23
| | | | | | | | | have pg_ctl warn about this. Cancel running online backups (by renaming the backup_label file, thus rendering the backup useless) when shutting down in fast mode. Laurenz Albe
* Fix using too many LWLocks bug, reported by Craig RingerTeodor Sigaev2008-04-22
| | | | | | | | | <craig@postnewspapers.com.au>. It was my mistake, I missed limitation of number of held locks, now GIN doesn't use continiuous locks, but still hold buffers pinned to prevent interference with vacuum's deletion algorithm. Backpatch is needed.
* Don't pull in pthreads header files in this file because we never use them.Magnus Hagander2008-04-22
|
* FAQ2txt now only controls the main FAQ, not FAQ_DEV.Bruce Momjian2008-04-22
|
* Replace developer FAQ with a reference to the wiki, which is whereMagnus Hagander2008-04-22
| | | | it now lives (per discussion). Leave the other FAQs alone for now.
* Issue explicit error messages for attempts to use "shell" operators inTom Lane2008-04-22
| | | | | | | | | | ordinary expressions. This probably doesn't catch every single case where you might get "cache lookup failed for function 0" for use of a shell operator, but it will catch most. Per bug #4120 from Pedro Gimeno. This patch incidentally folds make_op_expr() into its sole remaining caller --- the alternative was to give it yet more arguments, which didn't seem an improvement.
* Fix convert_IN_to_join to properly handle the case where the subselect'sTom Lane2008-04-21
| | | | | | | | | | | | | | | | | | | | | | | | | output is not of the same type that's needed for the IN comparison (ie, where the parser inserted an implicit coercion above the subselect result). We should record the coerced expression, not just a raw Var referencing the subselect output, as the quantity that needs to be unique-ified if we choose to implement the IN as Unique followed by a plain join. As of 8.3 this error was causing crashes, as seen in bug #4113 from Javier Hernandez, because the executor was being told to hash or sort the raw subselect output column using operators appropriate to the coerced type. In prior versions there was no crash because the executor chose the hash or sort operators for itself based on the column type it saw. However, that's still not really right, because what's unique for one data type might not be unique for another. In corner cases we could get multiple outputs of a row that should appear only once, as demonstrated by the regression test case included in this commit. However, this patch doesn't apply cleanly to 8.2 or before, and the code involved has shifted enough over time that I'm hesitant to try to back-patch. Given the lack of complaints from the field about such corner cases, I think the bug may not be important enough to risk breaking other things with a back-patch.
* Clean up float4byval and float8byval handling by dealing with them completelyMagnus Hagander2008-04-21
| | | | from inside the build script.
* Fix typo, noted by Stefan Kaltenbrunner.Magnus Hagander2008-04-21
|
* Make float4byval and float8byval configurable on MSVC.Magnus Hagander2008-04-21
|
* Add link to major version release notes at the top of the minorMagnus Hagander2008-04-21
| | | | | | version ones, to make it clear to users just browsing the notes that there are a lot more changes available from whatever version they are at than what's in the minor version release notes.
* Fix a couple of places in execMain that erroneously assumed that SELECT FORTom Lane2008-04-21
| | | | | | | | | | UPDATE/SHARE couldn't occur as a subquery in a query with a non-SELECT top-level operation. Symptoms included outright failure (as in report from Mark Mielke) and silently neglecting to take the requested row locks. Back-patch to 8.3, because the visible failure in the INSERT ... SELECT case is a regression from 8.2. I'm a bit hesitant to back-patch further given the lack of field complaints.
* Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a stopgapTom Lane2008-04-21
| | | | | | measure to get the Windows buildfarm members working again. I don't know if it's worth exposing these as configurables, or exactly how to do it in the MSVC build system ...
* Make earthdistance use version-0 calling convention if not USE_FLOAT8_BYVAL,Tom Lane2008-04-21
| | | | | | | | | | and version-1 if USE_FLOAT8_BYVAL. This might seem a bit pointless, but the idea is to have at least one regression test that will fail if we ever accidentally break version-0 functions that return float8. However, they're already broken, or at least hopelessly unportable, in the USE_FLOAT8_BYVAL case. Per a recent suggestion from Greg Stark.
* Allow float8, int8, and related datatypes to be passed by value on machinesTom Lane2008-04-21
| | | | | | | | | | where Datum is 8 bytes wide. Since this will break old-style C functions (those still using version 0 calling convention) that have arguments or results of these types, provide a configure option to disable it and retain the old pass-by-reference behavior. Likewise, provide a configure option to disable the recently-committed float4 pass-by-value change. Zoltan Boszormenyi, plus configurability stuff by me.
* Fix broken compare function for tsquery_ops. Per Tom's report.Teodor Sigaev2008-04-20
| | | | | | | | | | I never understood why initial authors GiST in pgsql choose so stgrange signature for 'same' method: bool *sameFn(Datum a, Datum b, bool* result) instead of simple, logical bool sameFn(Datum a, Datum b) This change will break any existing GiST extension, so we still live with it and will live.
* Convert earthdistance's only C function to v1 call convention,Tom Lane2008-04-20
| | | | to future-proof it against pass-by-value float8.
* seg_size() has to be V1 calling convention, too.Tom Lane2008-04-19
|
* Update doc script comments.Bruce Momjian2008-04-19
|
* Add script FAQ2txt to convert HTML files to txt. Add comment to TODO2html.Bruce Momjian2008-04-19
|
* Add TODO2html tool to convert TODO to HTML.Bruce Momjian2008-04-19
|
* Update TODO using new script.Bruce Momjian2008-04-19
|
* Remove TODO.detail directory. All URLs now in TODO file as references.Bruce Momjian2008-04-19
|
* Remove TODO.detail references; instead add TODO URLs pointing to theBruce Momjian2008-04-19
| | | | archives. We have been using URLs for a while for new items.
* Change the float4-returning functions in contrib/seg to fmgr v1 callingAlvaro Herrera2008-04-18
| | | | | | | conventions. I also changed seg_in and seg_out, which was probably unnecessary, but it can't harm.
* Fix typo.Tom Lane2008-04-18
|
* Modify the float4 datatype to be pass-by-val. Along the way, remove the lastAlvaro Herrera2008-04-18
| | | | | | | | | | | | | | | uses of the long-deprecated float32 in contrib/seg; the definitions themselves are still there, but no longer used. fmgr/README updated to match. I added a CREATE FUNCTION to account for existing seg_center() code in seg.c too, and some tests for it and the neighbor functions. At the same time, remove checks for NULL which are not needed (because the functions are declared STRICT). I had to do some adjustments to contrib's btree_gist too. The choices for representation there are not ideal for changing the underlying types :-( Original patch by Zoltan Boszormenyi, with some adjustments by me.
* Fix rmtree() so that it keeps going after failure to remove any individualTom Lane2008-04-18
| | | | | | file; the idea is that we should clean up as much as we can, even if there's some problem removing one file. Make the error messages a bit less misleading, too. In passing, const-ify function arguments.
* Fix two race conditions between the pending unlink mechanism that was put inHeikki Linnakangas2008-04-18
| | | | | | | | | | | | | | | | | | | | | place to prevent reusing relation OIDs before next checkpoint, and DROP DATABASE. First, if a database was dropped, bgwriter would still try to unlink the files that the rmtree() call by the DROP DATABASE command has already deleted, or is just about to delete. Second, if a database is dropped, and another database is created with the same OID, bgwriter would in the worst case delete a relation in the new database that happened to get the same OID as a dropped relation in the old database. To fix these race conditions: - make rmtree() ignore ENOENT errors. This fixes the 1st race condition. - make ForgetDatabaseFsyncRequests forget unlink requests as well. - force checkpoint on in dropdb on all platforms Since ForgetDatabaseFsyncRequests() is asynchronous, the 2nd change isn't enough on its own to fix the problem of dropping and creating a database with same OID, but forcing a checkpoint on DROP DATABASE makes it sufficient. Per Tom Lane's bug report and proposal. Backpatch to 8.3.
* Cause EXPLAIN's VERBOSE option to print the target list (output column list)Tom Lane2008-04-18
| | | | | | | | | | of each plan node, instead of its former behavior of dumping the internal representation of the plan tree. The latter display is still available for those who really want it (see debug_print_plan), but uses for it are certainly few and and far between. Per discussion. This patch also removes the explain_pretty_print GUC, which is obsoleted by the change.
* Clean up a few places where Datums were being treated as pointers (and viceAlvaro Herrera2008-04-17
| | | | | | versa) without going through DatumGetPointer. Gavin Sherry, with Feng Tian.
* Fix a couple of oversights associated with the "physical tlist" optimization:Tom Lane2008-04-17
| | | | | | | | | | | | | | | | | | | | | we had several code paths where a physical tlist could be used for the input to a Sort node, which is a dumb idea because any unneeded table columns will increase the volume of data the sort has to push around. (Unfortunately the easy-looking fix of calling disuse_physical_tlist during make_sort_xxx doesn't work because in most cases we're already committed to the current input tlist --- it's been marked with sort column numbers, or we've built grouping column numbers using it, etc. The tlist has to be selected properly at the calling level before we start constructing sort-col information. This is easy enough to do, we were just failing to take the point into consideration.) Back-patch to 8.3. I believe the problem probably exists clear back to 7.4 when the physical tlist optimization was added, but I'm afraid to back-patch further than 8.3 without a great deal more study than I want to put into it. The code in this area has drifted a lot over time. The real-world importance of these code paths is uncertain anyway --- I think in many cases we'd probably prefer hash-based methods.