aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Fix unsafe event-trigger coding in ProcessUtility().Tom Lane2013-04-27
| | | | | | | | | | | | | | | | | | | | | We mustn't run any of the event-trigger support code when handling utility statements like START TRANSACTION or ABORT, because that code may need to refresh event-trigger cache data, which requires being inside a valid transaction. (This mistake explains the consistent build failures exhibited by the CLOBBER_CACHE_ALWAYS buildfarm members, as well as some irreproducible failures on other members.) The least messy fix seems to be to break standard_ProcessUtility into two functions, one that handles all the statements not supported by event triggers, and one that contains the event-trigger support code and handles the statements that are supported by event triggers. This change also fixes several inconsistencies, such as four cases where support had been installed for "ddl_event_start" but not "ddl_event_end" triggers, plus the fact that InvokeDDLCommandEventTriggersIfSupported() paid no mind to isCompleteQuery. Dimitri Fontaine and Tom Lane
* pg_dump: Improve message formattingPeter Eisentraut2013-04-27
|
* Incidental cleanup of matviews code.Tom Lane2013-04-27
| | | | | | | | | | | | | | | | | Move checking for unscannable matviews into ExecOpenScanRelation, which is a better place for it first because the open relation is already available (saving a relcache lookup cycle), and second because this eliminates the problem of telling the difference between rangetable entries that will or will not be scanned by the query. In particular we can get rid of the not-terribly-well-thought-out-or-implemented isResultRel field that the initial matviews patch added to RangeTblEntry. Also get rid of entirely unnecessary scannability check in the rewriter, and a bogus decision about whether RefreshMatViewStmt requires a parse-time snapshot. catversion bump due to removal of a RangeTblEntry field, which changes stored rules.
* Improve message about failed transaction log archivingPeter Eisentraut2013-04-26
| | | | | The old phrasing appeared to imply that the failure was terminal. Improve that by indicating that archiving will be tried again later.
* Update config.guess and config.subPeter Eisentraut2013-04-26
|
* Fix collation assignment for aggregates with ORDER BY.Tom Lane2013-04-26
| | | | | | | | | | | | | | | | | | | | | | ORDER BY expressions were being treated the same as regular aggregate arguments for purposes of collation determination, but really they should not affect the aggregate's collation at all; only collations of the aggregate's regular arguments should affect it. In many cases this mistake would lead to incorrectly throwing a "collation conflict" error; but in some cases the corrected code will silently assign a different collation to the aggregate than before, for example agg(foo ORDER BY bar COLLATE "x") which will now use foo's collation rather than "x" for the aggregate. Given this risk and the lack of field complaints about the issue, it doesn't seem prudent to back-patch. In passing, rearrange code in assign_collations_walker so that we don't need multiple copies of the standard logic for computing collation of a node with children. (Previously, CaseExpr duplicated the standard logic, and we would have needed a third copy for Aggref without this change.) Andrew Gierth and David Fetter
* Ensure that user created rows in extension tables get dumped if the table is ↵Joe Conway2013-04-26
| | | | | | explicitly requested, either with a -t/--table switch of the table itself, or by -n/--schema switch of the schema containing the extension table. Patch reviewed by Vibhor Kumar and Dimitri Fontaine. Backpatched to 9.1 when the extension management facility was added.
* libpq: Fix a few bits that didn't get the memo about COPY BOTH.Robert Haas2013-04-26
| | | | | | | | There's probably no real bug here at present, so not backpatching. But it seems good to make these bits consistent with the rest of libpq, so as to avoid future surprises. Patch by me. Review by Tom Lane.
* Avoid deadlock between concurrent CREATE INDEX CONCURRENTLY commands.Tom Lane2013-04-25
| | | | | | | | | There was a high probability of two or more concurrent C.I.C. commands deadlocking just before completion, because each would wait for the others to release their reference snapshots. Fix by releasing the snapshot before waiting for other snapshots to go away. Per report from Paul Hinze. Back-patch to all active branches.
* Fix typo in comment.Heikki Linnakangas2013-04-25
| | | | Peter Geoghegan
* pg_basebackup: Add missing newlines at end of linesPeter Eisentraut2013-04-24
|
* initdb: Improve some messagesPeter Eisentraut2013-04-24
|
* PL/pgSQL doc: Add example for RETURN QUERYPeter Eisentraut2013-04-24
| | | | Erwin Brandstetter and Pavel Stěhule
* Add missing #include.Heikki Linnakangas2013-04-24
| | | | | | | | | On non-Windows systems, sys/time.h was pulled in by portability/instr_time.h, which pulled in time.h. We certainly should include time.h directly, since we're using time(2), but the indirect include masked the problem on most platforms. Andres Freund
* Fix assertion failure for REFRESH MATERIALIZED VIEW in PL.Kevin Grittner2013-04-24
| | | | | | | | | | | This was due to incomplete implementation of rowcount reporting for RMV, which was due to initial waffling on whether it should be provided. It seems unlikely to be a useful or universally available number as more sophisticated techniques for maintaining matviews are added, so remove the partial support rather than completing it. Per report of Jeevan Chalke, but with a different fix
* Make fast promotion the default promotion mode.Simon Riggs2013-04-24
| | | | | Continue to allow a request for synchronous checkpoints as a mechanism in case of problems.
* 9.3 release notes: adjustments per AlvaroBruce Momjian2013-04-23
|
* 9.3 release note updates from Dean Rasheed, Jov, Heikki Linnakangas,Bruce Momjian2013-04-23
| | | | Erikjan Rijkers
* Remove prototype for cube(text) function that doesn't exist anymore.Heikki Linnakangas2013-04-23
| | | | Adrian Schreyer
* 9.3 release notes: add diacriticsBruce Momjian2013-04-22
| | | | Alvaro Herrera
* 9.3 release notes: adjustments per Alvaro and RobertBruce Momjian2013-04-22
|
* Mention in docs that you can create SP-GiST indexes on range types.Heikki Linnakangas2013-04-22
| | | | This is new in 9.3devel.
* 9.3 release notes: apply fixes suggested by AlvaroBruce Momjian2013-04-22
|
* 9.3 release notes: update streaming replication speedupsBruce Momjian2013-04-22
| | | | Andres Freund
* doc: Improve example formattingPeter Eisentraut2013-04-21
| | | | Erwin Brandstetter
* doc: Fix syntax in examplePeter Eisentraut2013-04-21
| | | | | | | LANGUAGE 'plpgsql' no longer works. The single quotes need to be removed. Erwin Brandstetter
* In 9.3 release notes, split up itemsBruce Momjian2013-04-21
| | | | | | Split log shipping speed improvement and fail-over speed improvement items. Per request from Simon
* 9.3 release note adjustments per request from Andres FreundBruce Momjian2013-04-21
|
* Remove 9.3 item about fixing DROP INDEX CONCURRENTLYBruce Momjian2013-04-21
| | | | Already fixed in back branch.
* 9.3 release note fixesBruce Momjian2013-04-21
| | | | | Move commit_delay, fix Zoltan's name, and adjust range type histogram text.
* Adjust 9.3 release notes per request from SimonBruce Momjian2013-04-21
|
* Reorder 9.3 release note itemsBruce Momjian2013-04-21
| | | | Typo fix from David Fetter.
* More 9.3 release note reorderingsBruce Momjian2013-04-20
|
* Fix Gilles Darold's name in 9.3 release notes.Bruce Momjian2013-04-20
|
* Fix longstanding race condition in plancache.c.Tom Lane2013-04-20
| | | | | | | | | | | | | | | | | | | When creating or manipulating a cached plan for a transaction control command (particularly ROLLBACK), we must not perform any catalog accesses, since we might be in an aborted transaction. However, plancache.c busily saved or examined the search_path for every cached plan. If we were unlucky enough to do this at a moment where the path's expansion into schema OIDs wasn't already cached, we'd do some catalog accesses; and with some more bad luck such as an ill-timed signal arrival, that could lead to crashes or Assert failures, as exhibited in bug #8095 from Nachiket Vaidya. Fortunately, there's no real need to consider the search path for such commands, so we can just skip the relevant steps when the subject statement is a TransactionStmt. This is somewhat related to bug #5269, though the failure happens during initial cached-plan creation rather than revalidation. This bug has been there since the plan cache was invented, so back-patch to all supported branches.
* Reorder some 9.3 release item entriesBruce Momjian2013-04-20
| | | | More to go.
* Push 9.3 release SGML fileBruce Momjian2013-04-20
| | | | Forgotten in previous commit.
* Publish draft 9.3 release notesBruce Momjian2013-04-20
| | | | No links added yet.
* doc: Mention SATA alongside IDE for LinuxPeter Eisentraut2013-04-20
| | | | suggested by Jov
* Clean up references to SQL92Peter Eisentraut2013-04-20
| | | | | | In most cases, these were just references to the SQL standard in general. In a few cases, a contrast was made between SQL92 and later standards -- those have been kept unchanged.
* Improve error message when an FDW doesn't support WHERE CURRENT OF.Tom Lane2013-04-19
| | | | | | | If an FDW fails to take special measures with a CurrentOfExpr, we will end up trying to execute it as an ordinary qual, which was being treated as a purely internal failure condition. Provide a more user-oriented error message for such cases.
* Don't try to pass -I switch to postmaster in contrib/start-scripts/linux.Tom Lane2013-04-19
| | | | | Undo thinko in commit 87306184580c9c49717b00d48a2f9e717f21e0a8. Per bug #8098 from Catherine Devlin.
* Fix typo in comment.Robert Haas2013-04-19
| | | | Fabrízio de Royes Mello
* Standardize spelling of "nonblocking"Peter Eisentraut2013-04-18
| | | | | Only adjusted the user-exposed messages and documentation, not all source code comments.
* pg_upgrade: Add checksum C commentBruce Momjian2013-04-17
| | | | We might eventually allow checksum to no-checksum upgrades.
* sepgsql: Minor improvement to test script, doc fix.Robert Haas2013-04-17
| | | | KaiGai Kohei
* sepgsql: One more getObjectIdentity in lieu of getObjectDescription.Robert Haas2013-04-17
| | | | KaiGai Kohei, based on a suggestion from Álvaro Herrera
* doc: Update PQgetssl() documentationPeter Eisentraut2013-04-16
| | | | | The return type of PQgetssl() was changed from SSL* to void* a long time ago, but the documentation was not updated.
* pgindent: add newline to die() so script line number is not reported on ↵Bruce Momjian2013-04-16
| | | | failure.
* Remove some unused and seldom used fields from RelationAmInfo.Heikki Linnakangas2013-04-16
| | | | | | | This saves some memory from each index relcache entry. At least on a 64-bit machine, it saves just enough to shrink a typical relcache entry's memory usage from 2k to 1k. That's nice if you have a lot of backends and a lot of indexes.