aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Fix race condition in CheckTargetForConflictsIn.Robert Haas2011-05-19
| | | | Dan Ports
* Fix declaration of $_TD in "strict" trigger functionsAlvaro Herrera2011-05-18
| | | | | | | | | | | | | | | | | | | | This was broken in commit ef19dc6d39dd2490ff61489da55d95d6941140bf by the Bunce/Hunsaker/Dunstan team, which moved the declaration from plperl_create_sub to plperl_call_perl_trigger_func. This doesn't actually work because the validator code would not find the variable declared; and even if you manage to get past the validator, it still doesn't work because get_sv("_TD", GV_ADD) doesn't have the expected effect. The only reason this got beyond testing is that it only fails in strict mode. We need to declare it as a global just like %_SHARED; it is simpler than trying to actually do what the patch initially intended, and is said to have the same performance benefit. As a more serious issue, fix $_TD not being properly local()ized, meaning nested trigger functions would clobber $_TD. Alex Hunsaker, per test report from Greg Mullane
* Replace strdup() with pstrdup(), to avoid leaking memory.Heikki Linnakangas2011-05-18
| | | | | It's been like this since the seg module was introduced, so backpatch to 8.2 which is the oldest supported version.
* In pg_upgrade, clean up handling of invalid directory specification byBruce Momjian2011-05-18
| | | | checking the stat() errno value more strictly.
* Improve pg_upgrade error reporting if the bin or data directories do notBruce Momjian2011-05-18
| | | | exist or are not directories.
* Remove obsolete commentPeter Eisentraut2011-05-19
|
* Spell checking and markup refinementPeter Eisentraut2011-05-19
|
* /contrib/foo -> contrib/fooPeter Eisentraut2011-05-19
| | | | | Since contrib is a relative directory specification, a leading slash is inappropriate.
* Improve pg_upgrade X_OK comment.Bruce Momjian2011-05-18
|
* Fix pg_upgrade build problem on Windows when using X_OK accessBruce Momjian2011-05-18
| | | | permission check on the current directory.
* Fix pg_dump's handling of extension-member casts and languages.Tom Lane2011-05-16
| | | | | | | | | | pg_dump has some heuristic rules for whether to dump casts and procedural languages, since it's not all that easy to distinguish built-in ones from user-defined ones. However, we should not apply those rules to objects that belong to an extension, but just use the perfectly well-defined rules for what to do with extension member objects. Otherwise we might mistakenly lose extension member objects during a binary upgrade (which is the only time that we'd want to dump extension members).
* Update pg_upgrade directory check error message.Bruce Momjian2011-05-16
|
* Remove redundant privilege doc sentences.Bruce Momjian2011-05-16
|
* Add pg_upgrade check to make sure the user has full access permission inBruce Momjian2011-05-16
| | | | the current directory; if not, throw an error.
* Allow pg_upgrade to honor libpq environment variables. Add 'local'Bruce Momjian2011-05-16
| | | | checks for PGHOST and PGHOSTADDR.
* Quote isolationtester command name so Windows will not think dot is the command.Andrew Dunstan2011-05-15
|
* Add required psqldir setting for isolation checks.Andrew Dunstan2011-05-15
|
* Fix bad macro call noticed by MSVC compiler.Andrew Dunstan2011-05-15
|
* Add missing check function lookup.Andrew Dunstan2011-05-15
|
* Build and run isolation test programs under MSVC.Andrew Dunstan2011-05-15
|
* More cleanup of FOREIGN TABLE permissions handling.Robert Haas2011-05-13
| | | | | | | | | This commit fixes psql, pg_dump, and the information schema to be consistent with the backend changes which I made as part of commit be90032e0d1cf473bdd99aee94218218f59f29f1, and also includes a related documentation tweak. Shigeru Hanada, with slight adjustment.
* Kill stray "not".Robert Haas2011-05-12
|
* Fix write-past-buffer-end in ldapServiceLookup().Tom Lane2011-05-12
| | | | | | | | | | | | The code to assemble ldap_get_values_len's output into a single string wrote the terminating null one byte past where it should. Fix that, and make some other cosmetic adjustments to make the code a trifle more readable and more in line with usual Postgres coding style. Also, free the "result" string when done with it, to avoid a permanent memory leak. Bug report and patch by Albe Laurenz, cosmetic adjustments by me.
* Fix assorted typosAlvaro Herrera2011-05-12
|
* Split PGC_S_DEFAULT into two values, for true boot_val vs computed default.Tom Lane2011-05-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Failure to distinguish these cases is the real cause behind the recent reports of Windows builds crashing on 'infinity'::timestamp, which was directly due to failure to establish a value of timezone_abbreviations in postmaster child processes. The postmaster had the desired value, but write_one_nondefault_variable() didn't transmit it to backends. To fix that, invent a new value PGC_S_DYNAMIC_DEFAULT, and be sure to use that or PGC_S_ENV_VAR (as appropriate) for "default" settings that are computed during initialization. (We need both because there's at least one variable that could receive a value from either source.) This commit also fixes ProcessConfigFile's failure to restore the correct default value for certain GUC variables if they are set in postgresql.conf and then removed/commented out of the file. We have to recompute and reinstall the value for any GUC variable that could have received a value from PGC_S_DYNAMIC_DEFAULT or PGC_S_ENV_VAR sources, and there were a number of oversights. (That whole thing is a crock that needs to be redesigned, but not today.) However, I intentionally didn't make it work "exactly right" for the cases of timezone and log_timezone. The exactly right behavior would involve running select_default_timezone, which we'd have to do independently in each postgres process, causing the whole database to become entirely unresponsive for as much as several seconds. That didn't seem like a good idea, especially since the variable's removal from postgresql.conf might be just an accidental edit. Instead the behavior is to adopt the previously active setting as if it were default. Note that this patch creates an ABI break for extensions that use any of the PGC_S_XXX constants; they'll need to be recompiled.
* Clean up parsing of CREATE TRIGGER's argument list.Tom Lane2011-05-11
| | | | | | | | | | | | | Use ColLabel in place of ColId, so that reserved words are accepted as if they were not reserved. Also, remove BCONST and XCONST, which were never documented as allowed. Allowing those exposes to users an implementation detail, namely the format in which the lexer outputs such constants, that seems unwise to expose. No documentation change needed, since this just makes the code act more like you'd expect from reading the CREATE TRIGGER man page. Per complaint from Szymon Guz and subsequent discussion.
* Shut down WAL receiver if it's still running at end of recovery. We used toHeikki Linnakangas2011-05-11
| | | | | just check that it's not running and PANIC if it was, but that can rightfully happen if recovery stops at recovery target.
* Be more explicit about the meaning of the change in standard_conforming_strings.Tom Lane2011-05-10
|
* Mention "backslash" escape processing change in 9.1 release notes.Bruce Momjian2011-05-10
|
* Prevent datebsearch() from crashing on base == NULL && nel == 0.Tom Lane2011-05-10
| | | | | | | | | | | | | | | | | | | | Normally nel == 0 works okay because the initial value of "last" will be less than "base"; but if "base" is zero then the calculation wraps around and we have a very large (unsigned) value for "last", so that the loop can be entered and we get a SIGSEGV on a bogus pointer. This is certainly the proximate cause of the recent reports of Windows builds crashing on 'infinity'::timestamp --- evidently, they're either not setting an active timezonetktbl, or setting an empty one. It's not yet clear to me why it's only happening on Windows and not happening on any buildfarm member. But even if that's due to some bug elsewhere, it seems wise for this function to not choke on the powerup values of timezonetktbl/sztimezonetktbl. I also changed the copy of this code in ecpglib, although I am not sure whether it's exposed to a similar hazard. Per report and stack trace from Richard Broersma.
* For create/dropdb, only connect once to the server since we now have aBruce Momjian2011-05-10
| | | | | | shared description table for pg_database comments. Also update comments about database name selection.
* Add some punctuationPeter Eisentraut2011-05-10
|
* Put options in more alphabetical orderPeter Eisentraut2011-05-10
|
* Put options help in alphabetical orderPeter Eisentraut2011-05-10
|
* Format pg_upgrade --version in line with conventionsPeter Eisentraut2011-05-10
|
* Add bug report line to pg_upgrade --help outputPeter Eisentraut2011-05-10
|
* Put pg_test_fsync --help and --version output in line with conventionsPeter Eisentraut2011-05-10
| | | | Foremost, it should go to stdout.
* Adjust documentation with respect to "unknown" timezone setting.Tom Lane2011-05-10
| | | | | | The recent cleanup of GUC assign hooks got rid of the kludge of using "unknown" as a magic value for timezone and log_timezone. But I forgot to update the documentation to match, as noted by Martin Pitt.
* Be more wary in initdb's creation of platform-dependent collations.Tom Lane2011-05-10
| | | | | | | | | | | Discard any collation aliases that match the built-in pg_collation entries (ie, "default", "C", "POSIX"). Such aliases would be refused by a CREATE COLLATION command, but since initdb is injecting them via a simple INSERT, it has to make the corresponding check for itself. Per Martin Pitt's report of funny behavior in a machine that had a bogus "C.UTF-8" locale. Also, use E'' syntax for the output of escape_quotes, as per its header comment.
* In pg_upgrade, remove suggestion of setting pg_hba.conf to 'trust', nowBruce Momjian2011-05-10
| | | | | that we report the libpq connection failure string. Per suggestion from Robert Haas.
* Documentation cleanup for the possible values of the datatype 'boolean'.Bruce Momjian2011-05-09
|
* Update documentation to state there is three-value logic, notBruce Momjian2011-05-09
| | | | | | | three-value boolean logic. Backpatch to 9.0.X since we just got another bug report about this today.
* Remove "make check" target in src/test/isolation/Makefile.Tom Lane2011-05-09
| | | | | | | | | | This doesn't work as expected because the isolationtester program requires libpq to already be installed. While it works when you've already installed libpq, having to already have done "make install" defeats most of the point of a check with a temp installation. And there are weird corner cases if the dynamic linker picks up an old libpq.so from system library directories. Remove the target (or more precisely, make it print a helpful message) so people don't expect the case to work.
* In pg_upgrade, add status message about superuser check.Bruce Momjian2011-05-09
|
* Add C comment about the fact that the autovacuum limit can go backwardsBruce Momjian2011-05-08
| | | | by 3, but that is it OK.
* Fix some portability issues in isolation regression test driver.Tom Lane2011-05-08
| | | | | | | | | | Remove random system #includes in favor of using postgres_fe.h. (The alternative to that is letting this module grow its own configuration testing ability...) Also fix the "make clean" target to actually clean things up. Per local testing.
* Add C comment why client encoding can be set in pg_upgrade.Bruce Momjian2011-05-07
|
* Add xreflabels to /contrib manuals so links appear correct. Also updateBruce Momjian2011-05-07
| | | | README.links to explain xref properly.
* Add missing documention connecting word.Bruce Momjian2011-05-07
|
* In pg_upgrade, report non-super-user username in error message.Bruce Momjian2011-05-07
|
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-04 16:18:04 +0000