aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Modify error context callback functions to not assume that they can fetchTom Lane2010-03-19
| | | | | | | | | | | | | | | | | | catalog entries via SearchSysCache and related operations. Although, at the time that these callbacks are called by elog.c, we have not officially aborted the current transaction, it still seems rather risky to initiate any new catalog fetches. In all these cases the needed information is readily available in the caller and so it's just a matter of a bit of extra notation to pass it to the callback. Per crash report from Dennis Koegel. I've concluded that the real fix for his problem is to clear the error context stack at entry to proc_exit, but it still seems like a good idea to make the callbacks a bit less fragile for other cases. Backpatch to 8.4. We could go further back, but the patch doesn't apply cleanly. In the absence of proof that this fixes something and isn't just paranoia, I'm not going to expend the effort.
* Fix oversight in btpo.xact patch; it was in fact installing garbageTom Lane2010-03-19
| | | | | in the xact field on replay, due to not writing out all the data in the wal log struct.
* Clarify docs about database parameter in streaming replication primary_conninfo.Simon Riggs2010-03-19
| | | | | | Docs were unclear on whether or not database=replication was required, nor did they mention the FATAL error this causes if database parameter is mentioned explicitly, whatever its value.
* Add connection messages for streaming replication. log_connectionsSimon Riggs2010-03-19
| | | | | | | was broken for a replication connection and no messages were displayed on either standby or primary, at any debug level. Connection messages needed to diagnose session drop/reconnect events. Use LOG mode for now, discuss lowering in later releases.
* Minor tweaks on libpqrcv_connect(): ensure conninfo_repl[] isSimon Riggs2010-03-19
| | | | | correctly sized and expand comment to explain otherwise undocumented use of replication connection parameter.
* Update XLOG_PAGE_MAGIC to recognise WAL format changes.Simon Riggs2010-03-19
|
* Adjust comment in .history file to match recovery target specified. CommentSimon Riggs2010-03-19
| | | | | | | | present since 8.0 was never fully meaningful, since two recovery targets cannot be specified. Refactor recovery target type to make this change and associated code easier to understand. No change in function. Bug report arising from internal support question.
* Reset btpo.xact following recovery of btree delete page. Add btpo_xactSimon Riggs2010-03-19
| | | | | | | field into WAL record and reset it from there, rather than using FrozenTransactionId which can lead to some corner case bugs. Problem report and suggested route to a fix from Heikki, details by me.
* Also print the libpq error message when lo_create or lo_open failsPeter Eisentraut2010-03-18
|
* Prevent the injection of invalidly encoded strings by PL/Python into PostgreSQLPeter Eisentraut2010-03-18
| | | | with a few strategically placed pg_verifymbstr calls.
* Message style tuningPeter Eisentraut2010-03-18
|
* Mention way to get commit details for release notes.Bruce Momjian2010-03-18
|
* Fix missing parentheses for current_query(), per bug #5378.Tom Lane2010-03-18
| | | | Also make a couple other minor editorial improvements.
* Use data-type specific conversion functions also in plpy.executePeter Eisentraut2010-03-18
| | | | | | | | | | In PLy_spi_execute_plan, use the data-type specific Python-to-PostgreSQL conversion function instead of passing everything through InputFunctionCall as a string. The equivalent fix was already done months ago for function parameters and return values, but this other gateway between Python and PostgreSQL was apparently forgotten. As a result, data types that need special treatment, such as bytea, would misbehave when used with plpy.execute.
* Add restartpoint_command option to recovery.conf. Fix bug in %r handlingHeikki Linnakangas2010-03-18
| | | | | | | | | in recovery_end_command, it always came out as 0 because InRedo was cleared before recovery_end_command was executed. Also, always take ControlFileLock when reading checkpoint location for %r. The recovery_end_command bug and the missing locking was present in 8.4 as well, that part of this patch will be backported separately.
* Add vacuum_defer_cleanup_age to postgresql.conf.sample.Simon Riggs2010-03-18
|
* Don't link PL/Python against LOCALMODLIBSPeter Eisentraut2010-03-17
| | | | | | This variable is apparently only for Python internally. In newer releases of Python this variable pulls in more and more libraries that users are less likely to have, leading to potential build failures.
* Message style tuningPeter Eisentraut2010-03-17
|
* Fix peculiar, untranslatable message concatenation attemptPeter Eisentraut2010-03-17
|
* Make typography consistentPeter Eisentraut2010-03-17
|
* Typo fixes.Magnus Hagander2010-03-17
| | | | Fujii Masao
* Update broken and permanently moved linksPeter Eisentraut2010-03-17
|
* Pass incompletely-transformed aggregate argument lists as separate parametersTom Lane2010-03-17
| | | | | | to transformAggregateCall, instead of abusing fields in Aggref to carry them temporarily. No change in functionality but hopefully the code is a bit clearer now. Per gripe from Gokulakannan Somasundaram.
* Fix incorrect example in CREATE INDEX reference page, per Josh Kupershmidt.Tom Lane2010-03-17
| | | | | Also fix and uncomment an old example of creating a GIST index, and make a couple of other minor editorial adjustments.
* Fix typo in streaming replication protocol docs.Simon Riggs2010-03-17
|
* Fix typo in math function docs, spotted by Heikki.Simon Riggs2010-03-16
|
* Throw a nicer error message if a standby server attempts to connect whileHeikki Linnakangas2010-03-16
| | | | | | the master is still in recovery. We don't support cascading slaves yet. Patch by Fujii Masao, with slightly changed wording.
* Document that trig functions accept/return values in radians.Simon Riggs2010-03-15
|
* Remove incorrect comment from GetWriteRecPtr(): the return value is alwaysSimon Riggs2010-03-15
| | | | correct, as described in comments at start of xlog.c
* Update oidjoins regression test for 9.0.Tom Lane2010-03-14
|
* Add some more structure and bits of information to PL/Python documentationPeter Eisentraut2010-03-13
|
* Revert all keepalive moves, reevaluate.Bruce Momjian2010-03-13
|
* Move more tcp keepalive macros to be consistent.Bruce Momjian2010-03-13
|
* Move TCP keepalive macro definitionBruce Momjian2010-03-13
| | | | Jaime Casanova
* Add libpq warning message if the .pgpass-retrieved password fails.Bruce Momjian2010-03-13
| | | | Add ERRCODE_INVALID_PASSWORD sqlstate error code.
* Update shared memory configuration information for LinuxPeter Eisentraut2010-03-13
| | | | | In particular, the assertion that shmall is sufficiently sized by default is slowly becoming untrue.
* Document what user name email symbols are supported by tsearch.Bruce Momjian2010-03-13
|
* Allow underscores in tsearch email addressses, per RFC 5322 and reportBruce Momjian2010-03-13
| | | | | | by Dan O'Hara. Patch by Teodor Sigaev
* Small adjustment by pgindent.Bruce Momjian2010-03-13
|
* Re-add comma, oops.Bruce Momjian2010-03-12
|
* Add some logging code for unexpected cases in pgstat.c, particularly beingTom Lane2010-03-12
| | | | | | | | | | unable to read a stats file for reasons other than ENOENT, and having to reset last_statrequest because it's later than current time in the collector. Not clear if this will shed any light on the "pgstat wait timeout" business, but it seems like a good idea in general. In passing, do some message-style-police work on recently-added pgstat_reset_shared_counters code.
* Fix a commented-out block of code that pgindent didn't understandTom Lane2010-03-12
| | | | properly; it's been making that comment uglier with each run.
* Remove unnecessary comma in documentation.Bruce Momjian2010-03-12
|
* Add missing reset of need_initialization in reloptions code.Tom Lane2010-03-11
| | | | | This resulted in useless extra work during every call of parseRelOptions, but no bad effects other than that. Noted by Alvaro.
* Modify psql's \d printout to fold exclusion constraints in with regularTom Lane2010-03-11
| | | | | indexes, rather than printing them twice. Per my gripe when the exclusion constraint feature was committed.
* Sync timezone code with tzcode 2010c from the Olson group. This fixes someTom Lane2010-03-11
| | | | | | | | | | corner cases that come up in certain timezones (apparently, only those with lots and lots of distinct TZ transition rules, as far as I can gather from a quick scan of their archives). Per suggestion from Jeevan Chalke. Back-patch to 8.4. Possibly we need to push this into earlier releases as well, but I'm hesitant to update them to the 64-bit tzcode without more thought and testing.
* Fix bug in KnownAssignedXidsMany(). I saw this when looking at theHeikki Linnakangas2010-03-11
| | | | | assertion failure reported by Erik Rijkers, but this alone doesn't explain the failure.
* Fix comment which was apparently copy-pasted from another function.Heikki Linnakangas2010-03-11
|
* Simplify a couple of pg_dump and psql \d queries about index constraintsTom Lane2010-03-11
| | | | | | | | | by joining to pg_constraint.conindid, instead of the former technique of joining indirectly through pg_depend. This is much more straightforward and probably faster as well. I had originally desisted from changing these queries when conindid was added because I was worried about losing performance, but if we join on conrelid as well as conindid then the index on conrelid can be used when pg_constraint is large.
* Update comment for pg_constraint.conindid to mention that it's used forTom Lane2010-03-11
| | | | | exclusion constraints. Not sure how we managed to update the comment for it in catalogs.sgml but miss this one.