aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Fix incorrect comment about XLogRecordBlockHeader.data_length field.Heikki Linnakangas2014-12-16
| | | | | | | It does not include the possible full-page image. While at it, reformat the comment slightly to make it more readable. Reported by Rahila Syed
* Fix commit_ts test suite for systems with coarse timestamp granularity.Noah Misch2014-12-15
| | | | | | Noticed on a couple of Windows configurations. Petr Jelinek, reviewed by Michael Paquier.
* Translation updatesPeter Eisentraut2014-12-15
|
* add missing newlineAlvaro Herrera2014-12-15
|
* Fix point <-> polygon code for zero-distance case.Tom Lane2014-12-15
| | | | | "PG_RETURN_FLOAT8(x)" is not "return x", except perhaps by accident on some platforms.
* Add point <-> polygon distance operator.Heikki Linnakangas2014-12-15
| | | | Alexander Korotkov, reviewed by Emre Hasegeli.
* Translation updatesPeter Eisentraut2014-12-15
|
* doc: Add link to how to specify time zone names to initdb man pagePeter Eisentraut2014-12-14
|
* Improve documentation around parameter-setting and ALTER SYSTEM.Tom Lane2014-12-14
| | | | | | | | The ALTER SYSTEM ref page hadn't been held to a very high standard, nor was the feature well integrated into section 18.1 (parameter setting). Also, though commit 4c4654afe had improved the structure of 18.1, it also introduced a lot of poor wording, imprecision, and outright falsehoods. Try to clean that up.
* Update 9.4 release notes.Tom Lane2014-12-14
| | | | | Set release date, do a final pass of wordsmithing, improve some other new-in-9.4 documentation.
* doc: Fix markupPeter Eisentraut2014-12-13
|
* Add CINE option for CREATE TABLE AS and CREATE MATERIALIZED VIEWAndrew Dunstan2014-12-13
| | | | Fabrízio de Royes Mello reviewed by Rushabh Lathia.
* Improve recovery target settings documentation.Tom Lane2014-12-13
| | | | | | Commit 815d71dee hadn't bothered to update the documentation to match the behavioral change, and a lot of other text in this section was badly in need of copy-editing.
* Repair corner-case bug in array version of percentile_cont().Tom Lane2014-12-13
| | | | | | | | The code for advancing through the input rows overlooked the case that we might already be past the first row of the row pair now being considered, in case the previous percentile also fell between the same two input rows. Report and patch by Andrew Gierth; logic rewritten a bit for clarity by me.
* Remove duplicate #defineHeikki Linnakangas2014-12-13
| | | | Mark Dilger
* Avoid instability in output of new REINDEX SCHEMA test.Tom Lane2014-12-12
| | | | | | | | | | | | | The planner seems to like to do this join query as a hash join, making the output ordering machine-dependent; worse, it's a hash on OIDs, so that it's a bit astonishing that the result doesn't change from run to run even on one machine. Add an ORDER BY to get consistent results. Per buildfarm. I also suppressed output from the final DROP SCHEMA CASCADE, to avoid occasional failures similar to those fixed in commit 81d815dc3ed74a7d. That hasn't been observed in the buildfarm yet, but it seems likely to happen in future if we leave it as-is.
* Add several generator functions for jsonb that exist for json.Andrew Dunstan2014-12-12
| | | | | | | | | | | | | | | | The functions are: to_jsonb() jsonb_object() jsonb_build_object() jsonb_build_array() jsonb_agg() jsonb_object_agg() Also along the way some better logic is implemented in json_categorize_type() to match that in the newly implemented jsonb_categorize_type(). Andrew Dunstan, reviewed by Pavel Stehule and Alvaro Herrera.
* Revert misguided change to postgres_fdw FOR UPDATE/SHARE code.Tom Lane2014-12-12
| | | | | | | | | | | | | | | In commit 462bd95705a0c23ba0b0ba60a78d32566a0384c1, I changed postgres_fdw to rely on get_plan_rowmark() instead of get_parse_rowmark(). I still think that's a good idea in the long run, but as Etsuro Fujita pointed out, it doesn't work today because planner.c forces PlanRowMarks to have markType = ROW_MARK_COPY for all foreign tables. There's no urgent reason to change this in the back branches, so let's just revert that part of yesterday's commit rather than trying to design a better solution under time pressure. Also, add a regression test case showing what postgres_fdw does with FOR UPDATE/SHARE. I'd blithely assumed there was one already, else I'd have realized yesterday that this code didn't work.
* Add json_strip_nulls and jsonb_strip_nulls functions.Andrew Dunstan2014-12-12
| | | | | | | | The functions remove object fields, including in nested objects, that have null as a value. In certain cases this can lead to considerably smaller datums, with no loss of semantic information. Andrew Dunstan, reviewed by Pavel Stehule.
* Put the logic to decide which synchronous standby is active into a function.Heikki Linnakangas2014-12-12
| | | | | | This avoids duplicating the code. Michael Paquier, reviewed by Simon Riggs and me
* doc: Move website-stylesheet setting to a more appropriate locationPeter Eisentraut2014-12-11
|
* SSL tests: Remove trailing blank linesPeter Eisentraut2014-12-11
|
* SSL tests: Silence pg_ctl outputPeter Eisentraut2014-12-11
| | | | | Otherwise the pg_ctl start and stop messages get mixed up with the TAP output, which isn't technically valid.
* Fix planning of SELECT FOR UPDATE on child table with partial index.Tom Lane2014-12-11
| | | | | | | | | | | | | | | | | | | Ordinarily we can omit checking of a WHERE condition that matches a partial index's condition, when we are using an indexscan on that partial index. However, in SELECT FOR UPDATE we must include the "redundant" filter condition in the plan so that it gets checked properly in an EvalPlanQual recheck. The planner got this mostly right, but improperly omitted the filter condition if the index in question was on an inheritance child table. In READ COMMITTED mode, this could result in incorrectly returning just-updated rows that no longer satisfy the filter condition. The cause of the error is using get_parse_rowmark() when get_plan_rowmark() is what should be used during planning. In 9.3 and up, also fix the same mistake in contrib/postgres_fdw. It's currently harmless there (for lack of inheritance support) but wrong is wrong, and the incorrect code might get copied to someplace where it's more significant. Report and fix by Kyotaro Horiguchi. Back-patch to all supported branches.
* Fix corner case where SELECT FOR UPDATE could return a row twice.Tom Lane2014-12-11
| | | | | | | | | | | | | | | | In READ COMMITTED mode, if a SELECT FOR UPDATE discovers it has to redo WHERE-clause checking on rows that have been updated since the SELECT's snapshot, it invokes EvalPlanQual processing to do that. If this first occurs within a non-first child table of an inheritance tree, the previous coding could accidentally re-return a matching row from an earlier, already-scanned child table. (And, to add insult to injury, I think this could make it miss returning a row that should have been returned, if the updated row that this happens on should still have passed the WHERE qual.) Per report from Kyotaro Horiguchi; the added isolation test is based on his test case. This has been broken for quite awhile, so back-patch to all supported branches.
* Further changes to REINDEX SCHEMASimon Riggs2014-12-11
| | | | | | | | | | Ensure we reindex indexes built on Mat Views. Based on patch from Micheal Paquier Add thorough tests to check that indexes on tables, toast tables and mat views are reindexed. Simon Riggs
* Make rowsecurity test clean up after itself, too.Tom Lane2014-12-11
| | | | Leaving global objects like roles hanging around is bad practice.
* Fix completely broken REINDEX SCHEMA testcase.Tom Lane2014-12-11
| | | | | | | Aside from not testing the case it claimed to test (namely a permissions failure), it left a login-capable role lying around, which quite aside from possibly being a security hole would cause subsequent regression runs to fail since the role would already exist.
* Fix assorted confusion between Oid and int32.Tom Lane2014-12-11
| | | | | | | | | | | In passing, also make some debugging elog's in pgstat.c a bit more consistently worded. Back-patch as far as applicable (9.3 or 9.4; none of these mistakes are really old). Mark Dilger identified and patched the type violations; the message rewordings are mine.
* Use correct macro for reltablespace.Heikki Linnakangas2014-12-11
| | | | | | | It's an OID. WRITE_UINT_FIELD is identical to WRITE_OID_FIELD, but let's be tidy. Mark Dilger
* Fix typoPeter Eisentraut2014-12-10
| | | | Author: Fabrízio de Royes Mello <fabriziomello@gmail.com>
* Fix minor thinko in convertToJsonb().Tom Lane2014-12-10
| | | | | | | | | | The amount of space to reserve for the value's varlena header is VARHDRSZ, not sizeof(VARHDRSZ). The latter coding accidentally failed to fail because of the way the VARHDRSZ macro is currently defined; but if we ever change it to return size_t (as one might reasonably expect it to do), convertToJsonb() would have failed. Spotted by Mark Dilger.
* Add a regression test suite for SSL support.Heikki Linnakangas2014-12-09
| | | | | | It's not run by the global "check" or "installcheck" targets, because the temporary installation it creates accepts TCP connections from any user the same host, which is insecure.
* pg_xlogdump/.gitignore: add committsdesc.cAlvaro Herrera2014-12-09
| | | | Author: Michael Paquier
* Silence REINDEXSimon Riggs2014-12-09
| | | | | | | Previously REINDEX DATABASE and REINDEX SCHEMA produced a stream of NOTICE messages. Removing that since it is inconsistent for such a command to produce output without a VERBOSE option.
* Execute 18 tests for src/bin/scripts/t/090..Simon Riggs2014-12-09
| | | | Some requests count as two tests.
* REINDEX SCHEMASimon Riggs2014-12-09
| | | | | | | | Add new SCHEMA option to REINDEX and reindexdb. Sawada Masahiko Reviewed by Michael Paquier and Fabrízio de Royes Mello
* Windows: use GetSystemTimePreciseAsFileTime if availableSimon Riggs2014-12-08
| | | | | | | | | | | | | | PostgreSQL on Windows 8 or Windows Server 2012 will now get high-resolution timestamps by dynamically loading the GetSystemTimePreciseAsFileTime function. It'll fall back to to GetSystemTimeAsFileTime if the higher precision variant isn't found, so the same binaries without problems on older Windows releases. No attempt is made to detect the Windows version. Only the presence or absence of the desired function is considered. Craig Ringer
* Use GetSystemTimeAsFileTime directly in win32Simon Riggs2014-12-08
| | | | | | | | | | | | | | | | | | | | | | | | PostgreSQL was calling GetSystemTime followed by SystemTimeToFileTime in the win32 port gettimeofday function. This is not necessary and limits the reported precision to the 1ms granularity that the SYSTEMTIME struct can represent. By using GetSystemTimeAsFileTime we avoid unnecessary conversions and capture timestamps at 100ns granularity, which is then rounded to 1µs granularity for storage in a PostgreSQL timestamp. On most Windows systems this change will actually have no significant effect on timestamp resolution as the system timer tick is typically between 1ms and 15ms depending on what timer resolution currently running applications have requested. You can check this with clockres.exe from sysinternals. Despite the platform limiation this change still permits capture of finer timestamps where the system is capable of producing them and it gets rid of an unnecessary syscall. The higher resolution GetSystemTimePreciseAsFileTime call available on Windows 8 and Windows Server 2012 has the same interface as GetSystemTimeAsFileTime, so switching to GetSystemTimeAsFileTime makes it easier to use the Precise variant later. Craig Ringer, reviewed by David Rowley
* doc: Fix DocBook table column count declarationPeter Eisentraut2014-12-08
| | | | This was broken in 618c9430a82860c84a3be2711eec2c3b43573b2a.
* Correct recovery_target_action docsSimon Riggs2014-12-08
| | | | From Michael Paquier
* Remove duplicate code in heap_prune_chain()Simon Riggs2014-12-08
| | | | | | No need to set tuple tableOid twice Jim Nasby
* Event Trigger for table_rewriteSimon Riggs2014-12-08
| | | | | | | | | | | | | | Generate a table_rewrite event when ALTER TABLE attempts to rewrite a table. Provide helper functions to identify table and reason. Intended use case is to help assess or to react to schema changes that might hold exclusive locks for long periods. Dimitri Fontaine, triggering an edit by Simon Riggs Reviewed in detail by Michael Paquier
* Tweaks for recovery_target_actionSimon Riggs2014-12-07
| | | | | | | | | Rename parameter action_at_recovery_target to recovery_target_action suggested by Christoph Berg. Place into recovery.conf suggested by Fujii Masao, replacing (deprecating) earlier parameters, per Michael Paquier.
* Give a proper error message if initdb password file is empty.Heikki Linnakangas2014-12-05
| | | | | | | Used to say just "could not read password from file "...": Success", which isn't very informative. Mats Erik Andersson. Backpatch to all supported versions.
* Don't include file type bits in tar archive's mode field.Heikki Linnakangas2014-12-05
| | | | | | | | | | | | | | | | The "file mode" bits in the tar file header is not supposed to include the file type bits, e.g. S_IFREG or S_IFDIR. The file type is stored in a separate field. This isn't a problem in practice, all tar programs ignore the extra bits, but let's be tidy. This came up in a discussion around bug #11949, reported by Hendrik Grewe, although this doesn't fix the issue with tar --append. That turned out to be a bug in GNU tar. Schilly's tartest program revealed this defect in the tar created by pg_basebackup. This problem goes as far as we we've had pg_basebackup, but since this hasn't caused any problems in practice, let's be conservative and fix in master only.
* Remove erroneous EXTRA_CLEAN line from Makefile.Heikki Linnakangas2014-12-05
| | | | | | After commit da34731, these files are not generated files anymore. Adam Brightwell
* Print new track_commit_timestamp in rm_desc of a parameter-change record.Heikki Linnakangas2014-12-05
| | | | Michael Paquier
* Print wal_log_hints in the rm_desc routing of a parameter-change record.Heikki Linnakangas2014-12-05
| | | | | | | | | It was an oversight in the original commit. Also note in the sample config file that changing wal_log_hints requires a restart. Michael Paquier. Backpatch to 9.4, where wal_log_hints was added.
* Fix pg_xlogdump's calculation of full-page image data.Heikki Linnakangas2014-12-05
| | | | The old formula was completely bogus with the new WAL record format.