aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Tweak the code in a couple of places to try to deliver more user-friendlyTom Lane2007-05-28
| | | | | error messages when a single COPY line is too long for us to handle. Per example from Johann Spies.
* Applied patch send by Joachim Wieland to fix INTEGER_DATETIMES under MSVC.Michael Meskes2007-05-28
|
* Code cleanup: use "bool" for Boolean variables, rather than "int".Neil Conway2007-05-27
|
* Ooops, I was too busy worrying about getting the transactional infrastructureTom Lane2007-05-27
| | | | | right to think carefully about how insert and delete counts map to n_live_tuples. Of course a deletion should reduce n_live_tuples.
* Sorry guys, I committed the file from my development snapshot instead the ↵Michael Meskes2007-05-27
| | | | one from HEAD. Fixing it now.
* The source code changed, so the expected file changed too.Michael Meskes2007-05-27
|
* Applied Joachim's patch for ecpg_config.h creation on Vista.Michael Meskes2007-05-27
| | | | Changed variable test to not run into infinite loops on backend errors.
* pgstat's on-proc-exit hook has to execute after the last transaction commitTom Lane2007-05-27
| | | | | | | or abort within a backend; rearrange InitPostgres processing to make it so. Revealed by just-added Asserts along with ECPG regression tests (hm, I wonder why the core regression tests didn't expose it?). This possibly is another reason for missing stats updates ...
* Fix up pgstats counting of live and dead tuples to recognize that committedTom Lane2007-05-27
| | | | | | | | | | | and aborted transactions have different effects; also teach it not to assume that prepared transactions are always committed. Along the way, simplify the pgstats API by tying counting directly to Relations; I cannot detect any redeeming social value in having stats pointers in HeapScanDesc and IndexScanDesc structures. And fix a few corner cases in which counts might be missed because the relation's pgstat_info pointer hadn't been set.
* Repair two constraint-exclusion corner cases triggered by proving that anTom Lane2007-05-26
| | | | | | | | | | | inheritance child of an UPDATE/DELETE target relation can be excluded by constraints. I had rearranged some code in set_append_rel_pathlist() to avoid "useless" work when a child is excluded, but overdid it and left the child with no cheapest_path entry, causing possible failure later if the appendrel was involved in a join. Also, it seems that the dummy plan generated by inheritance_planner() when all branches are excluded has to be a bit less dummy now than was required in 8.2. Per report from Jan Wieck. Add his test case to the regression tests.
* Create hooks to let a loadable plugin monitor (or even replace) the plannerTom Lane2007-05-25
| | | | | | | | | | | | | | | and/or create plans for hypothetical situations; in particular, investigate plans that would be generated using hypothetical indexes. This is a heavily-rewritten version of the hooks proposed by Gurjeet Singh for his Index Advisor project. In this formulation, the index advisor can be entirely a loadable module instead of requiring a significant part to be in the core backend, and plans can be generated for hypothetical indexes without requiring the creation and rolling-back of system catalog entries. The index advisor patch as-submitted is not compatible with these hooks, but it needs significant work anyway due to other 8.2-to-8.3 planner changes. With these hooks in the core backend, development of the advisor can proceed as a pgfoundry project.
* Remove ruleutils.c's use of varnoold/varoattno as a shortcut for determiningTom Lane2007-05-24
| | | | | | | | | | what a Var node refers to. This is no longer necessary because the new flat-range-table representation of plan trees makes it relatively easy to dig down through child plan levels to find the original reference; and to keep doing it that way, we'd have to store joinaliasvars lists in flattened RTEs, as demonstrated by bug report from Leszek Trenkner. This change makes varnoold/varoattno truly just debug aids, which wasn't quite the case before. Perhaps we should drop them, or only have them in assert-enabled builds?
* Avoid assuming that the fields of struct timeval have exactly type long.Tom Lane2007-05-24
| | | | | This is probably incorrect on some platforms, and definitely draws a compiler warning on Darwin.
* Add deprecation notice about planned removal in 8.4 and advice to try usingPeter Eisentraut2007-05-24
| | | | | | the newer XML stuff in core. (This should probably also be referred to in the release notes.)
* Repair planner bug introduced in 8.2 by ability to rearrange outer joins:Tom Lane2007-05-22
| | | | | | | | | | | | | | | | | | | in cases where a sub-SELECT inserts a WHERE clause between two outer joins, that clause may prevent us from re-ordering the two outer joins. The code was considering only the joins' own ON-conditions in determining reordering safety, which is not good enough. Add a "delay_upper_joins" flag to OuterJoinInfo to flag that we have detected such a clause and higher-level outer joins shouldn't be permitted to commute with this one. (This might seem overly coarse, but given the current rules for OJ reordering, it's sufficient AFAICT.) The failure case is actually pretty narrow: it needs a WHERE clause within the RHS of a left join that checks the RHS of a lower left join, but is not strict for that RHS (else we'd have simplified the lower join to a plain join). Even then no failure will be manifest unless the planner chooses to rearrange the join order. Per bug report from Adam Terrey.
* Remove unsupported -u option from pg_standby example usage.Alvaro Herrera2007-05-22
| | | | From Pavel Stehule.
* Fix best_inner_indexscan to return both the cheapest-total-cost andTom Lane2007-05-22
| | | | | | | | | | | | cheapest-startup-cost innerjoin indexscans, and make joinpath.c consider both of these (when different) as the inside of a nestloop join. The original design was based on the assumption that indexscan paths always have negligible startup cost, and so total cost is the only important figure of merit; an assumption that's obviously broken by bitmap indexscans. This oversight could lead to choosing poor plans in cases where fast-start behavior is more important than total cost, such as LIMIT and IN queries. 8.1-vintage brain fade exposed by an example from Chuck D.
* Teach tuplestore.c to throw away data before the "mark" point when the callerTom Lane2007-05-21
| | | | | | | | | | | | is using mark/restore but not rewind or backward-scan capability. Insert a materialize plan node between a mergejoin and its inner child if the inner child is a sort that is expected to spill to disk. The materialize shields the sort from the need to do mark/restore and thereby allows it to perform its final merge pass on-the-fly; while the materialize itself is normally cheap since it won't spill to disk unless the number of tuples with equal key values exceeds work_mem. Greg Stark, with some kibitzing from Tom Lane.
* XPath fixes:Peter Eisentraut2007-05-21
| | | | | | | | | | | | | | | - Function renamed to "xpath". - Function is now strict, per discussion. - Return empty array in case when XPath expression detects nothing (previously, NULL was returned in such case), per discussion. - (bugfix) Work with fragments with prologue: select xpath('/a', '<?xml version="1.0"?><a /><b />'); // now XML datum is always wrapped with dummy <x>...</x>, XML prologue simply goes away (if any). - Some cleanup. Nikolay Samokhvalov Some code cleanup and documentation work by myself.
* Fix spurious German index entryPeter Eisentraut2007-05-21
|
* Also removed the function not just the call, sorry.Michael Meskes2007-05-21
|
* Do not try to find local timezone in DecodeDateTime() because theMichael Meskes2007-05-21
| | | | result is not used anyway. This also fixes Vista's build problems.
* To support external compression of archived WAL data, add a flag bit toTom Lane2007-05-20
| | | | | | | | | | | | | | | | | | WAL records that shows whether it is safe to remove full-page images (ie, whether or not an on-line backup was in progress when the WAL entry was made). Also make provision for an XLOG_NOOP record type that can be used to fill in the extra space when decompressing the data for restore. This is the portion of Koichi Suzuki's "full page writes" patch that has to go into the core database. The remainder of that work is two external compression and decompression programs, which for the time being will undergo separate development on pgfoundry. Per discussion. Also, twiddle the handling of BTREE_SPLIT records to ensure it'll be possible to compress them (the previous coding caused essential info to be omitted). The other commonly-used record types seem OK already, with the possible exception of GIN and GIST WAL records, which I don't understand well enough to opine on.
* tackling Vista problem - another tryMichael Meskes2007-05-20
|
* Fix dumb compile error in the last patch.Alvaro Herrera2007-05-19
|
* Have CLUSTER advance the table's relfrozenxid. The new frozen point is theAlvaro Herrera2007-05-18
| | | | | | | | | | | | | | | | FreezeXid introduced in a recent commit, so there isn't any data loss in this approach. Doing it causes ALTER TABLE (or rather, the forms of it that cause a full table rewrite) to be affected as well. In this case, the frozen point is RecentXmin, because after the rewrite all the tuples are relabeled with the rewriting transaction's Xid. TOAST tables are fixed automatically as well, as fallout of the way they were already being handled in the respective code paths. With this patch, there is no longer need to VACUUM tables for Xid wraparound purposes that have been cleaned up via TRUNCATE or CLUSTER.
* Mark some intermediate targets as .PRECIOUS, to replace the recently removedPeter Eisentraut2007-05-18
| | | | .SECONDARY target. This makes experimentation with the PDF builds easier.
* Done:Bruce Momjian2007-05-18
| | | | | < * Fix problem with excessive logging during SSL disconnection > * -Fix problem with excessive logging during SSL disconnection
* Remove redundant logging of send failures when SSL is in use. While pqcomm.cTom Lane2007-05-18
| | | | | | had been taught not to do that ages ago, the SSL code was helpfully bleating anyway. Resolves some recent reports such as bug #3266; however the underlying cause of the related bug #2829 is still unclear.
* dded to TODO:Bruce Momjian2007-05-17
| | | | | | | > > * Support scoped IPv6 addresses > > http://archives.postgresql.org/pgsql-bugs/2007-05/msg00111.php
* Tweaks for SGML markup.Neil Conway2007-05-17
|
* Temporary fix for the problem that pg_stat_activity, inet_client_addr(),Tom Lane2007-05-17
| | | | | | | | | | | | | | and inet_server_addr() fail if the client connected over a "scoped" IPv6 address. In this case getnameinfo() will return a string ending with a poorly-standardized "%something" zone specifier, which these functions try to feed to network_in(), which won't take it. So that we don't lose functionality altogether, suppress the zone specifier before giving the string to network_in(). Per report from Brian Hirt. TODO: probably someday the inet type should support scoped IPv6 addresses, and then this patch should be reverted. Backpatch to 8.2 ... is it worth going further?
* Add URL for:Bruce Momjian2007-05-17
| | | | | | | | * Implement the SQL standard mechanism whereby REVOKE ROLE revokes only the privilege granted by the invoking role, and not those granted by other roles > > http://archives.postgresql.org/pgsql-bugs/2007-05/msg00010.php
* Add, per Alvaro:Bruce Momjian2007-05-17
| | | | | | | > > * Implement the SQL standard mechanism whereby REVOKE ROLE revokes only > the privilege granted by the invoking role, and not those granted > by other roles
* Add:Bruce Momjian2007-05-17
| | | | | | | | > > * Fix problem with excessive logging during SSL disconnection > > http://archives.postgresql.org/pgsql-bugs/2006-12/msg00122.php > http://archives.postgresql.org/pgsql-bugs/2007-05/msg00065.php
* Add CVS comment for recent commit:Bruce Momjian2007-05-17
| | | | | Moved page-level functions from pgstattuple to contrib/pageinspect.
* Removed mktime() call to hopefully get rid of some compatibility problems.Michael Meskes2007-05-17
|
* Fix parameter recalculation for Limit nodes: during a ReScan call we mustTom Lane2007-05-17
| | | | | | | | | | | | | recompute the limit/offset immediately, so that the updated values are available when the child's ReScan function is invoked. Add a regression test for this, too. Bug is new in HEAD (due to the bounded-sorting patch) so no need for back-patch. I did not do anything about merging this signaling with chgParam processing, but if we were to do that we'd still need to compute the updated values at this point rather than during the first ProcNode call. Per observation and test case from Greg Stark, though I didn't use his patch.
* Add database page inspection /contrib module.Bruce Momjian2007-05-17
| | | | Simon and Heikki
* Move the tuple freezing point in CLUSTER to a point further back in the past,Alvaro Herrera2007-05-17
| | | | | | | | | | to avoid losing useful Xid information in not-so-old tuples. This makes CLUSTER behave the same as VACUUM as far a tuple-freezing behavior goes (though CLUSTER does not yet advance the table's relfrozenxid). While at it, move the actual freezing operation in rewriteheap.c to a more appropriate place, and document it thoroughly. This part of the patch from Tom Lane.
* Have TRUNCATE advance the affected table's relfrozenxid to RecentXmin, toAlvaro Herrera2007-05-16
| | | | | | | avoid a later needless VACUUM for Xid-wraparound purposes. We can do this since the table is known to be left empty, so no Xid remains on it. Per discussion.
* Have the rewriteheap code freeze old tuples. This is safe because it is onlyAlvaro Herrera2007-05-16
| | | | | | | | | | | applied to live tuples older than a recent Xmin, not to tuples that may be part of an update chain. Those still keep their original markings. This patch makes it possible for CLUSTER to advance relfrozenxid, thus avoiding the need of vacuuming the table for Xid wraparound purposes. That will be patched separately. Patch from Heikki Linnakangas.
* Avoid emitting empty role names in the GRANTED BY clause of GRANT ROLEAlvaro Herrera2007-05-15
| | | | | when the grantor has been dropped. This is a workaround for the fact that we don't track the grantor as a shared dependency.
* Remove directory qualification in <ossp/uuid.h> because it's not always ↵Andrew Dunstan2007-05-15
| | | | | | installed in ossp. Workaround for when it is: include the ossp directory using --with-includes.
* Fix a bunch of bad grammar in the docs: "<link>, which see for moreNeil Conway2007-05-15
| | | | information" is un-good English.
* Various fixes for the SGML docs. Consistently use spaces before/afterNeil Conway2007-05-15
| | | | | | parentheses in syntax descriptions. Consistently use the present tense when describing the basic purpose of each "DROP" command. Add a few more hyperlinks.
* Update comments for PG_DETOAST_PACKED and VARDATA_ANY on a structuresBruce Momjian2007-05-15
| | | | | | | | | that require alignment. Add a paragraph to the "User-Defined Types" chapter on using these macros since it seems like they're a hit. Gregory Stark
* Make a few marginal improvements to the documentation for the AVNeil Conway2007-05-15
| | | | launcher daemon.
* Add a note to the documentation to clarify that even whenNeil Conway2007-05-15
| | | | | | "autovacuum = off", the system may still periodically start autovacuum processes to prevent XID wraparound. Patch from David Fetter, with editorializing.
* Add URLs for:Bruce Momjian2007-05-15
| | | | | | | * Add support for SQL-standard GENERATED/IDENTITY columns > http://archives.postgresql.org/pgsql-hackers/2007-05/msg00344.php > http://archives.postgresql.org/pgsql-patches/2007-05/msg00076.php
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-05 10:50:48 +0000