aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Use "transient" files for blind writes, take 2Alvaro Herrera2011-06-10
| | | | | | | | | | | | | | | | | | | | | "Blind writes" are a mechanism to push buffers down to disk when evicting them; since they may belong to different databases than the one a backend is connected to, the backend does not necessarily have a relation to link them to, and thus no way to blow them away. We were keeping those files open indefinitely, which would cause a problem if the underlying table was deleted, because the operating system would not be able to reclaim the disk space used by those files. To fix, have bufmgr mark such files as transient to smgr; the lower layer is allowed to close the file descriptor when the current transaction ends. We must be careful to have any other access of the file to remove the transient markings, to prevent unnecessary expensive system calls when evicting buffers belonging to our own database (which files we're likely to require again soon.) This commit fixes a bug in the previous one, which neglected to cleanly handle the LRU ring that fd.c uses to manage open files, and caused an unacceptable failure just before beta2 and was thus reverted.
* Use a constant sprintf format to silence compiler warningAlvaro Herrera2011-06-10
|
* Small comment fixes and enhancements.Heikki Linnakangas2011-06-10
|
* Mention "pg_ctl stop" in pgindent README instructions.Bruce Momjian2011-06-09
|
* Tag 9.1beta2.REL9_1_BETA2Tom Lane2011-06-09
|
* Ecpg doc cleanups, as reported by Marc Cousin.Bruce Momjian2011-06-09
|
* Update 9.1 release notes to reflect commits through today.Tom Lane2011-06-09
| | | | Also do some desultory copy-editing on the notes.
* Revert "Use "transient" files for blind writes"Alvaro Herrera2011-06-09
| | | | | | This reverts commit 54d9e8c6c19cbefa8fb42ed3442a0a5327590ed3, which caused a failure on the buildfarm. Not a good thing to have just before a beta release.
* Use "transient" files for blind writesAlvaro Herrera2011-06-09
| | | | | | | | | | | | | | | | | "Blind writes" are a mechanism to push buffers down to disk when evicting them; since they may belong to different databases than the one a backend is connected to, the backend does not necessarily have a relation to link them to, and thus no way to blow them away. We were keeping those files open indefinitely, which would cause a problem if the underlying table was deleted, because the operating system would not be able to reclaim the disk space used by those files. To fix, have bufmgr mark such files as transient to smgr; the lower layer is allowed to close the file descriptor when the current transaction ends. We must be careful to have any other access of the file to remove the transient markings, to prevent unnecessary expensive system calls when evicting buffers belonging to our own database (which files we're likely to require again soon.)
* Translation updates for 9.1beta2Peter Eisentraut2011-06-09
|
* Fix the truncation logic of the OldSerXid SLRU mechanism. We can't passHeikki Linnakangas2011-06-09
| | | | | | | | | | | | | | | SimpleLruTruncate() a page number that's "in the future", because it will issue a warning and refuse to truncate anything. Instead, we leave behind the latest segment. If the slru is not needed before XID wrap-around, the segment will appear as new again, and not be cleaned up until it gets old enough again. That's a bit unpleasant, but better than not cleaning up anything. Also, fix broken calculation to check and warn if the span of the OldSerXid SLRU is getting too large to fit in the 64k SLRU pages that we have available. It was not XID wraparound aware. Kevin Grittner and me.
* Pgindent run before 9.1 beta2.Bruce Momjian2011-06-09
|
* Update typedef list for upcoming pgindent run.Bruce Momjian2011-06-09
|
* Use the correct eventlog severity for errorMagnus Hagander2011-06-09
|
* Support silent mode for service registrations on win32Magnus Hagander2011-06-09
| | | | | | | | Using -s when registering a service will now suppress the application eventlog entries stating that the service is starting and started. MauMau
* Add gitignore for mingw/cygwin build outputsMagnus Hagander2011-06-09
| | | | Noted by Radosław Smogura
* Mark the SLRU page as dirty when setting an entry in pg_serial. In theHeikki Linnakangas2011-06-09
| | | | passing, fix an incorrect comment.
* Fix documentation of information_schema.element_typesPeter Eisentraut2011-06-09
| | | | | | | | | | | The documentation of the columns collection_type_identifier and dtd_identifier was wrong. This effectively reverts commits 8e1ccad51901e83916dae297cd9afa450957a36c and 57352df66d3a0885899d39c04c067e63c7c0ba30 and updates the name array_type_identifier (the name in SQL:1999) to collection_type_identifier. closes bug #5926
* Make citext's equality and hashing functions collation-insensitive.Tom Lane2011-06-08
| | | | | | | | | | | | | | This is an ugly hack to get around the fact that significant parts of the core backend assume they don't need to worry about passing collation to equality and hashing functions. That's true for the core string datatypes, but citext should ideally have equality behavior that depends on the specified collation's LC_CTYPE. However, there's no chance of fixing the core before 9.2, so we'll have to live with this compromise arrangement for now. Per bug #6053 from Regina Obe. The code changes in this commit should be reverted in full once the core code is up to speed, but be careful about reverting the docs changes: I fixed a number of obsolete statements while at it.
* Reorder pg_ctl promote after pg_ctl statusPeter Eisentraut2011-06-08
| | | | | | | | | | | | Since start/stop/restart/reload/status is a kind of standard command set, it seems odd to insert the special-purpose "promote" in between the closely related "restart" and "reload". So put it after "status" in code and documentation. Put the documentation of the -U option in some sensible place. Rewrite the synopsis sentence in help and documentation to make it less of a growing mouthful.
* Allow domains over arrays to match ANYARRAY parameters again.Tom Lane2011-06-08
| | | | | | | | | | | This use-case was broken in commit 529cb267a6843a6a8190c86b75d091771d99d6a9 of 2010-10-21, in which I commented "For the moment, we just forbid such matching. We might later wish to insert an automatic downcast to the underlying array type, but such a change should also change matching of domains to ANYELEMENT for consistency". We still lack consensus about what to do with ANYELEMENT; but not matching ANYARRAY is a clear loss of functionality compared to prior releases, so let's go ahead and make that happen. Per complaint from Regina Obe and extensive subsequent discussion.
* Make DDL operations play nicely with Serializable Snapshot Isolation.Heikki Linnakangas2011-06-08
| | | | | | | | | | | | | | Truncating or dropping a table is treated like deletion of all tuples, and check for conflicts accordingly. If a table is clustered or rewritten by ALTER TABLE, all predicate locks on the heap are promoted to relation-level locks, because the tuple or page ids of any existing tuples will change and won't be valid after rewriting the table. Arguably ALTER TABLE should be treated like a mass-UPDATE of every row, but if you e.g change the datatype of a column, you could also argue that it's just a change to the physical layout, not a logical change. Reindexing promotes all locks on the index to relation-level lock on the heap. Kevin Grittner, with a lot of cosmetic changes by me.
* Complain politely about access temp/unlogged tables during recovery.Robert Haas2011-06-07
| | | | | | | | | This has never been supported, but we previously let md.c issue the complaint for us at whatever point we tried to examine the backing file. Now we print a nicer error message. Per bug #6041, reported by Emanuel, and extensive discussion with Tom Lane over where to put the check.
* Revert psql bits to display NOT VALID for FKsAlvaro Herrera2011-06-07
| | | | | These are superseded by pg_get_constraintdef's ability to display the same when appropriate, which is a better place to do it anyway.
* Make ascii-art in comments pgindent-safe, and some other formatting changes.Heikki Linnakangas2011-06-07
| | | | Kevin Grittner
* Fix rewriter to cope (more or less) with CTEs in the query being rewritten.Tom Lane2011-06-07
| | | | | | | | | | | | | | | | | | | | | | | Since the original implementation of CTEs only allowed them in SELECT queries, the rule rewriter did not expect to find any CTEs in statements being rewritten by ON INSERT/UPDATE/DELETE rules. We had dealt with this to some extent but the code was still several bricks shy of a load, as illustrated in bug #6051 from Jehan-Guillaume de Rorthais. In particular, we have to be able to copy CTEs from the original query's cteList into that of a rule action, in case the rule action references the CTE (which it pretty much always will). This also implies we were doing things in the wrong order in RewriteQuery: we have to recursively rewrite the CTE queries before expanding the main query, so that we have the rewritten queries available to copy. There are unpleasant limitations yet to resolve here, but at least we now throw understandable FEATURE_NOT_SUPPORTED errors for them instead of just failing with bizarre implementation-dependent errors. In particular, we can't handle propagating the same CTE into multiple post-rewrite queries (because then the CTE would be evaluated multiple times), and we can't cope with conflicts between CTE names in the original query and in the rule actions.
* Reset reindex-in-progress state before reverifying an exclusion constraint.Tom Lane2011-06-05
| | | | | | | This avoids an Assert failure when we try to use ordinary index fetches while checking for exclusion conflicts. Per report from Noah Misch. No need for back-patch because the Assert wasn't there before 9.1.
* Allow building with perl 5.14.Andrew Dunstan2011-06-04
| | | | Patch from Alex Hunsaker.
* Fix documentation reference to "above" examplePeter Eisentraut2011-06-04
| | | | found by Thom Brown
* More ECPG documentation fixesPeter Eisentraut2011-06-04
| | | | Marc Cousin
* ECPG documentation fixPeter Eisentraut2011-06-04
| | | | Marc Cousin, Satoshi Nagayasu
* Expose the "*VALUES*" alias that we generate for a stand-alone VALUES list.Tom Lane2011-06-04
| | | | | | | | | | | | | | | | We were trying to make that strictly an internal implementation detail, but it turns out that it's exposed anyway when dumping a view defined like CREATE VIEW test_view AS VALUES (1), (2), (3) ORDER BY 1; This comes out as CREATE VIEW ... ORDER BY "*VALUES*".column1; which fails to parse when reloading the dump. Hacking ruleutils.c to suppress the column qualification looks like it'd be a risky business, so instead promote the RTE alias to full-fledged usability. Per bug #6049 from Dylan Adams. Back-patch to all supported branches.
* Fix pg_get_constraintdef to cope with NOT VALID constraintsAlvaro Herrera2011-06-03
| | | | | | | | | | This case was missed when NOT VALID constraints were first introduced in commit 722bf7017bbe796decc79c1fde03e7a83dae9ada by Simon Riggs on 2011-02-08. Among other things, it causes pg_dump to omit the NOT VALID flag when dumping such constraints, which may cause them to fail to load afterwards, if they contained values failing the constraint. Per report from Thom Brown.
* Fix failure to check whether a rowtype's component types are sortable.Tom Lane2011-06-03
| | | | | | | | | | | | | | | | | | | | | | | | | The existence of a btree opclass accepting composite types caused us to assume that every composite type is sortable. This isn't true of course; we need to check if the column types are all sortable. There was logic for this for the case of array comparison (ie, check that the element type is sortable), but we missed the point for rowtypes. Per Teodor's report of an ANALYZE failure for an unsortable composite type. Rather than just add some more ad-hoc logic for this, I moved knowledge of the issue into typcache.c. The typcache will now only report out array_eq, record_cmp, and friends as usable operators if the array or composite type will work with those functions. Unfortunately we don't have enough info to do this for anonymous RECORD types; in that case, just assume it will work, and take the runtime failure as before if it doesn't. This patch might be a candidate for back-patching at some point, but given the lack of complaints from the field, I'd rather just test it in HEAD for now. Note: most of the places touched in this patch will need further work when we get around to supporting hashing of record types.
* Truncate id to <=44 charactersPeter Eisentraut2011-06-03
| | | | | | | | This is the original DocBook SGML limit, but apparently most installations have changed it or ignore it, which is why few people have run into this problem. pointed out by Brendan Jurd
* SSI comment fixes and enhancements. Notably, document that the conflict-outHeikki Linnakangas2011-06-03
| | | | | | | flag actually means that the transaction has a conflict out to a transaction that committed before the flagged transaction. Kevin Grittner
* Need to list getpeereid.c in .gitignore, too ...Tom Lane2011-06-02
|
* Use proper SGML doc entities rather than angle-brackets.Bruce Momjian2011-06-02
| | | | Marco Nenciarini
* Handle domains when checking for recursive inclusion of composite types.Tom Lane2011-06-02
| | | | | | | | | | | | | | | We need this now because we allow domains over arrays, and we'll probably allow domains over composites pretty soon, which makes the problem even more obvious. Although domains over arrays also exist in previous versions, this does not need to be back-patched, because the coding used in older versions successfully "looked through" domains over arrays. The problem is exposed by not treating a domain as having a typelem. Problem identified by Noah Misch, though I did not use his patch, since it would require additional work to handle domains over composites that way. This approach is more future-proof.
* Looks like we can't declare getpeereid on Windows anyway.Tom Lane2011-06-02
| | | | ... for lack of the uid_t and gid_t typedefs. Per buildfarm.
* libpq needs its own copy of src/port/getpeereid.Tom Lane2011-06-02
| | | | ... on some platforms, anyway. Per buildfarm.
* Sort COMMENT synopsis and add more examplesPeter Eisentraut2011-06-03
| | | | Josh Kupershmidt
* Clean up after erroneous SELECT FOR UPDATE/SHARE on a sequence.Tom Lane2011-06-02
| | | | | | | | | | My previous commit disallowed this operation, but did nothing about cleaning up the damage if one had already been done. With the operation disallowed, it's okay to just forcibly clear xmax in a sequence's tuple, since any value seen there could not represent a live transaction's lock. So, any sequence-specific operation will repair the problem automatically, whether or not the user has already seen "could not access status of transaction" failures.
* Fix vim-induced typo.Robert Haas2011-06-02
|
* Disallow SELECT FOR UPDATE/SHARE on sequences.Tom Lane2011-06-02
| | | | | | | | | | | | | | | | We can't allow this because such an operation stores its transaction XID into the sequence tuple's xmax. Because VACUUM doesn't process sequences (and we don't want it to start doing so), such an xmax value won't get frozen, meaning it will eventually refer to nonexistent pg_clog storage, and even wrap around completely. Since the row lock is ignored by nextval and setval, the usefulness of the operation is highly debatable anyway. Per reports of trouble with pgpool 3.0, which had ill-advisedly started using such commands as a form of locking. In HEAD, also disallow SELECT FOR UPDATE/SHARE on toast tables. Although this does work safely given the current implementation, there seems no good reason to allow it. I refrained from changing that behavior in back branches, however.
* Typo fix.Tom Lane2011-06-02
|
* Avoid creating init fork for unlogged indexes when it already exists.Robert Haas2011-06-02
| | | | | Report by Greg Sabino Mullane, diagnosis and preliminary patch by Andres Freund, corrections by me.
* Implement getpeereid() as a src/port compatibility function.Tom Lane2011-06-02
| | | | | | | This unifies a bunch of ugly #ifdef's in one place. Per discussion, we only need this where HAVE_UNIX_SOCKETS, so no need to cover Windows. Marko Kreen, some adjustment by Tom Lane
* Allow hash joins to be interrupted while searching hash table for match.Tom Lane2011-06-01
| | | | | | | | | | | Per experimentation with a recent example, in which unreasonable amounts of time could elapse before the backend would respond to a query-cancel. This might be something to back-patch, but the patch doesn't apply cleanly because this code was rewritten for 9.1. Given the lack of field complaints I won't bother for now. Cédric Villemain
* Some copy editing of the release notesPeter Eisentraut2011-06-01
|
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-04 20:29:57 +0000