From 620b128c8e586d8c7eb9cb97a778bd0c7011adbc Mon Sep 17 00:00:00 2001 From: Dmitry Volyntsev Date: Thu, 20 Jun 2019 15:20:34 +0300 Subject: [PATCH] Fixed use-of-uninitialized-value in njs_string_replace_join(). --- njs/njs_string.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/njs/njs_string.c b/njs/njs_string.c index a7d2645e..dc16c7f3 100644 --- a/njs/njs_string.c +++ b/njs/njs_string.c @@ -3652,12 +3652,16 @@ njs_string_replace_join(njs_vm_t *vm, njs_string_replace_t *r) n = r->parts.items; for (i = 0; i < n; i++) { - if (part[i].start == NULL) { - part[i].start = part[i].value.short_string.start; + if (part[i].size == 0) { + continue; } size += part[i].size; + if (part[i].start == NULL) { + part[i].start = part[i].value.short_string.start; + } + len = nxt_utf8_length(part[i].start, part[i].size); if (len >= 0) { -- 2.47.3