From 76a4b8008e5d15a7feb5aafb1396b001909db85d Mon Sep 17 00:00:00 2001 From: Dmitry Volyntsev Date: Mon, 24 Dec 2018 13:59:27 +0300 Subject: [PATCH] Removed surplus for loop. Left over after simplifications in 4e62b7a295e0. Found by Coverity (CID 1441823). --- njs/njs_parser_expression.c | 46 ++++++++++++++++++------------------- 1 file changed, 22 insertions(+), 24 deletions(-) diff --git a/njs/njs_parser_expression.c b/njs/njs_parser_expression.c index 3669fb2f..f615ff46 100644 --- a/njs/njs_parser_expression.c +++ b/njs/njs_parser_expression.c @@ -536,37 +536,35 @@ njs_parser_exponential_expression(njs_vm_t *vm, njs_parser_t *parser, return token; } - for ( ;; ) { - if (token == NJS_TOKEN_EXPONENTIATION) { - - node = njs_parser_node_alloc(vm); - if (nxt_slow_path(node == NULL)) { - return NJS_TOKEN_ERROR; - } + if (token == NJS_TOKEN_EXPONENTIATION) { - node->token = token; - node->u.operation = njs_vmcode_exponentiation; - node->scope = parser->scope; - node->left = parser->node; - node->left->dest = node; + node = njs_parser_node_alloc(vm); + if (nxt_slow_path(node == NULL)) { + return NJS_TOKEN_ERROR; + } - token = njs_parser_token(parser); - if (nxt_slow_path(token <= NJS_TOKEN_ILLEGAL)) { - return token; - } + node->token = token; + node->u.operation = njs_vmcode_exponentiation; + node->scope = parser->scope; + node->left = parser->node; + node->left->dest = node; - token = njs_parser_exponential_expression(vm, parser, NULL, token); - if (nxt_slow_path(token <= NJS_TOKEN_ILLEGAL)) { - return token; - } + token = njs_parser_token(parser); + if (nxt_slow_path(token <= NJS_TOKEN_ILLEGAL)) { + return token; + } - node->right = parser->node; - node->right->dest = node; - parser->node = node; + token = njs_parser_exponential_expression(vm, parser, NULL, token); + if (nxt_slow_path(token <= NJS_TOKEN_ILLEGAL)) { + return token; } - return token; + node->right = parser->node; + node->right->dest = node; + parser->node = node; } + + return token; } -- 2.47.3