From 55c5399846a55af036ed2e67c08484cc76c0d1c2 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Wed, 26 Feb 2020 14:32:53 +0100 Subject: [PATCH] MINOR: epoll: always initialize all of epoll_event to please valgrind valgrind complains that epoll_ctl() uses an epoll_event in which we have only set the part we use from the data field (i.e. the fd). Tests show that pre-initializing the struct in the stack doesn't have a measurable impact so let's do it. --- src/ev_epoll.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/ev_epoll.c b/src/ev_epoll.c index 512251009..1d204f925 100644 --- a/src/ev_epoll.c +++ b/src/ev_epoll.c @@ -61,7 +61,7 @@ static void __fd_clo(int fd) static void _update_fd(int fd) { int en, opcode; - struct epoll_event ev; + struct epoll_event ev = { }; en = fdtab[fd].state; @@ -120,7 +120,6 @@ static void _update_fd(int fd) } /* construct the epoll events based on new state */ - ev.events = 0; if (en & FD_EV_ACTIVE_R) ev.events |= EPOLLIN | EPOLLRDHUP; -- 2.47.3