From: Sergey Kandaurov Date: Tue, 18 Aug 2020 20:33:40 +0000 (+0300) Subject: QUIC: changed ctx->largest_ack initial value to type maximum. X-Git-Tag: release-1.25.0~4^2~597 X-Git-Url: http://git.kaiwu.me/postgresql/log/contrib/postgres_fdw/static/gitweb.js?a=commitdiff_plain;h=160242dd2e8544f21056056ce1b36b209bfaea63;p=nginx.git QUIC: changed ctx->largest_ack initial value to type maximum. In particular, this prevents declaring packet number 0 as lost if there aren't yet any acknowledgements in this packet number space. For example, only Initial packets were acknowledged in handshake. --- diff --git a/src/event/ngx_event_quic.c b/src/event/ngx_event_quic.c index 42650ab1a..94097c4d9 100644 --- a/src/event/ngx_event_quic.c +++ b/src/event/ngx_event_quic.c @@ -690,6 +690,7 @@ ngx_quic_new_connection(ngx_connection_t *c, ngx_ssl_t *ssl, ngx_queue_init(&qc->send_ctx[i].frames); ngx_queue_init(&qc->send_ctx[i].sent); qc->send_ctx[i].largest_pn = (uint64_t) -1; + qc->send_ctx[i].largest_ack = (uint64_t) -1; } for (i = 0; i < NGX_QUIC_ENCRYPTION_LAST; i++) { @@ -2346,7 +2347,7 @@ ngx_quic_handle_ack_frame(ngx_connection_t *c, ngx_quic_header_t *pkt, } /* 13.2.3. Receiver Tracking of ACK Frames */ - if (ctx->largest_ack < max) { + if (ctx->largest_ack < max || ctx->largest_ack == (uint64_t) -1) { ctx->largest_ack = max; ngx_log_debug1(NGX_LOG_DEBUG_EVENT, c->log, 0, "quic updated largest received ack: %uL", max);