From: Dmitry Volyntsev <xeioex@nginx.com>
Date: Tue, 26 May 2020 19:03:11 +0000 (+0000)
Subject: Removed dead store assignment after 1d0825906438.
X-Git-Tag: 0.4.2~55
X-Git-Url: http://git.kaiwu.me/postgresql/log/contrib/postgres_fdw/static/gitweb.js?a=commitdiff_plain;h=3bdeb51bc33e815ea67005b53a61e7657b699b28;p=njs.git

Removed dead store assignment after 1d0825906438.

Found with Clang Static Analyzer.
---

diff --git a/src/njs_array.c b/src/njs_array.c
index c1acc6b9..ce449666 100644
--- a/src/njs_array.c
+++ b/src/njs_array.c
@@ -3219,7 +3219,7 @@ njs_array_prototype_sort(njs_vm_t *vm, njs_value_t *args, njs_uint_t nargs,
     int64_t                i, und, inv, len, nlen, length;
     njs_int_t              ret;
     njs_array_t            *array;
-    njs_value_t            *this, *comparefn, *start, *strings, value;
+    njs_value_t            *this, *comparefn, *start, *strings;
     njs_array_sort_ctx_t   ctx;
     njs_array_sort_slot_t  *p, *end, *slots, *nslots;
 
@@ -3271,15 +3271,13 @@ njs_array_prototype_sort(njs_vm_t *vm, njs_value_t *args, njs_uint_t nargs,
 
         for (i = length - 1; i >= 0; i--) {
             if (njs_is_undefined(&start[i])) {
-                value = start[i];
                 start[i] = start[inv - und - 1];
-                start[inv - und - 1] = value;
+                start[inv - und - 1] = njs_value_undefined;
                 und++;
                 continue;
             }
 
             if (!njs_is_valid(&start[i])) {
-                value = start[i];
                 start[i] = start[inv - und - 1];
                 start[inv - und - 1] = njs_value_undefined;
                 start[inv - 1] = njs_value_invalid;