From: Dmitry Volyntsev Date: Tue, 2 Jun 2020 14:59:27 +0000 (+0000) Subject: Fixed typo introduced in db77713e0536. X-Git-Url: http://git.kaiwu.me/postgresql/log/contrib/postgres_fdw/static/gitweb.js?a=commitdiff_plain;h=892af3ee5ec2e1131a820a9e584de0c039192e66;p=njs.git Fixed typo introduced in db77713e0536. --- diff --git a/src/njs_array.c b/src/njs_array.c index 486062d7..bb820a80 100644 --- a/src/njs_array.c +++ b/src/njs_array.c @@ -1361,7 +1361,7 @@ njs_array_prototype_reverse(njs_vm_t *vm, njs_value_t *args, njs_uint_t nargs, array->start[l] = hvalue; } else { - array->start[h] = njs_value_invalid; + array->start[l] = njs_value_invalid; } } else if (hret == NJS_OK) { diff --git a/src/test/njs_unit_test.c b/src/test/njs_unit_test.c index 757ae23f..bdc43969 100644 --- a/src/test/njs_unit_test.c +++ b/src/test/njs_unit_test.c @@ -4504,6 +4504,15 @@ static njs_unit_test_t njs_test[] = { njs_str("var a = [1,2,3,4]; a.reverse()"), njs_str("4,3,2,1") }, + { njs_str("[1,2,3,,,].reverse()"), + njs_str(",,3,2,1") }, + + { njs_str("[,2,3,,,].reverse()"), + njs_str(",,3,2,") }, + + { njs_str("[,,,3,2,1].reverse()"), + njs_str("1,2,3,,,") }, + { njs_str("var o = {1:true, 2:'', length:-2}; Array.prototype.reverse.call(o) === o"), njs_str("true") },