From: Artem S. Povalyukhin <artem.povaluhin@gmail.com>
Date: Fri, 22 Nov 2019 08:02:55 +0000 (+0300)
Subject: Fixed typo in njs_string_prototype_pad().
X-Git-Tag: 0.3.8~59
X-Git-Url: http://git.kaiwu.me/postgresql/log/contrib/postgres_fdw/static/gitweb.js?a=commitdiff_plain;h=fd861aceb3e26140f5862c12cc1300f7734f127f;p=njs.git

Fixed typo in njs_string_prototype_pad().

The typo was introduced in 47cdd4680fc2.

This closes #253 issue on Github.
---

diff --git a/src/njs_string.c b/src/njs_string.c
index c13e1bb0..f18a0c3f 100644
--- a/src/njs_string.c
+++ b/src/njs_string.c
@@ -2939,7 +2939,7 @@ njs_string_prototype_pad(njs_vm_t *vm, njs_value_t *args, njs_uint_t nargs,
         } else {
             ret = njs_value_to_string(vm, pad, pad);
             if (njs_slow_path(ret != NJS_OK)) {
-                return NJS_OK;
+                return NJS_ERROR;
             }
         }
     }
diff --git a/src/test/njs_unit_test.c b/src/test/njs_unit_test.c
index 37697386..2c40adbe 100644
--- a/src/test/njs_unit_test.c
+++ b/src/test/njs_unit_test.c
@@ -6964,6 +6964,9 @@ static njs_unit_test_t  njs_test[] =
     { njs_str("'абв'.padStart(10, 'эю')"),
       njs_str("эюэюэюэабв") },
 
+    { njs_str("'abc'.padStart(10, Symbol())"),
+      njs_str("TypeError: Cannot convert a Symbol value to a string") },
+
     { njs_str("'1234'.padEnd(4)"),
       njs_str("1234") },
 
@@ -7012,6 +7015,9 @@ static njs_unit_test_t  njs_test[] =
     { njs_str("'абвг'.padEnd(10, 'ДЕЖЗ')"),
       njs_str("абвгДЕЖЗДЕ") },
 
+    { njs_str("'abc'.padEnd(10, Symbol())"),
+      njs_str("TypeError: Cannot convert a Symbol value to a string") },
+
     { njs_str("String.bytesFrom({})"),
       njs_str("TypeError: value must be a string or array") },