From ccf6100e11769b1650ba56fa727cb51993d0f3d2 Mon Sep 17 00:00:00 2001 From: Dragan Dosen Date: Mon, 18 Sep 2017 08:20:33 +0200 Subject: [PATCH] BUG/MINOR: contrib/mod_defender: close the va_list argp before return Fix the case when the va_list argp could be left open if the function vsnprintf() returned a negative value. --- contrib/mod_defender/defender.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contrib/mod_defender/defender.c b/contrib/mod_defender/defender.c index c86d25e0a..17341760c 100644 --- a/contrib/mod_defender/defender.c +++ b/contrib/mod_defender/defender.c @@ -149,9 +149,10 @@ static char *defender_printf(apr_pool_t *pool, const char *fmt, ...) va_start(argp, fmt); len = vsnprintf(NULL, 0, fmt, argp); + va_end(argp); + if (len < 0) return NULL; - va_end(argp); if (!(dst = apr_pcalloc(pool, len + 1))) return NULL; -- 2.47.3