aboutsummaryrefslogtreecommitdiff
path: root/contrib
Commit message (Collapse)AuthorAge
* In pg_upgrade, disallow migration of 8.3 clusters using contrib/ltreeBruce Momjian2011-09-07
| | | | | | | | because its internal format was changed in 8.4. Backpatch to 9.0 and 9.1. Report by depesz, diagnosis by Tom.
* Fix not-backwards-compatible pg_upgrade test for prepared transactions.Tom Lane2011-08-30
| | | | | | There's no reason for this test to use the undocumented pg_prepared_xact() function, when it can use the stable API pg_prepared_xacts instead. Fixes breakage against 8.3, as reported by Justin Arnold.
* In pg_upgrade, limit schema name filter to include toast tables. BugBruce Momjian2011-08-26
| | | | | | introduced recently when trying to filter out temp tables. Backpatch to 9.0 and 9.1.
* Fix pgstatindex() to give consistent results for empty indexes.Tom Lane2011-08-24
| | | | | | | | | | | | | | | | For an empty index, the pgstatindex() function would compute 0.0/0.0 for its avg_leaf_density and leaf_fragmentation outputs. On machines that follow the IEEE float arithmetic standard with any care, that results in a NaN. However, per report from Rushabh Lathia, Microsoft couldn't manage to get this right, so you'd get a bizarre error on Windows. Fix by forcing the results to be NaN explicitly, rather than relying on the division operator to give that or the snprintf function to print it correctly. I have some doubts that this is really the most useful definition, but it seems better to remain backward-compatible with those platforms for which the behavior wasn't completely broken. Back-patch to 8.2, since the code is like that in all current releases.
* Fix pgxs.mk to always add --dbname=$(CONTRIB_TESTDB) to REGRESS_OPTS.Tom Lane2011-08-24
| | | | | | | | | | | | | | The previous coding resulted in contrib modules unintentionally overriding the use of CONTRIB_TESTDB. There seems no particularly good reason to allow that (after all, the makefile can set CONTRIB_TESTDB if that's really what it intends). In passing, document REGRESS_OPTS where the other pgxs.mk options are documented. Back-patch to 9.1 --- in prior versions, there were no cases of contrib modules setting REGRESS_OPTS without including the --dbname switch, so while the coding was fragile there was no actual bug.
* Avoid locale dependency in expected output.Tom Lane2011-08-24
| | | | | | We'll have to settle for just listing the extensions' data types, since function arguments seem to sort differently in different locales. Per buildfarm results.
* Fix multiple bugs in extension dropping.Tom Lane2011-08-24
| | | | | | | | | | | | | | | | | | | | | | | | | When we implemented extensions, we made findDependentObjects() treat EXTENSION dependency links similarly to INTERNAL links. However, that logic contained an implicit assumption that an object could have at most one INTERNAL dependency, so it did not work correctly for objects having both INTERNAL and DEPENDENCY links. This led to failure to drop some extension member objects when dropping the extension. Furthermore, we'd never actually exercised the case of recursing to an internally-referenced (owning) object from anything other than a NORMAL dependency, and it turns out that passing the incoming dependency's flags to the owning object is the Wrong Thing. This led to sometimes dropping a whole extension silently when we should have rejected the drop command for lack of CASCADE. Since we obviously were under-testing extension drop scenarios, add some regression test cases. Unfortunately, such test cases require some extensions (duh), so we can't test for problems in the core regression tests. I chose to add them to the earthdistance contrib module, which is a good test case because it has a dependency on the cube contrib module. Back-patch to 9.1. Arguably these are pre-existing bugs in INTERNAL dependency handling, but since it appears that the cases can never arise pre-9.1, I'll refrain from back-patching the logic changes further than that.
* Fix contrib/sepgsql and contrib/xml2 to always link required libraries.Robert Haas2011-08-19
| | | | | | | | | | contrib/xml2 can get by without libxslt; the relevant features just won't work. But if doesn't have libxml2, or if sepgsql doesn't have libselinux, the link succeeds but the module then fails to work at load time. To avoid that, link the require libraries unconditionally, so that it will be clear at link-time that there is a problem. Per discussion with Tom Lane and KaiGai Kohei.
* Allow sepgsql regression tests to be run from a user homedir.Robert Haas2011-08-19
| | | | KaiGai Kohei, with some changes by me.
* In pg_upgrade, avoid dumping orphaned temporary tables. This makes theBruce Momjian2011-08-15
| | | | | | pg_upgrade schema matching pattern match pg_dump/pg_dumpall. Fix for 9.0, 9.1, and 9.2.
* Message style improvementsPeter Eisentraut2011-08-14
|
* Fix pg_update to properly test for the data directory's existence onBruce Momjian2011-07-30
| | | | | | Win32. Backpatch to 9.1.
* In pg_upgrade on Windows, check if the directory is writable by actuallyBruce Momjian2011-07-24
| | | | | | | creating and removing a file because access() doesn't work on that platform. Backpatch to 9.1 where this check was added.
* In pg_upgrade, fix the -l/log option to work on Windows.Bruce Momjian2011-07-20
| | | | | | | Also, double-quote the log file name in all places, to allow (on all platforms) log file names with spaces. Back patch to 9.0 and 9.1.
* Replace errdetail("%s", ...) with errdetail_internal("%s", ...).Tom Lane2011-07-16
| | | | | | There may be some other places where we should use errdetail_internal, but they'll have to be evaluated case-by-case. This commit just hits a bunch of places where invoking gettext is obviously a waste of cycles.
* Fix use of unportable %m formatPeter Eisentraut2011-07-07
|
* Make the file_fdw validator check that a filename option has been provided.Tom Lane2011-07-05
| | | | | | This was already a runtime failure condition, but it's better to check at validation time if possible. Lightly modified version of a patch by Shigeru Hanada.
* Postgres -> PostgreSQL in error messagePeter Eisentraut2011-07-05
|
* Make distprep and *clean build targets recurse into all subdirectories.Tom Lane2011-07-03
| | | | | | | | | | | | | | | | | | | Certain subdirectories do not get built if corresponding options are not selected at configure time. However, "make distprep" should visit such directories anyway, so that constructing derived files to be included in the tarball happens without requiring all configure options to be given in the tarball build script. Likewise, it's better if cleanup actions unconditionally visit all directories (for example, this ensures proper cleanup if someone has done a manual make in such a subdirectory). To handle this, set up a convention that subdirectories that are conditionally included in SUBDIRS should be added to ALWAYS_SUBDIRS instead when they are excluded. Back-patch to 9.1, so that plpython's spiexceptions.h will get provided in 9.1 tarballs. There don't appear to be any instances where distprep actions got missed in previous releases, and anyway this fix requires gmake 3.80 so we don't want to apply it before 9.1.
* Async dblink functions require a named connection, and therefore shouldJoe Conway2011-06-25
| | | | | use DBLINK_GET_NAMED_CONN rather than DBLINK_GET_CONN. Problem found by Peter Eisentraut and patch by Fujii Masao.
* In pg_upgrade, check that the binary and data directories are the sameBruce Momjian2011-06-22
| | | | | | | | major version. Backpatch to 9.1. Dan McGee
* Adjust pg_upgrade check for pg_upgrade_support to happen after theBruce Momjian2011-06-22
| | | | | | | | binary directory has been validated. Backpatch to 9.1. Dan McGee
* Fix pg_upgrade status message capitalization mistake.Bruce Momjian2011-06-22
| | | | | | Backpatch to 9.1 and 9.0. Dan McGee
* Apply upstream fix for blowfish signed-character bug (CVE-2011-2483).Tom Lane2011-06-21
| | | | | | | | | | | | | | | | | | | | | A password containing a character with the high bit set was misprocessed on machines where char is signed (which is most). This could cause the preceding one to three characters to fail to affect the hashed result, thus weakening the password. The result was also unportable, and failed to match some other blowfish implementations such as OpenBSD's. Since the fix changes the output for such passwords, upstream chose to provide a compatibility hack: password salts beginning with $2x$ (instead of the usual $2a$ for blowfish) are intentionally processed "wrong" to give the same hash as before. Stored password hashes can thus be modified if necessary to still match, though it'd be better to change any affected passwords. In passing, sync a couple other upstream changes that marginally improve performance and/or tighten error checking. Back-patch to all supported branches. Since this issue is already public, no reason not to commit the fix ASAP.
* In pg_upgrade, check there are no prepared transactions.Bruce Momjian2011-06-14
| | | | Backpatch to 9.1.
* Pgindent run before 9.1 beta2.Bruce Momjian2011-06-09
|
* Make citext's equality and hashing functions collation-insensitive.Tom Lane2011-06-08
| | | | | | | | | | | | | | This is an ugly hack to get around the fact that significant parts of the core backend assume they don't need to worry about passing collation to equality and hashing functions. That's true for the core string datatypes, but citext should ideally have equality behavior that depends on the specified collation's LC_CTYPE. However, there's no chance of fixing the core before 9.2, so we'll have to live with this compromise arrangement for now. Per bug #6053 from Regina Obe. The code changes in this commit should be reverted in full once the core code is up to speed, but be careful about reverting the docs changes: I fixed a number of obsolete statements while at it.
* Recode non-ASCII characters in source to UTF-8Peter Eisentraut2011-05-31
| | | | | | For consistency, have all non-ASCII characters from contributors' names in the source be in UTF-8. But remove some other more gratuitous uses of non-ASCII characters.
* Remove literal tabs from message stringsPeter Eisentraut2011-05-28
|
* In pg_upgrade, do case-insensitive checks of locale, encoding, and ctypeBruce Momjian2011-05-24
| | | | because these are often inconsistently capitalized.
* Replace strdup() with pstrdup(), to avoid leaking memory.Heikki Linnakangas2011-05-18
| | | | | It's been like this since the seg module was introduced, so backpatch to 8.2 which is the oldest supported version.
* In pg_upgrade, clean up handling of invalid directory specification byBruce Momjian2011-05-18
| | | | checking the stat() errno value more strictly.
* Improve pg_upgrade error reporting if the bin or data directories do notBruce Momjian2011-05-18
| | | | exist or are not directories.
* /contrib/foo -> contrib/fooPeter Eisentraut2011-05-19
| | | | | Since contrib is a relative directory specification, a leading slash is inappropriate.
* Improve pg_upgrade X_OK comment.Bruce Momjian2011-05-18
|
* Fix pg_upgrade build problem on Windows when using X_OK accessBruce Momjian2011-05-18
| | | | permission check on the current directory.
* Update pg_upgrade directory check error message.Bruce Momjian2011-05-16
|
* Add pg_upgrade check to make sure the user has full access permission inBruce Momjian2011-05-16
| | | | the current directory; if not, throw an error.
* Allow pg_upgrade to honor libpq environment variables. Add 'local'Bruce Momjian2011-05-16
| | | | checks for PGHOST and PGHOSTADDR.
* Fix assorted typosAlvaro Herrera2011-05-12
|
* Put options help in alphabetical orderPeter Eisentraut2011-05-10
|
* Format pg_upgrade --version in line with conventionsPeter Eisentraut2011-05-10
|
* Add bug report line to pg_upgrade --help outputPeter Eisentraut2011-05-10
|
* Put pg_test_fsync --help and --version output in line with conventionsPeter Eisentraut2011-05-10
| | | | Foremost, it should go to stdout.
* In pg_upgrade, remove suggestion of setting pg_hba.conf to 'trust', nowBruce Momjian2011-05-10
| | | | | that we report the libpq connection failure string. Per suggestion from Robert Haas.
* In pg_upgrade, add status message about superuser check.Bruce Momjian2011-05-09
|
* Add C comment why client encoding can be set in pg_upgrade.Bruce Momjian2011-05-07
|
* In pg_upgrade, report non-super-user username in error message.Bruce Momjian2011-05-07
|
* Check that the pg_upgrade user specified is a super-user.Bruce Momjian2011-05-07
| | | | | | Also report the error message when the post-pg_ctl connection fails. Per private bug report from EnterpriseDB.
* Adjust pg_upgrade FATAL error messages to have consistent newlines.Bruce Momjian2011-05-06
| | | | Also adjust some error message capitalization for consistency.
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-06 14:41:58 +0000