aboutsummaryrefslogtreecommitdiff
path: root/src/backend
Commit message (Collapse)AuthorAge
...
* Allow ORDER BY/GROUP BY/etc items to match targetlist items regardless ofTom Lane2010-07-18
| | | | | | | | | | | | | | | | | any implicit casting previously applied to the targetlist item. This is reasonable because the implicit cast, by definition, wasn't written by the user; so we are preserving the expected behavior that ORDER BY items match textually equivalent tlist items. The case never arose before because there couldn't be any implicit casting of a top-level SELECT item before we process ORDER BY etc. But now it can arise in the context of aggregates containing ORDER BY clauses, since the "targetlist" is the already-casted list of arguments for the aggregate. The net effect is that the datatype used for ORDER BY/DISTINCT purposes is the aggregate's declared input type, not that of the original input column; which is a bit debatable but not horrendous, and to do otherwise would require major rework that doesn't seem justified. Per bug #5564 from Daniel Grace. Back-patch to 9.0 where aggregate ORDER BY was implemented.
* Simplify missing tablespace replay error hint message, but only in HEADBruce Momjian2010-07-18
| | | | so we don't need to re-translate for 9.0.
* Add a log_file_mode GUC that allows control of the file permissions set onTom Lane2010-07-16
| | | | | | | | | log files created by the syslogger process. In passing, make unix_file_permissions display its value in octal, same as log_file_mode now does. Martin Pihlak
* Add support for dividing money by money (yielding a float8 result) and forTom Lane2010-07-16
| | | | | | casting between money and numeric. Andy Balholm, reviewed by Kevin Grittner
* Remove a sanity check in the exclusion-constraint code that prevented usersTom Lane2010-07-16
| | | | | | | | | | | from defining non-self-conflicting constraints. Jeff Davis Note: I (tgl) objected to removing this check in 9.0 on the grounds that it was an important sanity check in new, poorly tested code. However, it should be all right to remove it for 9.1, since we'll get field testing from the 9.0 branch.
* Remove duplicate code in DefineOpFamily().Tom Lane2010-07-16
| | | | | | | The code was probably meant to be this way all along, since the subroutine CreateOpFamily previously had only one caller. But it wasn't. KaiGai Kohei
* Teach EXPLAIN to print PARAM_EXEC Params as the referenced expressions,Tom Lane2010-07-13
| | | | | | | | | | | | | | | | rather than just $N. This brings the display of nestloop-inner-indexscan plans back to where it's been, and incidentally improves the display of SubPlan parameters as well. In passing, simplify the EXPLAIN code by having it deal primarily in the PlanState tree rather than separately searching Plan and PlanState trees. This is noticeably cleaner for subplans, and about a wash elsewhere. One small difference from previous behavior is that EXPLAIN will no longer qualify local variable references in inner-indexscan plan nodes, since it no longer sees such nodes as possibly referencing multiple tables. Vars referenced through PARAM_EXEC Params are still forcibly qualified, though, so I don't think the display is any more confusing than before. Adjust a couple of examples in the documentation to match this behavior.
* Oops, in the previous fix to prevent a cursor that's being used in a FORHeikki Linnakangas2010-07-13
| | | | | | | | | loop from being dropped, I missed subtransaction cleanup. Pinned portals must be dropped at subtransaction cleanup just as they are at main transaction cleanup. Per bug #5556 by Robert Walker. Backpatch to 8.0, 7.4 didn't have subtransactions.
* Make NestLoop plan nodes pass outer-relation variables into their innerTom Lane2010-07-12
| | | | | | | | | | | | relation using the general PARAM_EXEC executor parameter mechanism, rather than the ad-hoc kluge of passing the outer tuple down through ExecReScan. The previous method was hard to understand and could never be extended to handle parameters coming from multiple join levels. This patch doesn't change the set of possible plans nor have any significant performance effect, but it's necessary infrastructure for future generalization of the concept of an inner indexscan plan. ExecReScan's second parameter is now unused, so it's removed.
* Avoid an Assert failure in deconstruct_array() by making get_attstatsslot()Tom Lane2010-07-09
| | | | | | | | | | | | | | | | use the actual element type of the array it's disassembling, rather than trusting the type OID passed in by its caller. This is needed because sometimes the planner passes in a type OID that's only binary-compatible with the target column's type, rather than being an exact match. Per an example from Bernd Helmle. Possibly we should refactor get_attstatsslot/free_attstatsslot to not expect the caller to supply type ID data at all, but for now I'll just do the minimum-change fix. Back-patch to 7.4. Bernd's test case only crashes back to 8.0, but since these subroutines are the same in 7.4, I suspect there may be variant cases that would crash 7.4 as well.
* Fix ruleutils' get_variable() to print something useful for Vars referencingTom Lane2010-07-09
| | | | | | | | | | resjunk outputs of subquery tlists, instead of throwing an error. Per bug #5548 from Daniel Grace. We might at some point find we ought to back-patch this further than 9.0, but I think that such Vars can only occur as resjunk members of upper-level tlists, in which case the problem can't arise because prior versions didn't print resjunk tlist items in EXPLAIN VERBOSE.
* Add a hook in ExecCheckRTPerms().Robert Haas2010-07-09
| | | | | | | | | | | This hook allows a loadable module to gain control when table permissions are checked. It is expected to be used by an eventual SE-PostgreSQL implementation, but there are other possible applications as well. A sample contrib module can be found in the archives at: http://archives.postgresql.org/pgsql-hackers/2010-05/msg01095.php Robert Haas and Stephen Frost
* Translation updates for 9.0beta3Peter Eisentraut2010-07-08
|
* Make the Windows tcp keepalive support depend on the existance of theMagnus Hagander2010-07-08
| | | | | SIO_KEEPALIVE_VALS define instead of just WIN32, since MingW doesn't support this API (yet?).
* Update obsolete comment. Noted by Josh Tolley.Tom Lane2010-07-08
|
* Add support for TCP keepalives on Windows, both for backend and the newMagnus Hagander2010-07-08
| | | | libpq support.
* Fix "cannot handle unplanned sub-select" error that can occur when aTom Lane2010-07-08
| | | | | | | | | sub-select contains a join alias reference that expands into an expression containing another sub-select. Per yesterday's report from Merlin Moncure and subsequent off-list investigation. Back-patch to 7.4. Older versions didn't attempt to flatten sub-selects in ways that would trigger this problem.
* Adjust mbutils.c so it won't get broken by future pgindent runs.Tom Lane2010-07-07
| | | | | | To do that, replace L'\0' by (WCHAR) 0. Perhaps someday we should teach pgindent about wide-character literals, but so long as this is the only use-case in the entire Postgres sources, a workaround seems easier.
* Make log_temp_files based on kB, and revert docs & comments to match.Robert Haas2010-07-06
| | | | | | | Per extensive discussion on pgsql-hackers. We are deliberately not back-patching this even though the behavior of 8.3 and 8.4 is unquestionably broken, for fear of breaking existing users of this parameter. This incompatibility should be release-noted.
* Support setting the keepalive idle time on MacOS X.Robert Haas2010-07-06
| | | | | | MacOS X uses TCP_KEEPALIVE rather than TCP_KEEPIDLE for this purpose. Thanks to Fujii Masao for the review.
* Undo pgindent breakage (again). Per buildfarm.Tom Lane2010-07-06
|
* pgindent run for 9.0, second runBruce Momjian2010-07-06
|
* Split the LDFLAGS make variable into two parts: LDFLAGS is now used forTom Lane2010-07-05
| | | | | | | | | | | | | linking both executables and shared libraries, and we add on LDFLAGS_EX when linking executables or LDFLAGS_SL when linking shared libraries. This provides a significantly cleaner way of dealing with link-time switches than the former behavior. Also, make sure that the various platform-specific %.so: %.o rules incorporate LDFLAGS and LDFLAGS_SL; most of them missed that before. (I did not add these variables for the platforms that invoke $(LD) directly, however. It's not clear if we can do that safely, since for the most part we assume these variables use CC command-line syntax.) Per gripe from Aaron Swenson and subsequent investigation.
* The previous fix in CVS HEAD and 8.4 for handling the case where a cursorHeikki Linnakangas2010-07-05
| | | | | | | | | | | being used in a PL/pgSQL FOR loop is closed was inadequate, as Tom Lane pointed out. The bug affects FOR statement variants too, because you can close an implicitly created cursor too by guessing the "<unnamed portal X>" name created for it. To fix that, "pin" the portal to prevent it from being dropped while it's being used in a PL/pgSQL FOR loop. Backpatch all the way to 7.4 which is the oldest supported version.
* Don't set recoveryLastXTime when replaying a checkpoint --- that was a bogusTom Lane2010-07-03
| | | | | | | | idea from the start since the variable is only meant to track commit/abort events. This patch reverts the logic around the variable to what it was in 8.4, except that the value is now kept in shared memory rather than a static variable, so that it can be reported correctly by CreateRestartPoint (which is executed in the bgwriter).
* Make vacuum_defer_cleanup_age be PGC_SIGHUP level, since it's not sensibleTom Lane2010-07-03
| | | | | | | to have different values in different processes of the primary server. Also put it into the "Streaming Replication" GUC category; it doesn't belong in "Standby Servers" because you use it on the master not the standby. In passing also correct guc.c's idea of wal_keep_segments' category.
* Replace max_standby_delay with two parameters, max_standby_archive_delay andTom Lane2010-07-03
| | | | | | | | | | | | | | max_standby_streaming_delay, and revise the implementation to avoid assuming that timestamps found in WAL records can meaningfully be compared to clock time on the standby server. Instead, the delay limits are compared to the elapsed time since we last obtained a new WAL segment from archive or since we were last "caught up" to WAL data arriving via streaming replication. This avoids problems with clock skew between primary and standby, as well as other corner cases that the original coding would misbehave in, such as the primary server having significant idle time between transactions. Per my complaint some time ago and considerable ensuing discussion. Do some desultory editing on the hot standby documentation, too.
* Allow REASSIGNED OWNED to handle opclasses and opfamilies.Robert Haas2010-07-03
| | | | | | | | Backpatch to 8.3, which is as far back as we have opfamilies. The opclass portion could probably be backpatched to 8.2, when REASSIGN OWNED was added, but for now I have not done that. Asko Tiidumaa, with minor adjustments by me.
* Move copydir.c from src/port to src/backend/storage/fileRobert Haas2010-07-02
| | | | | | | | | | | | | The previous commit to make copydir() interruptible prevented postgres.exe from linking on MinGW and Cygwin, because on those platforms libpgport_srv.a can't freely reference symbols defined by the backend. Since that code is already backend-specific anyway, just move the whole file into the backend rather than adding further kludges to deal with the symbols needed by CHECK_FOR_INTERRUPTS(). This probably needs some further cleanup, but this commit just moves the file as-is, which should hopefully be enough to turn the buildfarm green again.
* Issue 'mkdir' hint when replying CREATE TABLESPACE in recovery mode.Bruce Momjian2010-07-02
| | | | Per idea from Fujii Masao
* Allow ALTER TABLE .. SET TABLESPACE to be interrupted.Robert Haas2010-07-01
| | | | | | Backpatch to 8.0, where tablespaces were introduced. Guillaume Lelarge
* stringToNode() and deparse_expression_pretty() crash on invalid input,Heikki Linnakangas2010-06-30
| | | | | | | | | | but we have nevertheless exposed them to users via pg_get_expr(). It would be too much maintenance effort to rigorously check the input, so put a hack in place instead to restrict pg_get_expr() so that the argument must come from one of the system catalog columns known to contain valid expressions. Per report from Rushabh Lathia. Backpatch to 7.4 which is the oldest supported version at the moment.
* Add C comment about why synchronous_commit=off behavior can loseBruce Momjian2010-06-29
| | | | committed transactions in a postmaster crash.
* Message tuningPeter Eisentraut2010-06-29
|
* emode_for_corrupt_record shouldn't reduce LOG messages to WARNING.Robert Haas2010-06-28
| | | | In non-interactive sessions, WARNING sorts below LOG.
* Fix log_temp_files docs and comments to say bytes not kilobytes.Simon Riggs2010-06-25
| | | | | stat(2) field st_size returns bytes not kilobytes. Bug found during recent performance tuning for PostgreSQL user.
* Add stray "else" that seems to have gone missing.Robert Haas2010-06-24
|
* Deprecate the use of => as an operator name.Robert Haas2010-06-22
| | | | | | | | | | In HEAD, emit a warning when an operator named => is defined. In both HEAD and the backbranches (except in 8.2, where contrib modules do not have documentation), document that hstore's text => text operator may be removed in a future release, and encourage the use of the hstore(text, text) function instead. This function only exists in HEAD (previously, it was called tconvert), so backpatch it back to 8.2, when hstore was added. Per discussion.
* Fix mishandling of whole-row Vars referencing a view or sub-select.Tom Lane2010-06-21
| | | | | | | | If such a Var appeared within a nested sub-select, we failed to translate it correctly during pullup of the view, because the recursive call to replace_rte_variables_mutator was looking for the wrong sublevels_up value. Bug was introduced during the addition of the PlaceHolderVar mechanism. Per bug #5514 from Marcos Castedo.
* Clean up some randomness associated with trace_recovery_messages: don'tTom Lane2010-06-17
| | | | | put the variable declaration in the middle of a bunch of externs, and do use extern where it should be used.
* Make RemoveOldXlogFiles's debug printout match style used elsewhere:Tom Lane2010-06-17
| | | | | log and seg aren't an XLogRecPtr and shouldn't be printed like one. Fujii Masao
* Don't allow walsender to send WAL data until it's been safely fsync'd on theTom Lane2010-06-17
| | | | | | | | master. Otherwise a subsequent crash could cause the master to lose WAL that has already been applied on the slave, resulting in the slave being out of sync and soon corrupt. Per recent discussion and an example from Robert Haas. Fujii Masao
* Refactor sprintf calls with computed format strings into multiple calls withPeter Eisentraut2010-06-16
| | | | | constant format strings, so that the compiler can more easily check the formats for correctness.
* Add new GUC categories corresponding to sections in docs, and moveItagaki Takahiro2010-06-15
| | | | | | | description for vacuum_defer_cleanup_age to the correct category. Sections in postgresql.conf are also sorted in the same order with docs. Per gripe by Fujii Masao, suggestion by Heikki Linnakangas, and patch by me.
* If a corrupt WAL record is received by streaming replication, disconnectHeikki Linnakangas2010-06-14
| | | | | | | and retry. If the record is genuinely corrupt in the master database, there's little hope of recovering, but it's better than simply retrying to apply the corrupt WAL record in a tight loop without even trying to retransmit it, which is what we used to do.
* Remove max_standby_delay message from ps display of recovery processItagaki Takahiro2010-06-14
| | | | | in waiting status. The parameter is not so interesting in ps display because it is referable in postgresql.conf.
* Fix ALTER LARGE OBJECT and GRANT ... ON LARGE OBJECT for large OIDs.Robert Haas2010-06-13
| | | | | The previous coding failed for OIDs too large to be represented by a signed integer.
* Fix typo/bug, found by Clang compilerPeter Eisentraut2010-06-12
|
* Use "replication" as the database name when constructing a connectionHeikki Linnakangas2010-06-11
| | | | | | | | string for a streaming replication connection. It's ignored by the server, but allows libpq to pick up the password from .pgpass where "replication" is specified as the database name. Patch by Fujii Masao per Tom's suggestion, with some wording changes by me.
* Rename restartpoint_command to archive_cleanup_command.Itagaki Takahiro2010-06-10
|