aboutsummaryrefslogtreecommitdiff
path: root/src/backend
Commit message (Collapse)AuthorAge
* Fix synonym-dict breakage introduced in last patch :-(.Tom Lane2007-08-25
| | | | Minor other cleanups.
* Rename built-in Snowball stemmer dictionaries to be english_stem,Tom Lane2007-08-25
| | | | russian_stem, etc. Per discussion.
* Cleanup for some problems in tsearch patch:Tom Lane2007-08-25
| | | | | | | | | | | | | | - ispell initialization crashed on empty dictionary file - ispell initialization crashed on affix file with prefixes but no suffixes - stop words file was run through pg_verify_mbstr, with database encoding, but it's supposed to be UTF-8; similar bug for synonym files - bunch of comments added, typos fixed, and other cleanup Introduced consistent encoding checking/conversion of data read from tsearch configuration files, by doing this in a single t_readline() subroutine (replacing direct usages of fgets). Cleaned up API for readstopwords too. Heikki Linnakangas
* Reduce memory requirements for writing CSVlogs, so it will work with aboutAndrew Dunstan2007-08-23
| | | | the same amount of memory in ErrorContext as standard logs.
* Suppress testing the options of CREATE TEXT SEARCH DICTIONARY duringTom Lane2007-08-22
| | | | | initdb. We should create all the standard dictionaries even though some of them may not work in template1's encoding. Per Teodor.
* Fix VPATH-build problem in new tsearch makefile, per Chad Wagner.Tom Lane2007-08-22
|
* Remove option to change parser of an existing text search configuration.Tom Lane2007-08-22
| | | | | | This prevents needing to do complex and poorly-defined updates of the mapping table if the new parser has different token types than the old. Per discussion.
* Whoops, missed updating dsynonym_init for new dictionary parameter method.Tom Lane2007-08-22
|
* Simplify the syntax of CREATE/ALTER TEXT SEARCH DICTIONARY by treating theTom Lane2007-08-22
| | | | | | | | | | | | init options of the template as top-level options in the syntax. This also makes ALTER a bit easier to use, since options can be replaced individually. I also made these statements verify that the tmplinit method will accept the new settings before they get stored; in the original coding you didn't find out about mistakes until the dictionary got invoked. Under the hood, init methods now get options as a List of DefElem instead of a raw text string --- that lets tsearch use existing options-pushing code instead of duplicating functionality.
* Simplify CREATE TEXT SEARCH CONFIGURATION by eliminating the separateTom Lane2007-08-21
| | | | | | | | | 'with map' parameter; as things now stand there's really not much point in specifying a config-to-copy if you don't copy its map. Also, use COPY instead of TEMPLATE as the key word for a config-to-copy, so as to avoid confusion with text search templates. Per discussion; the just-committed reference page for the command already describes it this way.
* Avoid using TEXT as a Bison symbol, since this provokes warnings onTom Lane2007-08-21
| | | | | Windows builds. In passing, fix an obsolete comment, per gripe from Greg Stark.
* Remove extraneous semicolon --- buildfarm member bear, for one,Tom Lane2007-08-21
| | | | objects to it.
* Fix cash_mul_int4 and cash_div_int4 for overenthusiastic substitutionTom Lane2007-08-21
| | | | of int64 for int32. Per reports from Merlin Moncure and Andrew Chernow.
* Fix money type's send/receive functions to conform to recent wideningTom Lane2007-08-21
| | | | of the datatype to int64. Per Andrew Chernow.
* Fix potential access-off-the-end-of-memory in varbit_out(): it fetched theTom Lane2007-08-21
| | | | | | byte after the last full byte of the bit array, regardless of whether that byte was part of the valid data or not. Found by buildfarm testing. Thanks to Stefan Kaltenbrunner for nailing down the cause.
* Suppress uninitialized-variable warning.Tom Lane2007-08-21
|
* Fix a small 64-bit problem in tsearch patch.Tom Lane2007-08-21
|
* Tsearch2 functionality migrates to core. The bulk of this work is byTom Lane2007-08-21
| | | | | | | | Oleg Bartunov and Teodor Sigaev, but I did a lot of editorializing, so anything that's broken is probably my fault. Documentation is nonexistent as yet, but let's land the patch so we can get some portability testing done.
* Provide for logfiles in machine readable CSV format. In consequence, renameAndrew Dunstan2007-08-19
| | | | | | redirect_stderr to logging_collector. Original patch from Arul Shaji, subsequently modified by Greg Smith, and then heavily modified by me.
* Arrange to cache a ResultRelInfo in the executor's EState for relations thatTom Lane2007-08-15
| | | | | | | | | | | | | are not one of the query's defined result relations, but nonetheless have triggers fired against them while the query is active. This was formerly impossible but can now occur because of my recent patch to fix the firing order for RI triggers. Caching a ResultRelInfo avoids duplicating work by repeatedly opening and closing the same relation, and also allows EXPLAIN ANALYZE to "see" and report on these extra triggers. Use the same mechanism to cache open relations when firing deferred triggers at transaction shutdown; this replaces the former one-element-cache strategy used in that case, and should improve performance a bit when there are deferred triggers on a number of relations.
* Repair problems occurring when multiple RI updates have to be done to the sameTom Lane2007-08-15
| | | | | | | | | row within one query: we were firing check triggers before all the updates were done, leading to bogus failures. Fix by making the triggers queued by an RI update go at the end of the outer query's trigger event list, thereby effectively making the processing "breadth-first". This was indeed how it worked pre-8.0, so the bug does not occur in the 7.x branches. Per report from Pavel Stehule.
* Fix oversight in async-commit patch: there were some places in heapam.cTom Lane2007-08-14
| | | | | | that still thought they could set HEAP_XMAX_COMMITTED immediately after seeing the other transaction commit. Make them use the same logic as tqual.c does to determine if the hint bit can be set yet.
* TEMPORARILY make synchronous_commit default to OFF, so that we can get moreTom Lane2007-08-13
| | | | | thorough testing of async-commit mode from the buildfarm. This patch MUST get reverted before 8.3 release!
* Fix two bugs induced in VACUUM FULL by async-commit patch.Tom Lane2007-08-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | First, we cannot assume that XLogAsyncCommitFlush guarantees hint bits will be settable, because clog.c's inexact LSN bookkeeping results in windows where a previously flushed transaction is considered unhintable because it shares an LSN slot with a later unflushed transaction. But repair_frag requires XMIN_COMMITTED to be correct so that it can distinguish tuples moved by the current vacuum. Since not being able to set the bit is an uncommon corner case, the most practical way of dealing with it seems to be to abandon shrinking (ie, don't invoke repair_frag) when we find a non-dead tuple whose XMIN_COMMITTED bit couldn't be set. Second, it is possible for the same reason that a RECENTLY_DEAD tuple does not get its XMAX_COMMITTED bit set during scan_heap. But by the time repair_frag examines the tuple it might be possible to set the bit. We therefore must take buffer content lock when calling HeapTupleSatisfiesVacuum a second time, else we can get an Assert failure in SetBufferCommitInfoNeedsSave. This latter bug is latent in existing releases, but I think it cannot actually occur without async commit, since the first HeapTupleSatisfiesVacuum call should always have set the bit. So I'm not going to back-patch it. In passing, reduce the existing "cannot shrink relation" messages from NOTICE to LOG level. The new message must be no higher than LOG if we don't want unpredictable regression test failures, and consistency seems like a good idea. Also arrange that only one such message is reported per VACUUM FULL; in typical scenarios you could get spammed with many such messages, which seems a bit useless.
* Remove an "optimization" I installed in 2001, to make repalloc() attempt toTom Lane2007-08-12
| | | | | | | | | | | | enlarge the memory chunk in-place when it was feasible to do so. This turns out to not work well at all for scenarios involving repeated cycles of palloc/repalloc/pfree: the eventually freed chunks go into the wrong freelist for the next initial palloc request, and so we consume memory indefinitely. While that could be defended against, the number of cases where the optimization can still be applied drops significantly, and adjusting the initial sizes of StringInfo buffers makes it drop to almost nothing. Seems better to just remove the extra complexity. Per recent discussion and testing.
* Increase the initial size of StringInfo buffers to 1024 bytes (from 256);Tom Lane2007-08-12
| | | | | | | | | likewise increase the initial size of the scanner's literal buffer to 1024 (from 128). Instrumentation of the regression tests suggests that this saves a useful amount of repalloc() traffic --- the number of calls occurring during one set of tests drops from about 6900 to about 3900. The old sizes were chosen in the late 90's with an eye to machines much smaller than are common today.
* Avoid memory leakage across successive calls of regexp_matches() orTom Lane2007-08-11
| | | | | | | regexp_split_to_table() within a single query. This is only a partial solution, as it turns out that with enough matches per string these functions can also tickle a repalloc() misbehavior. But fixing that is a topic for a separate patch.
* Code review for regexp_matches/regexp_split patch. Refactor to avoid assumingTom Lane2007-08-11
| | | | | | | | | that cached compiled patterns will still be there when the function is next called. Clean up looping logic, thereby fixing bug identified by Pavel Stehule. Share setup code between the two functions, add some comments, and avoid risky mixing of int and size_t variables. Clean up the documentation a tad, and accept all the flag characters mentioned in table 9-19 rather than just a subset.
* Revise postmaster startup/shutdown logic to eliminate the problem that aTom Lane2007-08-09
| | | | | | | | | | | | | | | | constant flow of new connection requests could prevent the postmaster from completing a shutdown or crash restart. This is done by labeling child processes that are "dead ends", that is, we know that they were launched only to tell a client that it can't connect. These processes are managed separately so that they don't confuse us into thinking that we can't advance to the next stage of a shutdown or restart sequence, until the very end where we must wait for them to drain out so we can delete the shmem segment. Per discussion of a misbehavior reported by Keaton Adams. Since this code was baroque already, and my first attempt at fixing the problem made it entirely impenetrable, I took the opportunity to rewrite it in a state-machine style. That eliminates some duplicated code sections and hopefully makes everything a bit clearer.
* Fix a gradual memory leak in ExecReScanAgg(). Because the aggregationNeil Conway2007-08-08
| | | | | | | | | | | | hash table is allocated in a child context of the agg node's memory context, MemoryContextReset() will reset but *not* delete the child context. Since ExecReScanAgg() proceeds to build a new hash table from scratch (in a new sub-context), this results in leaking the header for the previous memory context. Therefore, use MemoryContextResetAndDeleteChildren() instead. Credit: My colleague Sailesh Krishnamurthy at Truviso for isolating the cause of the leak.
* Fix thinko in multi-autovac-workers code: validity checks made byTom Lane2007-08-08
| | | | GUC assign hooks are supposed to be made whether doit is true or not.
* Adjust the output of MemoryContextStats() so that the stats for aNeil Conway2007-08-07
| | | | | | child memory contexts is indented two spaces to the right of its parent context. This should make it easier to deduce the memory context hierarchy from the output of MemoryContextStats().
* Fix up bad layout of some comments (probably pg_indent's fault), andTom Lane2007-08-04
| | | | improve grammar a tad. Per Greg Stark.
* Fix crash caused by log_timezone patch if we attempt to emit any elog messagesTom Lane2007-08-04
| | | | | | | | | between the setting of log_line_prefix and the setting of log_timezone. We can't realistically set log_timezone any earlier than we do now, so the best behavior seems to be to use GMT zone if any timestamps are to be logged during early startup. Create a dummy zone variable with a minimal definition of GMT (in particular it will never know about leap seconds), so that we can set it up without reference to any external files.
* Fix a problem in my recent patch to initialize cancel_key for autovac workersTom Lane2007-08-04
| | | | | | | | as well as regular backends: if no regular backend launches before the autovac launcher tries to start an autovac worker, the postmaster would get an Assert fault due to calling PostmasterRandom before random_seed was initialized. Cleanest solution seems to be to take the initialization of random_seed out of ServerLoop and let PostmasterRandom do it for itself.
* Switch over to using the src/timezone functions for formatting timestampsTom Lane2007-08-04
| | | | | | | | | | | | | | displayed in the postmaster log. This avoids Windows-specific problems with localized time zone names that are in the wrong encoding, and generally seems like a good idea to forestall other potential platform-dependent issues. To preserve the existing behavior that all backends will log in the same time zone, create a new GUC variable log_timezone that can only be changed on a system-wide basis, and reference log-related calculations to that zone instead of the TimeZone variable. This fixes the issue reported by Hiroshi Saito that timestamps printed by xlog.c startup could be improperly localized on Windows. We still need a simpler patch for that problem in the back branches, however.
* Fix some sloppiness in the recent multiple-autovacuum-worker patch. It wasTom Lane2007-08-03
| | | | | | | | not bothering to initialize is_autovacuum for regular backends, meaning there was a significant chance of the postmaster prematurely sending them SIGTERM during database shutdown. Also, leaving the cancel key unset for an autovac worker meant that any client could send it SIGINT, which doesn't sound especially good either.
* Move session_start out of MyProcPort stucture and make it a global called ↵Andrew Dunstan2007-08-02
| | | | | | | | MyStartTime, so that we will be able to create a cookie for all processes for CSVlogs. It is set wherever MyProcPid is set. Take the opportunity to remove the now unnecessary session-only restriction on the %s and %c escapes in log_line_prefix.
* Make sure syslogPipe runs in binary mode on Windows to avoid corrupting the ↵Andrew Dunstan2007-08-02
| | | | pipe chunking protocol. Backport to 8.0
* Fix a memory leak in tuplestore_end(). Unlikely to be significant duringNeil Conway2007-08-02
| | | | normal operation, but tuplestore_end() ought to do what it claims to do.
* Support an optional asynchronous commit mode, in which we don't flush WALTom Lane2007-08-01
| | | | | | before reporting a transaction committed. Data consistency is still guaranteed (unlike setting fsync = off), but a crash may lose the effects of the last few transactions. Patch by Simon, some editorialization by Tom.
* If we're gonna use ExecRelationIsTargetRelation here, might as wellTom Lane2007-07-31
| | | | simplify a bit further.
* Fix security definer functions with polymorphic arguments. This case hasTom Lane2007-07-31
| | | | | never worked because fmgr_security_definer() neglected to pass the fn_expr information through. Per report from Viatcheslav Kalinin.
* Slight refactor for ExecOpenScanRelation(): we can useNeil Conway2007-07-27
| | | | | ExecRelationIsTargetRelation() to check if the relation is a target rel, rather than scanning through the result relation array ourselves.
* Remove FileUnlink(), which wasn't being used anywhere and interacted poorlyTom Lane2007-07-26
| | | | | | with the recent patch to log temp file sizes at removal time. Doesn't seem worth fixing since it's unused. In passing, make a few elog messages conform to the message style guide.
* Arrange to put TOAST tables belonging to temporary tables into special schemasTom Lane2007-07-25
| | | | | | | | | | | | | | named pg_toast_temp_nnn, alongside the pg_temp_nnn schemas used for the temp tables themselves. This allows low-level code such as the relcache to recognize that these tables are indeed temporary, which enables various optimizations such as not WAL-logging changes and using local rather than shared buffers for access. Aside from obvious performance benefits, this provides a solution to bug #3483, in which other backends unexpectedly held open file references to temporary tables. The scheme preserves the property that TOAST tables are not in any schema that's normally in the search path, so they don't conflict with user table names. initdb forced because of changes in system view definitions.
* Suppress warning when compiling with -DPROFILE_PID_DIR: sys/stat.h isTom Lane2007-07-25
| | | | supposed to be included when using mkdir().
* Rename DLLIMPORT macro to PGDLLIMPORT to avoid conflict withMagnus Hagander2007-07-25
| | | | third party includes (like tcl) that define DLLIMPORT.
* Fix predicate-proving logic to cope with binary-compatibility cases whenTom Lane2007-07-24
| | | | | | checking whether an IS NULL/IS NOT NULL clause is implied or refuted by a strict function. Per example from Dawid Kuroczko. Backpatch to 8.2 since this is arguably a performance bug.
* Silence compiler warning on mingwMagnus Hagander2007-07-24
|
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-03 12:05:18 +0000