| Commit message (Collapse) | Author | Age |
|
|
|
| |
Merlin Moncure
|
| |
|
|
|
|
|
|
|
|
|
| |
(in particular, causing the ReadyForQuery message to be eaten) before
returning from do_copy. The only known consequence of failing to do so is
that get_prompt might show a wrong result for the %x transaction status
escape, as reported by Bernd Helmle; but it's possible there are other issues.
Back-patch as far as 7.4, the oldest version supporting %x.
|
|
|
|
|
|
| |
cause any serious harm in normal cases, but if you have gcc buffer overrun
checking turned on, that will notice. Found by Jack Orenstein. Problem
was already fixed in CVS HEAD.
|
|
|
|
|
|
|
| |
Formerly they'd emit '^foo|bar$' which is wrong because the anchors are
parsed as part of the alternatives; must emit '^(foo|bar)$' to get expected
behavior. Same as bug found previously in similar_escape(). Already fixed
in HEAD, this is just back-porting the part of that patch that was a bug fix.
|
|
|
|
|
|
| |
quote chars inside quote marks, should emit one quote *and stay in inquotes
mode*. No doubt the lack of reports of this have something to do with the
poor documentation of the feature ...
|
|
|
|
|
|
| |
opposed to what other versions apparently do, so it's not safe to print an
error message. Besides, getopt_long itself already did, so it's redundant
anyway.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
parser will allow "\'" to be used to represent a literal quote mark. The
"\'" representation has been deprecated for some time in favor of the
SQL-standard representation "''" (two single quote marks), but it has been
used often enough that just disallowing it immediately won't do. Hence
backslash_quote allows the settings "on", "off", and "safe_encoding",
the last meaning to allow "\'" only if client_encoding is a valid server
encoding. That is now the default, and the reason is that in encodings
such as SJIS that allow 0x5c (ASCII backslash) to be the last byte of a
multibyte character, accepting "\'" allows SQL-injection attacks as per
CVE-2006-2314 (further details will be published after release). The
"on" setting is available for backward compatibility, but it must not be
used with clients that are exposed to untrusted input.
Thanks to Akio Ishida and Yasuo Ohgaki for identifying this security issue.
|
|
|
|
| |
and 8.0. Later releases already patched.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
/dev/tty, but it isn't a device file and doesn't work as expected.
This fixes a known bug where psql does not prompt for a password on some
Win32 systems.
Backpatch to 8.0.X too.
Robert Kinberg
|
|
|
|
| |
and supply real fix for problem it tried to address.
|
| |
|
|
|
|
|
|
|
| |
after an error in a COPY statement. Formerly it thought the COPY data
was SQL commands, and got quite confused.
Stephen Frost
|
|
|
|
| |
by Magnus Hagander
|
|
|
|
|
|
| |
operator names. This is needed when dumping operator definitions that have
COMMUTATOR (or similar) links to operators in other schemas.
Apparently Daniel Whitter is the first person ever to try this :-(
|
|
|
|
| |
per http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=343616 via Martin Pitt.
|
|
|
|
|
| |
are inconsistent with the rest of the .po files, and apparently cause
problems for Sun's cc. Per report on IRC from "bitvector2".
|
| |
|
|
|
|
|
| |
so as to avoid performance issues and possible ultimate crash on long
psql scripts. Per Merlin Moncure.
|
| |
|
|
|
|
| |
Backpatch to 8.0.X.
|
|
|
|
|
|
|
| |
really the source or destination of the archive. I think this will
resolve recent complaints that password prompting is broken in pg_restore
on Windows. Note that password prompting and reading from stdin is an
unworkable combination on Windows ... but that was true anyway.
|
|
|
|
| |
no database has been explicitly specified. Per gripe from Omar Kilani.
|
| |
|
|
|
|
|
|
|
|
|
| |
name matches the name of any parent-table constraint, without looking
at the constraint text. This is a not-very-bulletproof workaround for
the problem exhibited by Berend Tober last month. We really ought to
record constraint inheritance status in pg_constraint, but it's looking
like that may not get done for 8.1 --- and even if it does, we will
need this kluge for dumping from older servers.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1) The code doesn't initialize `sum', so the initial "does the checksum
match?" test is wrong.
(2) The loop that is intended to check for a "null block" just checks
the first byte of the tar block 512 times, rather than each of the
512 bytes one time (!), which I'm guessing was the intent.
It was only through sheer luck that this worked in the first place.
Per Coverity static analysis performed by EnterpriseDB.
|
| |
|
|
|
|
| |
not schema-safe. Per report from Jochem van Dieten.
|
| |
|
|
|
|
| |
Per report from Brian Hackett.
|
|
|
|
| |
so that restart doesn't fail when old postmaster died unbetimes.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a warning when a variable is used as a format string for printf()
and similar functions (if the variable is derived from untrusted
data, it could include unexpected formatting sequences). This
emits too many warnings to be enabled by default, but it does
flag a few dubious constructs in the Postgres tree. This patch
fixes up the obvious variants: functions that are passed a variable
format string but no additional arguments.
Most of these are harmless (e.g. the ruleutils stuff), but there
is at least one actual bug here: if you create a trigger named
"%sfoo", pg_dump will read uninitialized memory and fail to dump
the trigger correctly.
|
|
|
|
|
| |
incorrect -F argument: write_msg() expects its first parameter to be a
"module name", not the format string.
|
| |
|
|
|
|
| |
Reorder MSC makefile to be more consistent and easier to maintain.
|
|
|
|
| |
postmaster.pid still represents a live postmaster.
|
|
|
|
|
| |
than simply passing it down to pg_dump. Else, version-related failures
in pg_dumpall itself generate unhelpful error messages.
|
|
|
|
|
|
|
|
| |
which induced bug #1597 in addition to having several other misbehaviors
(like labeling the dump with a completion time having nothing to do with
reality). Instead just print out the desired strings where RestoreArchive
was already emitting the 'PostgreSQL database dump' and
'PostgreSQL database dump complete' strings.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
immunte to changes in libpq's usage of pgport between major versions.
Backpatch to 8.0.X.
|
|
|
|
| |
it's supposed to when --file option is used.
|
| |
|
|
|
|
|
| |
database: aggregates should be dumped in the same pass as operators,
not in the same pass as functions.
|
| |
|
|
|
|
|
| |
Solaris and should be a little faster anyway, since in most scenarios
all but perhaps the last path component will already exist.
|