aboutsummaryrefslogtreecommitdiff
path: root/src/interfaces
Commit message (Collapse)AuthorAge
* Added some more coverity report patches send in by Joachim Wieland ↵Michael Meskes2006-06-26
| | | | <joe@mcknight.de>.
* Moved some free() calls that coverity correctly complains about.Michael Meskes2006-06-25
|
* Remove individual user copyright because the code is contributed toBruce Momjian2006-06-25
| | | | | | | | | PGDG: > Yes. In fact the copyright belongs to credativ GmbH the company that > paid Carsten for his work. As you may or may not know I'm the CEO of > that company and can assure you that his work was contributed to the > PostgreSQL project.
* Clarified copyright noticeMichael Meskes2006-06-23
|
* Added some more coverity report patches send in by Martijn van Oosterhout ↵Michael Meskes2006-06-21
| | | | <kleptog@svana.org>.
* Fixed small typo in changelogMichael Meskes2006-06-21
|
* Added fixed from the coverity report send in by Joachim Wieland ↵Michael Meskes2006-06-21
| | | | | | <joe@mcknight.de> Added missing error handling in a few functions in ecpglib
* Split definitions for md5.c out of crypt.h and into their own headerTom Lane2006-06-20
| | | | | | | | | libpq/md5.h, so that there's a clear separation between backend-only definitions and shared frontend/backend definitions. (Turns out this is reversing a bad decision from some years ago...) Fix up references to crypt.h as needed. I looked into moving the code into src/port, but the headers in src/include/libpq are sufficiently intertwined that it seems more work than it's worth to do that.
* Do not use already free'ed errmsg, bug found by Joachim WielandMichael Meskes2006-06-19
| | | | <joachim.wieland@credativ.de>
* Further thoughts about lo_export/lo_import error handling: if one ofTom Lane2006-06-14
| | | | | | | the lower-level large object functions fails, it will have already set a suitable error message --- probably something from the backend --- and it is not useful to overwrite that with a generic 'error while reading large object' message. So remove redundant messages.
* Improve error detection and recovery in lo_import()/lo_export().Tom Lane2006-06-14
| | | | Problems noted while experimenting with new control-C code for psql.
* Prepare code to be built by MSVC:Bruce Momjian2006-06-07
| | | | | | | | | | o remove many WIN32_CLIENT_ONLY defines o add WIN32_ONLY_COMPILER define o add 3rd argument to open() for portability o add include/port/win32_msvc directory for system includes Magnus Hagander
* Have BCC echo output "" using "", rather than \"\" as earlier reported.Bruce Momjian2006-06-06
| | | | Backpatch to 8.1.X.
* Fixed two more memory leaks in ecpglib.Michael Meskes2006-06-06
| | | | Synced parser.
* Somehow a ";" got lost which changed the logic. This btw is the first fix ↵Michael Meskes2006-05-31
| | | | resulting from SoC.
* Remove pqsignalinquire(), which is unused and has portability issues.Tom Lane2006-05-30
|
* enlargePQExpBuffer, alone among the functions exported by pqexpbuffer.h,Tom Lane2006-05-28
| | | | wasn't exported by exports.txt. Ooops. Per buildfarm results.
* Fix up pg_dump to do string escaping fully correctly for client encodingTom Lane2006-05-28
| | | | | | | | | and standard_conforming_strings; likewise for the other client programs that need it. As per previous discussion, a pg_dump dump now conforms to the standard_conforming_strings setting of the source database. We don't use E'' syntax in the dump, thereby improving portability of the SQL. I added a SET escape_strings_warning = off command to keep the dumps from getting a lot of back-chatter from that.
* Don't call PQclear until the struct is really no longer going to be used.Alvaro Herrera2006-05-28
| | | | | | | Per Coverity bug #304. Thanks to Martijn van Oosterhout for reporting it. Zero out the pointer fields of PGresult so that these mistakes are more easily catched, per discussion.
* Use E'' strings internally only when standard_conforming_strings =Bruce Momjian2006-05-26
| | | | | | | | | 'off'. This allows pg_dump output with standard_conforming_strings = 'on' to generate proper strings that can be loaded into other databases without the backslash doubling we typically do. I have added the dumping of the standard_conforming_strings value to pg_dump. I also added standard backslash handling for plpgsql.
* Remove trailing blank line from exports.txt.Bruce Momjian2006-05-23
|
* Add PQisthreadsafe() to libpq, to allow library applications to queryBruce Momjian2006-05-23
| | | | the thread-safety status of the library.
* Avoid duplicate definition of LOCALEDIR in pg_config.h, already definedBruce Momjian2006-05-23
| | | | in port/pg_config_paths.h.
* Modify libpq's string-escaping routines to be aware of encoding considerationsTom Lane2006-05-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and standard_conforming_strings. The encoding changes are needed for proper escaping in multibyte encodings, as per the SQL-injection vulnerabilities noted in CVE-2006-2313 and CVE-2006-2314. Concurrent fixes are being applied to the server to ensure that it rejects queries that may have been corrupted by attempted SQL injection, but this merely guarantees that unpatched clients will fail rather than allow injection. An actual fix requires changing the client-side code. While at it we have also fixed these routines to understand about standard_conforming_strings, so that the upcoming changeover to SQL-spec string syntax can be somewhat transparent to client code. Since the existing API of PQescapeString and PQescapeBytea provides no way to inform them which settings are in use, these functions are now deprecated in favor of new functions PQescapeStringConn and PQescapeByteaConn. The new functions take the PGconn to which the string will be sent as an additional parameter, and look inside the connection structure to determine what to do. So as to provide some functionality for clients using the old functions, libpq stores the latest encoding and standard_conforming_strings values received from the backend in static variables, and the old functions consult these variables. This will work reliably in clients using only one Postgres connection at a time, or even multiple connections if they all use the same encoding and string syntax settings; which should cover many practical scenarios. Clients that use homebrew escaping methods, such as PHP's addslashes() function or even hardwired regexp substitution, will require extra effort to fix :-(. It is strongly recommended that such code be replaced by use of PQescapeStringConn/PQescapeByteaConn if at all feasible.
* Fix typo in comment.Alvaro Herrera2006-05-19
|
* Code alignment fix.Bruce Momjian2006-05-18
|
* Remove canonicalize_path() call for .pgpass socket directory comparison;Bruce Momjian2006-05-18
| | | | not worth adding path.c to libpq.
* Allow the .pgpass hostname to match the default socket directory, asBruce Momjian2006-05-17
| | | | well as a blank pghost.
* Fix typo in comment.Bruce Momjian2006-05-11
|
* Use SQL standard '' rather than \' for tutorial/sample code.Bruce Momjian2006-05-11
| | | | Backpatch to 8.1.X.
* Code review for standard_conforming_strings patch. Fix it so it does notTom Lane2006-05-11
| | | | | | | throw warnings for 100%-SQL-standard constructs, clean up some minor infelicities, try to un-break ecpg to the best of my ability. (It's not clear how ecpg is going to find out the setting of standard_conforming_strings, though.) I think pg_dump still needs work, too.
* Use $(LIBS:-lpgport=) rather than $(patsubst -lpgport,, $(LIBS)), for ↵Bruce Momjian2006-05-07
| | | | consistency.
* Add SSL CRL support to libpq. Recently added to the backend.Bruce Momjian2006-05-06
|
* We only need to add thread.c on non-WIN32 platforms, since get_home_pathTom Lane2006-04-29
| | | | | doesn't use pqGetpwuid on WIN32. Rather than try to figure out why it won't build on WIN32, just remove it.
* Arrange to strip libpq.so of symbols that aren't officially supposed toTom Lane2006-04-28
| | | | | | | | be exported on Linux and Darwin. We already did this on Windows but that's not enough, as evidenced by the fact that libecpg had an unexpected dependency on one such symbol. We should try to do it on more platforms. Fix ecpg's oversight, and bump libpq's major .so version number to reflect the unwanted but nonetheless real ABI break.
* Tab alignment cleanup.Bruce Momjian2006-04-27
|
* Add underscores to SSL CERT macro names, for clarity and consistencyBruce Momjian2006-04-27
| | | | with be-secure.c.
* Change libpq's PQgetssl() to return a void*, rather than SSL *, so thatBruce Momjian2006-04-27
| | | | | | applications don't need the SSL headers. Martijn van Oosterhout
* Remove unused function SSL_CTX_set_tmp_dh_callback() from libpq:Bruce Momjian2006-04-27
| | | | | | | | | | | | | | | | | | | | | | | In the SSL code in libpq it does some processing with DH parameters: SSL_CTX_set_tmp_dh_callback() This function is marked as server use only[1], the client always uses the DH parameters in the server, so all the code in the client dealing with the DH parameters is useless. This patch removes it. It's not clear why the code was added in the first place, it's been there almost since the beginning[2]. At the time there was a suggestion of merging the front-end and backend SSL code, but looking at the changes since, that seems unlikely. As a further example, the s_server program allows you to specify DH params, but s_client doesn't. In the GnuTLS documentation under gnutls_dh_params_generate2() it says[3]: Also note that the DH parameters are only useful to servers. Since clients use the parameters sent by the server, it's of no use to call this in client side.
* Back out RESET CONNECTION until there is more discussion.Bruce Momjian2006-04-25
|
* Add RESET CONNECTION, to reset all aspects of a session.Bruce Momjian2006-04-25
| | | | Hans-J?rgen Sch?nig
* Fixed memory leak bugs found by Martijn Oosterhout.Michael Meskes2006-04-24
|
* Fixes for BCC 5.5 compile of libpq. Backpatch to 8.1.X.Bruce Momjian2006-04-24
| | | | Mark Morgan Lloyd
* Fix ancient memory leak in PQprintTuples(); our code no longer uses thisTom Lane2006-04-19
| | | | | routine, but perhaps some applications do. Found by Martijn van Oosterhout using Coverity.
* Fix typo.Neil Conway2006-04-11
|
* Add comment for why we recompile pgport C files.Bruce Momjian2006-04-09
| | | | | | | # Need to recomple any libpgport object files because we need these # object files to use the same compile flags as libpq. If we used # the object files from libpgport, this would not be true on all # platforms.
* Update comment that pgNotify.be_pid is pid of the notifying server process.Bruce Momjian2006-03-20
|
* Fixed bug 2330: Wrong error code in case of a duplicate keyMichael Meskes2006-03-17
|
* Improve parser so that we can show an error cursor position for errorsTom Lane2006-03-14
| | | | | | | | | | | during parse analysis, not only errors detected in the flex/bison stages. This is per my earlier proposal. This commit includes all the basic infrastructure, but locations are only tracked and reported for errors involving column references, function calls, and operators. More could be done later but this seems like a good set to start with. I've also moved the ReportSyntaxErrorPosition logic out of psql and into libpq, which should make it available to more people --- even within psql this is an improvement because warnings weren't handled by ReportSyntaxErrorPosition.
* Remove Christof Petig copyright. He already approved removal from anBruce Momjian2006-03-11
| | | | include file in the same area,.