aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* Adjust documentation with respect to "unknown" timezone setting.Tom Lane2011-05-10
| | | | | | The recent cleanup of GUC assign hooks got rid of the kludge of using "unknown" as a magic value for timezone and log_timezone. But I forgot to update the documentation to match, as noted by Martin Pitt.
* Be more wary in initdb's creation of platform-dependent collations.Tom Lane2011-05-10
| | | | | | | | | | | Discard any collation aliases that match the built-in pg_collation entries (ie, "default", "C", "POSIX"). Such aliases would be refused by a CREATE COLLATION command, but since initdb is injecting them via a simple INSERT, it has to make the corresponding check for itself. Per Martin Pitt's report of funny behavior in a machine that had a bogus "C.UTF-8" locale. Also, use E'' syntax for the output of escape_quotes, as per its header comment.
* Remove "make check" target in src/test/isolation/Makefile.Tom Lane2011-05-09
| | | | | | | | | | This doesn't work as expected because the isolationtester program requires libpq to already be installed. While it works when you've already installed libpq, having to already have done "make install" defeats most of the point of a check with a temp installation. And there are weird corner cases if the dynamic linker picks up an old libpq.so from system library directories. Remove the target (or more precisely, make it print a helpful message) so people don't expect the case to work.
* Add C comment about the fact that the autovacuum limit can go backwardsBruce Momjian2011-05-08
| | | | by 3, but that is it OK.
* Fix some portability issues in isolation regression test driver.Tom Lane2011-05-08
| | | | | | | | | | Remove random system #includes in favor of using postgres_fe.h. (The alternative to that is letting this module grow its own configuration testing ability...) Also fix the "make clean" target to actually clean things up. Per local testing.
* Add comment about memory reordering to PredicateLockTupleRowVersionLink.Robert Haas2011-05-06
| | | | Dan Ports, per head-scratching from Simon Riggs and myself.
* Move RegisterPredicateLockingXid() call to a safer place.Tom Lane2011-05-06
| | | | | | | | | | | | | | | | | | | The SSI patch inserted a call of RegisterPredicateLockingXid into GetNewTransactionId, which was a bad idea on a couple of grounds. First, it's not necessary to hold XidGenLock while manipulating that shared memory, and doing so is bad because XidGenLock is a high-contention lock that should be held for as short a time as possible. (Not to mention that it adds an entirely unnecessary deadlock hazard, since we must take SerializableXactHashLock as well.) Second, the specific place where it was put was between extending CLOG and advancing nextXid, which could result in unpleasant behavior in case of a failure there. Pull the call out to AssignTransactionId, which is much safer and arguably better from a modularity standpoint too. There is more work to do to clean up the failure-before-advancing-nextXid issue, but that is a separate change that will need to be back-patched. So for the moment I just want to make GetNewTransactionId look the same as it did in prior versions.
* Remove precedence labeling of keywords TRUE, FALSE, UNKNOWN, and ZONE.Tom Lane2011-05-05
| | | | | | | | | | | | | | | | These were labeled with precedences just to avoid attaching explicit precedences to the productions in which they were the last terminal symbol. Since a terminal symbol precedence marking can affect many other things too, it seems like better practice to attach precedence labels to the productions, and not mark the terminal symbols. Ideally we'd also remove the precedence attached to NULL_P, but it turns out that we are actually depending on that having a precedence higher than POSTFIXOP, else we get a shift/reduce conflict for postfix operators in b_expr. (Which more or less proves my point about these markings having a high risk of unexpected consequences.) For the moment, move NULL_P into the set of keywords grouped with IDENT, so that at least it will act similarly to non-keywords; and document the interaction.
* Unbreak the regression tests from my previous commitMagnus Hagander2011-05-05
|
* Clarify error message when attempting to create index on foreign tableMagnus Hagander2011-05-05
| | | | | Instead of just saying "is not a table", specifically state that indexes aren't supported on *foreign* tables.
* Remove redundant port number checkPeter Eisentraut2011-05-04
| | | | | pg_basebackup doesn't need to police the format of port numbers. libpq already does that.
* Message style cleanupPeter Eisentraut2011-05-04
|
* Fix alignment of --help outputPeter Eisentraut2011-05-04
| | | | Tabs replaced by spaces.
* Fix pull_up_sublinks' failure to handle nested pull-up opportunities.Tom Lane2011-05-02
| | | | | | | | | | | | | After finding an EXISTS or ANY sub-select that can be converted to a semi-join or anti-join, we should recurse into the body of the sub-select. This allows cases such as EXISTS-within-EXISTS to be optimized properly. The original coding would leave the lower sub-select as a SubLink, which is no better and often worse than what we can do with a join. Per example from Wayne Conrad. Back-patch to 8.4. There is a related issue in older versions' handling of pull_up_IN_clauses, but they're lame enough anyway about the whole area that it seems not worth the extra work to try to fix.
* Improve aset.c's space management in contexts with small maxBlockSize.Tom Lane2011-05-02
| | | | | | | | | | | | | | | | | The previous coding would allow requests up to half of maxBlockSize to be treated as "chunks", but when that actually did happen, we'd waste nearly half of the space in the malloc block containing the chunk, if no smaller requests came along to fill it. Avoid this scenario by limiting the maximum size of a chunk to 1/8th maxBlockSize, so that we can waste no more than 1/8th of the allocated space. This will not change the behavior at all for the default context size parameters (with large maxBlockSize), but it will change the behavior when using ALLOCSET_SMALL_MAXSIZE. In particular, there's no longer a need for spell.c to be overly concerned about the request size parameters it uses, so remove a rather unhelpful comment about that. Merlin Moncure, per an idea of Tom Lane's
* Catch errors in for loop in makefilePeter Eisentraut2011-05-02
| | | | Add "|| exit" so that the rule aborts when a command fails.
* Rewrite installation makefile rules without for loopsPeter Eisentraut2011-05-02
| | | | | | | | | | install-sh can install multiple files at once, so for loops are not necessary. This was already changed for the rest of the code some time ago, but pgxs.mk was apparently forgotten, and the obsolete coding style has now been copied to the PLs as well. This also fixes the problem that the for loops in question did not catch errors.
* Make CLUSTER lock the old table's toast table before copying data.Tom Lane2011-05-01
| | | | | | | | We must lock out autovacuuming of the old toast table before computing the OldestXmin horizon we will use. Otherwise, autovacuum could start on the toast table later, compute a later OldestXmin horizon, and remove as DEAD toast tuples that we still need (because we think their parent tuples are only RECENTLY_DEAD). Per further thought about bug #5998.
* Lowercase status labels in pg_stat_replication view.Bruce Momjian2011-04-29
|
* Remove special case for xmin == xmax in HeapTupleSatisfiesVacuum().Tom Lane2011-04-29
| | | | | | | | | | | | | | | | | | | | | | VACUUM was willing to remove a committed-dead tuple immediately if it was deleted by the same transaction that inserted it. The idea is that such a tuple could never have been visible to any other transaction, so we don't need to keep it around to satisfy MVCC snapshots. However, there was already an exception for tuples that are part of an update chain, and this exception created a problem: we might remove TOAST tuples (which are never part of an update chain) while their parent tuple stayed around (if it was part of an update chain). This didn't pose a problem for most things, since the parent tuple is indeed dead: no snapshot will ever consider it visible. But MVCC-safe CLUSTER had a problem, since it will try to copy RECENTLY_DEAD tuples to the new table. It then has to copy their TOAST data too, and would fail if VACUUM had already removed the toast tuples. Easiest fix is to get rid of the special case for xmin == xmax. This may delay reclaiming dead space for a little bit in some cases, but it's by far the most reliable way to fix the issue. Per bug #5998 from Mark Reid. Back-patch to 8.3, which is the oldest version with MVCC-safe CLUSTER.
* Rewrite pg_size_pretty() to avoid compiler bug.Tom Lane2011-04-29
| | | | | | | | Convert it to use successive shifts right instead of increasing a divisor. This is probably a tad more efficient than the original coding, and it's nicer-looking than the previous patch because we don't need a special case to avoid overflow in the last branch. But the real reason to do it is to avoid a Solaris compiler bug, as per results from buildfarm member moa.
* Use non-literal format for possibly non-standard strftime formats.Andrew Dunstan2011-04-28
| | | | | | Per recent -hackers discussion. The formats in question are %G and %V, and cause warnings on MinGW at least. We assume the ecpg application knows what it's doing if it passes these formats to the library.
* Add some casts to try to silence most of the remaining format warnings on ↵Andrew Dunstan2011-04-28
| | | | MinGW-W64.
* Use a macro variable PG_PRINTF_ATTRIBUTE for the style used for checking ↵Andrew Dunstan2011-04-28
| | | | | | | | | printf type functions. The style is set to "printf" for backwards compatibility everywhere except on Windows, where it is set to "gnu_printf", which eliminates hundreds of false error messages from modern versions of gcc arising from %m and %ll{d,u} formats.
* Tag 9.1beta1.REL9_1_BETA1Tom Lane2011-04-27
|
* Fix binary upgrade of altered typed tablesPeter Eisentraut2011-04-27
| | | | | | | Instead of dumping them as CREATE TABLE ... OF, dump them as normal tables with the usual special processing for dropped columns, and then attach them to the type afterward, using ALTER TABLE ... OF. This is analogous to the existing handling of inherited tables.
* Revert "Force use of "%I64d" format for 64 bit ints on MinGW."Andrew Dunstan2011-04-27
| | | | | | This reverts commit 52d01c2f52c462d29ae0fdfa44c3cae129148a6d. the UINT64_FORMAT bit broke the b uildfarm, so I'm reverting the whole thing pending further investigation.
* timeline is not needed in BaseBackup()Magnus Hagander2011-04-27
| | | | | | | | This code was accidentally part of the patch, it's only needed for the code that's for 9.2. Not needing the timeline also removes the need to call IDENTIFY_SYSTEM. Noted by Peter E.
* Fix array- and path-creating functions to ensure padding bytes are zeroes.Tom Lane2011-04-27
| | | | | | | | | | | | | | | | | | | | | | | | Per recent discussion, it's important for all computed datums (not only the results of input functions) to not contain any ill-defined (uninitialized) bits. Failing to ensure that can result in equal() reporting that semantically indistinguishable Consts are not equal, which in turn leads to bizarre and undesirable planner behavior, such as in a recent example from David Johnston. We might eventually try to fix this in a general manner by allowing datatypes to define identity-testing functions, but for now the path of least resistance is to expect datatypes to force all unused bits into consistent states. Per some testing by Noah Misch, array and path functions seem to be the only ones presenting risks at the moment, so I looked through all the functions in adt/array*.c and geo_ops.c and fixed them as necessary. In the array functions, the easiest/safest fix is to allocate result arrays with palloc0 instead of palloc. Possibly in future someone will want to look into whether we can just zero the padding bytes, but that looks too complex for a back-patchable fix. In the path functions, we already had a precedent in path_in for just zeroing the one known pad field, so duplicate that code as needed. Back-patch to all supported branches.
* Revert "Remove hard coded formats for INT64 and use configured settings ↵Andrew Dunstan2011-04-27
| | | | | | | | instead." This reverts commit 9b1508af8971c1627cda5bb65f5e9eddb9a1a55e. As requested by Tom.
* Remove hard coded formats for INT64 and use configured settings instead.Andrew Dunstan2011-04-27
|
* Force use of "%I64d" format for 64 bit ints on MinGW.Andrew Dunstan2011-04-27
| | | | | Both this and "%lld" work, but the compiler's format checking doesn't like "%lld", so we get all sorts of spurious warnings.
* Use an explicit format string to keep the compiler happy.Andrew Dunstan2011-04-27
|
* Rephrase some not-supported error messages in pg_hba.conf processing.Tom Lane2011-04-26
| | | | | | | | | | | | In a couple of places we said "not supported on this platform" for cases that aren't really platform-specific, but could depend on configuration options such as --with-openssl. Use "not supported by this build" instead, as that doesn't convey the impression that you can't fix it without moving to another OS; that's also more consistent with the wording used for an identical error case in guc.c. No back-patch, as the clarity gain is small enough to not be worth burdening translators with back-branch changes.
* Complain if pg_hba.conf contains "hostssl" but SSL is disabled.Tom Lane2011-04-26
| | | | | | | | | | | | | | | | | Most commenters agreed that this is more friendly than silently failing to match the line during actual connection attempts. Also, this will prevent corner cases that might arise when trying to handle such a line when the SSL code isn't turned on. An example is that specifying clientcert=1 in such a line would formerly result in a completely misleading complaint that root.crt wasn't present, as seen in a recent report from Marc-Andre Laverdiere. While we could have instead fixed that specific behavior, it seems likely that we'd have a continuing stream of such bizarre behaviors if we keep on allowing hostssl lines when SSL is disabled. Back-patch to 8.4, where clientcert was introduced. Earlier versions don't have this specific issue, and the code is enough different to make this patch not applicable without more work than it seems worth.
* Remove incorrect HINT for use of ALTER FOREIGN TABLE on the wrong relkind.Tom Lane2011-04-25
| | | | | | | | Per discussion, removing the hint seems better than correcting it because the adjacent analogous cases in RenameRelation don't have any hints, and nobody seems to have missed 'em. Shigeru Hanada
* Refactor broken CREATE TABLE IF NOT EXISTS support.Robert Haas2011-04-25
| | | | | | | | | | | | | | | | Per bug #5988, reported by Marko Tiikkaja, and further analyzed by Tom Lane, the previous coding was broken in several respects: even if the target table already existed, a subsequent CREATE TABLE IF NOT EXISTS might try to add additional constraints or sequences-for-serial specified in the new CREATE TABLE statement. In passing, this also fixes a minor information leak: it's no longer possible to figure out whether a schema to which you don't have CREATE access contains a sequence named like "x_y_seq" by attempting to create a table in that schema called "x" with a serial column called "y". Some more refactoring of this code in the future might be warranted, but that will need to wait for a later major release.
* Remove partial and undocumented GRANT .. FOREIGN TABLE support.Robert Haas2011-04-25
| | | | | | | | | | | Instead, foreign tables are treated just like views: permissions can be granted using GRANT privilege ON [TABLE] foreign_table_name TO role, and revoked similarly. GRANT/REVOKE .. FOREIGN TABLE is no longer supported, just as we don't support GRANT/REVOKE .. VIEW. The set of accepted permissions for foreign tables is now identical to the set for regular tables, and views. Per report from Thom Brown, and subsequent discussion.
* Fix pg_size_pretty() to avoid overflow for inputs close to INT64_MAX.Tom Lane2011-04-25
| | | | | | | | The expression that tried to round the value to the nearest TB could overflow, leading to bogus output as reported in bug #5993 from Nicola Cossu. This isn't likely to ever happen in the intended usage of the function (if it could, we'd be needing to use a wider datatype instead); but it's not hard to give the expected output, so let's do so.
* Support "make check" in contribPeter Eisentraut2011-04-25
| | | | | | | | | | | | | | Added a new option --extra-install to pg_regress to arrange installing the respective contrib directory into the temporary installation. This is currently not yet supported for Windows MSVC builds. Updated the .gitignore files for contrib modules to ignore the leftovers of a temp-install check run. Changed the exit status of "make check" in a pgxs build (which still does nothing) to 0 from 1. Added "make check" in contrib to top-level "make check-world".
* Use terse mode to avoid variable order dependency output in foreign data ↵Andrew Dunstan2011-04-25
| | | | | | regression check. Per Tom Lane's suggestion about my gripe about occasional errors noticed on the buildfarm.
* Assorted minor changes to silence Windows compiler warnings.Andrew Dunstan2011-04-25
| | | | Mostly to do with macro redefinitions or object signedness.
* Prevent perl header overriding our *snprintf macros, and give it a usable ↵Andrew Dunstan2011-04-25
| | | | | | | | PERL_UNUSED_DECL value. This quiets compiler warnings about redefined macros and unused Perl__unused variables. The redefinition of snprintf and vsnprintf is something we want to avoid anyway, if we've gone to the bother of setting up the macros to point to our implementation.
* Give getopt() a prototype and modern style arg specs.Andrew Dunstan2011-04-25
| | | | Welcome to the 1990s.
* Add postmaster/postgres undocumented -b option for binary upgrades.Bruce Momjian2011-04-25
| | | | | | | | | | This option turns off autovacuum, prevents non-super-user connections, and enables oid setting hooks in the backend. The code continues to use the old autoavacuum disable settings for servers with earlier catalog versions. This includes a catalog version bump to identify servers that support the -b option.
* Add fast paths for cases when no serializable transactions are running.Robert Haas2011-04-25
| | | | Dan Ports
* Regression tests for TOAST.Robert Haas2011-04-25
| | | | Kevin Grittner, per discussion of bug #5989
* Fix SSI-related assertion failure.Robert Haas2011-04-25
| | | | | | Bug #5899, reported by Marko Tiikkaja. Heikki Linnakangas, reviewed by Kevin Grittner and Dan Ports.
* Adjust yywrap macro for non-reentrant scanners for MSVC.Andrew Dunstan2011-04-25
| | | | | | | | The MSVC compiler complains if a macro is called with less arguments than its definition provides for. flex generates a macro with one argument for yywrap, but only supplies the argument for reentrant scanners, so we remove the useless argument in the non-reentrant case to silence the warning.
* In libecpg do not set an sqlda field that is 'reserved for future use' unlessMichael Meskes2011-04-25
| | | | we know what should be stored in there.
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-04 21:36:55 +0000