aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* Export ExplainBeginOutput() and ExplainEndOutput() for auto_explain.Robert Haas2009-12-12
| | | | | | | | | Without these functions, anyone outside of explain.c can't actually use ExplainPrintPlan, because the ExplainState won't be initialized properly. The user-visible result of this was a crash when using auto_explain with the JSON output format. Report by Euler Taveira de Oliveira. Analysis by Tom Lane. Patch by me.
* Ensure that the result tuple of an EvalPlanQual cycle gets materializedTom Lane2009-12-11
| | | | | | | | before we zap the input tuple. Otherwise, pass-by-reference columns of the result slot are likely to contain just references to the input tuple, leading to big trouble if the pfree'd space is reused. Per trouble report from Jaime Casanova. This is a new bug in the recent rewrite of EvalPlanQual, so nothing to back-patch.
* Add large object access control.Itagaki Takahiro2009-12-11
| | | | | | | A new system catalog pg_largeobject_metadata manages ownership and access privileges of large objects. KaiGai Kohei, reviewed by Jaime Casanova.
* Add YAML to list of EXPLAIN formats. Greg Sabino Mullane, reviewed by ↵Andrew Dunstan2009-12-11
| | | | Takahiro Itagaki.
* PL/Python array supportPeter Eisentraut2009-12-10
| | | | Support arrays as parameters and return values of PL/Python functions.
* Add init[db] option to pg_ctlPeter Eisentraut2009-12-10
| | | | | | | | pg_ctl gets a new mode that runs initdb. Adjust the documentation a bit to not assume that initdb is the only way to run database cluster initialization. But don't replace initdb as the canonical way. Author: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
* Prevent indirect security attacks via changing session-local state withinTom Lane2009-12-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | an allegedly immutable index function. It was previously recognized that we had to prevent such a function from executing SET/RESET ROLE/SESSION AUTHORIZATION, or it could trivially obtain the privileges of the session user. However, since there is in general no privilege checking for changes of session-local state, it is also possible for such a function to change settings in a way that might subvert later operations in the same session. Examples include changing search_path to cause an unexpected function to be called, or replacing an existing prepared statement with another one that will execute a function of the attacker's choosing. The present patch secures VACUUM, ANALYZE, and CREATE INDEX/REINDEX against these threats, which are the same places previously deemed to need protection against the SET ROLE issue. GUC changes are still allowed, since there are many useful cases for that, but we prevent security problems by forcing a rollback of any GUC change after completing the operation. Other cases are handled by throwing an error if any change is attempted; these include temp table creation, closing a cursor, and creating or deleting a prepared statement. (In 7.4, the infrastructure to roll back GUC changes doesn't exist, so we settle for rejecting changes of "search_path" in these contexts.) Original report and patch by Gurjeet Singh, additional analysis by Tom Lane. Security: CVE-2009-4136
* Add notes about updating disk and shared memory size information in theMagnus Hagander2009-12-09
| | | | documentation when doing new major release.
* Reject certificates with embedded NULLs in the commonName field. This stopsMagnus Hagander2009-12-09
| | | | | | | | | | | | | | | | | | attacks where an attacker would put <attack>\0<propername> in the field and trick the validation code that the certificate was for <attack>. This is a very low risk attack since it reuqires the attacker to trick the CA into issuing a certificate with an incorrect field, and the common PostgreSQL deployments are with private CAs, and not external ones. Also, default mode in 8.4 does not do any name validation, and is thus also not vulnerable - but the higher security modes are. Backpatch all the way. Even though versions 8.3.x and before didn't have certificate name validation support, they still exposed this field for the user to perform the validation in the application code, and there is no way to detect this problem through that API. Security: CVE-2009-4034
* Update time zone data files to tzdata release 2009s: DST law changes inTom Lane2009-12-09
| | | | | Antarctica, Argentina, Bangladesh, Fiji, Novokuznetsk, Pakistan, Palestine, Samoa, Syria. Also historical corrections for Hong Kong.
* Add exclusion constraints, which generalize the concept of uniqueness toTom Lane2009-12-07
| | | | | | | | support any indexable commutative operator, not just equality. Two rows violate the exclusion constraint if "row1.col OP row2.col" is TRUE for each of the columns in the constraint. Jeff Davis, reviewed by Robert Haas
* Don't use a duplicate OID for aclexplode().Tom Lane2009-12-06
|
* Speed up information schema privilege viewsPeter Eisentraut2009-12-05
| | | | | | | | | | | | | Instead of expensive cross joins to resolve the ACL, add table-returning function aclexplode() that expands the ACL into a useful form, and join against that. Also, implement the role_*_grants views as a thin layer over the respective *_privileges views instead of essentially repeating the same code twice. fixes bug #4596 by Joachim Wieland, with cleanup by me
* Fix bug in temporary file management with subtransactions. A cursor openedHeikki Linnakangas2009-12-03
| | | | | | | | | | | | | in a subtransaction stays open even if the subtransaction is aborted, so any temporary files related to it must stay alive as well. With the patch, we use ResourceOwners to track open temporary files and don't automatically close them at subtransaction end (though in the normal case temporary files are registered with the subtransaction resource owner and will therefore be closed). At end of top transaction, we still check that there's no temporary files marked as close-at-end-of-transaction open, but that's now just a debugging cross-check as the resource owner cleanup should've closed them already.
* thread-safetyBruce Momjian2009-12-02
| | | | Apply full patch to enable thread-safety by default, e.g. doc changes.
* Mark application_name as GUC_REPORT so that the value will be reported backTom Lane2009-12-02
| | | | | | | | to the client by the server. This might seem pretty pointless but apparently it will help pgbouncer, and perhaps other connection poolers. Anyway it's practically free to do so for the normal use-case where appname is only set in the startup packet --- we're just adding a few more bytes to the initial ParameterStatus response packet. Per comments from Marko Kreen.
* Instead of sending application_name as a SET command after the connectionTom Lane2009-12-02
| | | | | | | | | | | is made, include it in the startup-packet options. This makes it work more like every other libpq connection option, in particular it now has the same response to RESET ALL as the rest. This also saves one network round trip for new applications using application_name. The cost is that if the server is pre-8.5, it'll reject the startup packet altogether, forcing us to retry the entire connection cycle. But on balance we shouldn't be optimizing that case in preference to the behavior with a new server, especially when doing so creates visible behavioral oddities. Per discussion.
* psql -f -Bruce Momjian2009-12-01
| | | | | | Adjust psql -f - to behave like a normal file and honor the -1 flag. Report from Robert Haas
* Teach the regular expression functions to do case-insensitive matching andTom Lane2009-12-01
| | | | | | | | | | | | | | | | | | | | locale-dependent character classification properly when the database encoding is UTF8. The previous coding worked okay in single-byte encodings, or in any case for ASCII characters, but failed entirely on multibyte characters. The fix assumes that the <wctype.h> functions use Unicode code points as the wchar representation for Unicode, ie, wchar matches pg_wchar. This is only a partial solution, since we're still stupid about non-ASCII characters in multibyte encodings other than UTF8. The practical effect of that is limited, however, since those cases are generally Far Eastern glyphs for which concepts like case-folding don't apply anyway. Certainly all or nearly all of the field reports of problems have been about UTF8. A more general solution would require switching to the platform's wchar representation for all regex operations; which is possible but would have substantial disadvantages. Let's try this and see if it's sufficient in practice.
* Revert due to Tom's concerns:Bruce Momjian2009-12-01
| | | | | Add ProcessUtility_hook() to handle all DDL to contrib/pg_stat_statements.
* ProcessUtility_hook:Bruce Momjian2009-12-01
| | | | | | Add ProcessUtility_hook() to handle all DDL to contrib/pg_stat_statements. Itagaki Takahiro
* Avoid core dump on empty thesaurus dictionary.Tom Lane2009-11-30
| | | | Per report from Robert Gravsjö.
* Fix session-lifespan memory leak when a plperl function is redefined:Tom Lane2009-11-29
| | | | | | | | we have to tell Perl it can release its compiled copy of the function text. Noted by Alexey Klyukin. Back-patch to 8.2 --- the problem exists further back, but this patch won't work without modification, and it's probably not worth the trouble.
* Error when a specified connection service is not found, instead of ignoring itPeter Eisentraut2009-11-29
|
* Add some opr_sanity checks that the lengths of the various argument-infoTom Lane2009-11-29
| | | | | arrays in a pg_proc entry match. Seems like an easy mistake to make when manually adjusting these values in a pg_proc.h entry.
* Remove prefix "ERROR:" from some messages, to make everything consistentPeter Eisentraut2009-11-29
|
* Make pg_stat_activity.application_name visible to all users, rather thanTom Lane2009-11-29
| | | | | being hidden when current_query is. Relocate it to a column position more consistent with that behavior. Per discussion.
* Add support for anonymous code blocks (DO blocks) to PL/Perl.Tom Lane2009-11-29
| | | | Joshua Tolley, reviewed by Brendan Jurd and Tim Bunce
* Add support for an application_name parameter, which is displayed inTom Lane2009-11-28
| | | | | | pg_stat_activity and recorded in log entries. Dave Page, reviewed by Andres Freund
* test_fsync:Bruce Momjian2009-11-28
| | | | | Improve test descriptions displayed during test_fsync; increase default loops to 5k.
* Eliminate a lot of list-management overhead within join_search_one_levelTom Lane2009-11-28
| | | | | | | | | | | | | | by adding a requirement that build_join_rel add new join RelOptInfos to the appropriate list immediately at creation. Per report from Robert Haas, the list_concat_unique_ptr() calls that this change eliminates were taking the lion's share of the runtime in larger join problems. This doesn't do anything to fix the fundamental combinatorial explosion in large join problems, but it should push out the threshold of pain a bit further. Note: because this changes the order in which joinrel lists are built, it might result in changes in selected plans in cases where different alternatives have exactly the same costs. There is one example in the regression tests.
* Remove */ characters from declare cursor statements before putting them into aMichael Meskes2009-11-27
| | | | comment.
* If no result is given NOTFOUND should be returned. Check for empty resultMichael Meskes2009-11-27
| | | | string too.
* Added script to check if all rule re-definition in ecpg.addons are indeed usedMichael Meskes2009-11-27
| | | | in the build process. If not the build process will stop with an error message.
* Added missing files.Michael Meskes2009-11-26
|
* Forgot to add dynamic cursors to Changelog.Michael Meskes2009-11-26
|
* Synced addon rules after some renamings.Michael Meskes2009-11-26
|
* Added dynamic cursor names to ecpg. Almost the whole patch was done byMichael Meskes2009-11-26
| | | | Boszormenyi Zoltan, with only a minor tweak or two from me.
* Simplify psql's new linestyle behavior to default to linestyle=ascii allTom Lane2009-11-25
| | | | | the time, rather than hoping we can tell whether the terminal supports UTF8 characters. Per discussion.
* Made function better readable.Michael Meskes2009-11-24
|
* Use diff's -w switch only on Windows, to avoid problems with inconsistentTom Lane2009-11-23
| | | | | newline representations. Per buildfarm results and subsequent discussion. Sync up a couple of other places that had their own policies.
* Add missing library to standalone libpq build on Win32.Magnus Hagander2009-11-23
| | | | Hiroshi Saito
* Fix an old bug in multixact and two-phase commit. Prepared transactions canHeikki Linnakangas2009-11-23
| | | | | | | | | | | | | be part of multixacts, so allocate a slot for each prepared transaction in the "oldest member" array in multixact.c. On PREPARE TRANSACTION, transfer the oldest member value from the current backends slot to the prepared xact slot. Also save and recover the value from the 2pc state file. The symptom of the bug was that after a transaction prepared, a shared lock still held by the prepared transaction was sometimes ignored by other transactions. Fix back to 8.1, where both 2PC and multixact were introduced.
* Adjust expected-results spacing per buildfarm results.Tom Lane2009-11-22
|
* Remove -w (--ignore-all-space) option from pg_regress's diff calls.Tom Lane2009-11-22
| | | | | | | | | | | | | We have used -w for a long time as a means of reducing the reported diff volume when one element of a result table isn't of the expected width. However, most of the time the results just pass anyway, so this isn't as important as it once was. Meanwhile, the risk of missing potentially significant deviations has gone up, particularly with psql's ability to report error cursor positions. So, let's switch over to space-sensitive comparisons. Per my proposal of yesterday. (All the expected files that I can test here seem to be ready for this already, but we'll see what the buildfarm thinks about others.)
* Remove superfluous curly brace, fixing compilation with OPTIMIZER_DEBUG.Heikki Linnakangas2009-11-22
| | | | Jan Urbanski
* Ooops, forgot to check the libxml cases for psql output wrapping change.Tom Lane2009-11-22
|
* Improve psql's tabular display of wrapped-around data by inserting markersTom Lane2009-11-22
| | | | | | | | | | | | | | | | in the formerly-always-blank columns just to left and right of the data. Different marking is used for a line break caused by a newline in the data than for a straight wraparound. A newline break is signaled by a "+" in the right margin column in ASCII mode, or a carriage return arrow in UNICODE mode. Wraparound is signaled by a dot in the right margin as well as the following left margin in ASCII mode, or an ellipsis symbol in the same places in UNICODE mode. "\pset linestyle old-ascii" is added to make the previous behavior available if anyone really wants it. In passing, this commit also cleans up a few regression test files that had unintended spacing differences from the current actual output. Roger Leigh, reviewed by Gabrielle Roth and other members of PDXPUG.
* Ignore UTF-8-encoded Unicode byte-order mark at the beginning of a file ifPeter Eisentraut2009-11-21
| | | | | | the client encoding is UTF-8. a limited version of a patch proposed by Itagaki Takahiro
* Refactor ecpg grammar so that it uses the core grammar's unreserved_keywordTom Lane2009-11-21
| | | | | | | | | | | list, minus a few specific words that have to be treated specially. This replaces a hard-wired list of keywords that would have needed manual maintenance, and was not getting it. The 8.4 coding was already missing these words, causing ecpg to incorrectly treat them as reserved words: CALLED, CATALOG, DEFINER, ENUM, FOLLOWING, INVOKER, OPTIONS, PARTITION, PRECEDING, RANGE, SECURITY, SERVER, UNBOUNDED, WRAPPER. In HEAD we were additionally missing COMMENTS, FUNCTIONS, SEQUENCES, TABLES. Per gripe from Bosco Rama.