aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
...
* >> It certainly doesn't. There still was a bug with the locale stuff,Bruce Momjian2004-06-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | >> though - the GUC variable was not set in the child >processes. So "show >> lc_collate" would *always* return "C", for example. attached >patch fixes >> this. > >Hm. Why were these vars not propagated by the regular >mechanism for GUC >variables (write_nondefault_variables or whatever it's called)? If the >problem is that it's not accepting PGC_INTERNAL values, then we need to >fix it there not here, because otherwise we'll have to pass all the >PGC_INTERNAL variables through the backend_variables file, which seems >like a recipe for more of the same sort of bug. Good point :-( I think the problem is not only that it specifically does not deal with PGC_INTERNAL variables. The problem is in the fact that write_nondefault_variables is called *before* the locale is read (because the locale is read from pg_control and not from any of the "usual" ways to read it). Attached patch is another stab at fixing it. It makes postmaster dump a new copy of the file once it has started the database (before it accepts any connections), which is when it will know about these parameters. Also updates the reading code to set the context to the one where the variable was originally set (PGC_POSTMASTER won't work for PGC_INTERNAL, and the other way around). We still pass lc_collate through the special file, because set_config_option on lc_collate will speficially *not* call setlocale(), and we need that call. But we no longer call set_config_option from there. Magnus Hagander
* This patch updates pgpipe() on win32 to log exactly which part of theBruce Momjian2004-06-11
| | | | | | | | | | | | call fails when it does. (As it is now, there is no way to figure out the point of error). Shouldn't be a problem since it's most defintily not a performance-critical path (only called on pgstat startup ATM). This should help us debug the pipe error message that's on the win32 status page (which I myself have never been able to reproduce, and thus haven't figured out a better way to debug yet) Magnus Hagander
* When using extended-query protocol, postpone planning of unnamed statementsTom Lane2004-06-11
| | | | | | | | | | | | | | | | | | | until Bind is received, so that actual parameter values are visible to the planner. Make use of the parameter values for estimation purposes (but don't fold them into the actual plan). This buys back most of the potential loss of plan quality that ensues from using out-of-line parameters instead of putting literal values right into the query text. This patch creates a notion of constant-folding expressions 'for estimation purposes only', in which case we can be more aggressive than the normal eval_const_expressions() logic can be. Right now the only difference in behavior is inserting bound values for Params, but it will be interesting to look at other possibilities. One that we've seen come up repeatedly is reducing now() and related functions to current values, so that queries like ... WHERE timestampcol > now() - '1 day' have some chance of being planned effectively. Oliver Jowett, with some kibitzing from Tom Lane.
* More restructuring to use Win32 START with paths needing quotes.Bruce Momjian2004-06-11
|
* Attached is a patch that takes care of the PATHSEP issue. I made a moreBruce Momjian2004-06-10
| | | | | | | | | | | | | | | | | | | extensive change then what was suggested. I found the file path.c that contained a lot of "Unix/Windows" agnostic functions so I added a function there instead and removed the PATHSEP declaration in exec.c altogether. All to keep things from scattering all over the code. I also took the liberty of changing the name of the functions "first_path_sep" and "last_path_sep". Where I come from (and I'm apparently not alone given the former macro name PATHSEP), they should be called "first_dir_sep" and "last_dir_sep". The new function I introduced, that actually finds path separators, is now the "first_path_sep". The patch contains changes on all affected places of course. I also changed the documentation on dynamic_library_path to reflect the chagnes. Thomas Hallgren
* More quoting cleanups for Win32's pg_ctl.Bruce Momjian2004-06-10
|
* Adjust cost_nonsequential_access() to have more reasonable behaviorTom Lane2004-06-10
| | | | | when random_page_cost has a small value. Per Manfred Koizar, though I didn't use his equation exactly.
* Make ALTER TABLE ADD SERIAL work reasonably in inheritance cases, too.Tom Lane2004-06-10
|
* Fix oversight in recent ALTER TABLE improvements. We now supportTom Lane2004-06-10
| | | | | | ALTER TABLE tab ADD COLUMN col SERIAL, but we forgot to install the dependency between the column and the sequence, so the sequence would not go away if you dropped the table later.
* Use /B to start so a new window isn't created, per Andrew Dunstan.Bruce Momjian2004-06-10
|
* Clean up generation of default names for constraints, indexes, and serialTom Lane2004-06-10
| | | | | | | | sequences, as per recent discussion. All these names are now of the form table_column_type, with digits added if needed to make them unique. Default constraint names are chosen to be unique across their whole schema, not just within the parent object, so as to be more SQL-spec-compatible and make the information schema views more useful.
* Add START background code for another code path, per Andrew Dunstan.Bruce Momjian2004-06-10
|
* Use START for pg_ctl background runs on Win32, from Magnus.Bruce Momjian2004-06-10
|
* Translation updatePeter Eisentraut2004-06-10
|
* New translationPeter Eisentraut2004-06-10
|
* Handle multiple double-quoted strings using Win32's system() call.Bruce Momjian2004-06-10
| | | | Document limitations.
* Add pg_ctl native language files for Russian.Bruce Momjian2004-06-10
| | | | Serguei A. Mokhov
* Add regression tests for CSV COPY format.Bruce Momjian2004-06-09
|
* Fix slightly-wrong syntax error messages from bootstrap parser, as perTom Lane2004-06-09
| | | | report from Tom Cook.
* Support assignment to subfields of composite columns in UPDATE and INSERT.Tom Lane2004-06-09
| | | | | | | | As a side effect, cause subscripts in INSERT targetlists to do something more or less sensible; previously we evaluated such subscripts and then effectively ignored them. Another side effect is that UPDATE-ing an element or slice of an array value that is NULL now produces a non-null result, namely an array containing just the assigned-to positions.
* Use single quotes around pg_dump call from pg_dumpall.Bruce Momjian2004-06-09
|
* Use single quotes for pg_ctl system call.Bruce Momjian2004-06-09
|
* Add time.h to pg_dumpall.Bruce Momjian2004-06-09
|
* Use mkstemp instead of mktemp in thread test, per Jan.Bruce Momjian2004-06-09
|
* Previous code cleanup was for bufpage.c, not bufmgr.c.Bruce Momjian2004-06-09
| | | | This cleanup just cleans up a comment.
* Add missing check for too-few-inputs when replacing a zero-dimensionalTom Lane2004-06-08
| | | | array.
* Stylistic changes in bufmgr.cBruce Momjian2004-06-08
| | | | | | | Basically replaces (*a).b with a->b as it is everywhere else in Postgres. Manfred Koizar
* vacuum.c refactoringBruce Momjian2004-06-08
| | | | | | | | | | | | | | | | | . rename variables . cur_buffer -> dst_buffer . ToPage -> dst_page . cur_page -> dst_vacpage . move variable declarations into block where variable is used . various Asserts instead of elog(ERROR, ...) . extract functionality from repair_frag() into new routines . move_chain_tuple() . move_plain_tuple() . update_hint_bits() . create type ExecContext . add comments Manfred Koizar
* Change PGETC to PGSYSCONFDIR and PGLOCALE to PGLOCALEDIR, per Peter.Bruce Momjian2004-06-08
|
* Have strerror_r return "Unknown error".Bruce Momjian2004-06-08
|
* Fix strerror_r by checking return type from configure.Bruce Momjian2004-06-07
|
* Add start/stop times for pg_dump/pg_dumpall when verbose output is used.Bruce Momjian2004-06-07
|
* Dept of second thoughts: don't use the new wide-character upper/lowerTom Lane2004-06-06
| | | | | code if we are running in a single-byte encoding. No point in the extra overhead in that case.
* Add some regression tests for composite-type operations.Tom Lane2004-06-06
|
* Allow use of table rowtypes directly as column types of other tables.Tom Lane2004-06-06
| | | | | | | | Instead of prohibiting that, put code into ALTER TABLE to reject ALTERs that would affect other tables' columns. Eventually we will probably want to extend ALTER TABLE to actually do something useful here, but in the meantime it seems wrong to forbid the feature completely just because ALTER isn't fully baked.
* Minor catalog cleanups for composite-type stuff. Adjust signatures shownTom Lane2004-06-06
| | | | | | | in pg_proc for record_in, record_out, etc to reflect that these routines now make use of the second OID parameter. Remove the ancient SET entry in pg_type, which is now highly unlikely to ever become used again. Adjust type_sanity regression test to match.
* Add binary I/O support for composite types.Tom Lane2004-06-06
|
* Remove finger from dike: composite types are now allowed as table columns.Tom Lane2004-06-06
| | | | | Still a few things to do, like binary I/O and regression tests and docs, but might as well let people play with the toy.
* Preliminary support for composite type I/O; just text for now,Tom Lane2004-06-06
| | | | no binary yet.
* Infrastructure for I/O of composite types: arrange for the I/O routinesTom Lane2004-06-06
| | | | | | | | | | of a composite type to get that type's OID as their second parameter, in place of typelem which is useless. The actual changes are mostly centralized in getTypeInputInfo and siblings, but I had to fix a few places that were fetching pg_type.typelem for themselves instead of using the lsyscache.c routines. Also, I renamed all the related variables from 'typelem' to 'typioparam' to discourage people from assuming that they necessarily contain array element types.
* Tweak palloc/repalloc to allow zero bytes to be requested, as per recentTom Lane2004-06-05
| | | | | proposal. Eliminate several dozen now-unnecessary hacks to avoid palloc(0). (It's likely there are more that I didn't find.)
* Adjust PageGetMaxOffsetNumber to ensure sane behavior on uninitializedTom Lane2004-06-05
| | | | pages, even when the macro's result is stored into an unsigned variable.
* Slight code cleanup for printf's.Bruce Momjian2004-06-05
|
* Make the world very nearly safe for composite-type columns in tables.Tom Lane2004-06-05
| | | | | | | | | | | | | | | | | | | 1. Solve the problem of not having TOAST references hiding inside composite values by establishing the rule that toasting only goes one level deep: a tuple can contain toasted fields, but a composite-type datum that is to be inserted into a tuple cannot. Enforcing this in heap_formtuple is relatively cheap and it avoids a large increase in the cost of running the tuptoaster during final storage of a row. 2. Fix some interesting problems in expansion of inherited queries that reference whole-row variables. We never really did this correctly before, but it's now relatively painless to solve by expanding the parent's whole-row Var into a RowExpr() selecting the proper columns from the child. If you dike out the preventive check in CheckAttributeType(), composite-type columns now seem to actually work. However, we surely cannot ship them like this --- without I/O for composite types, you can't get pg_dump to dump tables containing them. So a little more work still to do.
* Resurrect heap_deformtuple(), this time implemented as a singly nestedTom Lane2004-06-04
| | | | | | | | | | loop over the fields instead of a loop around heap_getattr. This is considerably faster (O(N) instead of O(N^2)) when there are nulls or varlena fields, since those prevent use of attcacheoff. Replace loops over heap_getattr with heap_deformtuple in situations where all or most of the fields have to be fetched, such as printtup and tuptoaster. Profiling done more than a year ago shows that this should be a nice win for situations involving many-column tables.
* The attached patch will create a dummy pg_config_paths.h. Additionally,Bruce Momjian2004-06-04
| | | | | | | ENABLE_THREAD_SAFETY is supported by the makefile (but not by the sources, which need some rework) Andreas Pflug
* Remove dash in pg_ctl signal name. It broke with getopt_long dashBruce Momjian2004-06-04
| | | | reorganization processing, and it is clearer without the dash anyway.
* Remove some long-obsolete code that was causing a strange error messageTom Lane2004-06-04
| | | | | | | when someone attempts to create a column of a composite datatype. For now, just make sure we produce a reasonable error at the 'right place'. Not sure if this will be made to work before 7.5, but make it act reasonably in case nothing more gets done.
* Support assignment to whole-row variables in plpgsql; also fix glitchTom Lane2004-06-04
| | | | | with using a trigger's NEW or OLD record as a whole-row variable in an expression. Fixes several long-standing complaints.
* Allow plpgsql to pass composite-type arguments (ie, whole-row variables)Tom Lane2004-06-04
| | | | | | into SQL expressions. At present this only works usefully for variables of named rowtypes, not RECORD variables, since the SQL parser can't infer anything about datatypes from a RECORD Param. Still, it's a step forward.
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-03 12:04:14 +0000