aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* Fix wrong commentPeter Eisentraut2011-01-20
| | | | Hitoshi Harada
* Fix typoPeter Eisentraut2011-01-20
| | | | Hitoshi Harada
* Factor out functions responsible for caching I/O routinesPeter Eisentraut2011-01-20
| | | | | | This makes PLy_procedure_create a bit more manageable. Jan Urbański
* Add new psql command \dL to list languages.Robert Haas2011-01-20
| | | | | Original patch by Fernando Ike, revived by Josh Kuperschmidt, reviewed by Andreas Karlsson, and in earlier versions by Tom Lane and Peter Eisentraut.
* Add braces around an if block, for readabilityPeter Eisentraut2011-01-19
| | | | Jan Urbański, reviewed by Peter Eisentraut, Álvaro Herrera, Tom Lane :-)
* Free plan values in the PLyPlanObject dealloc functionPeter Eisentraut2011-01-19
| | | | Jan Urbański
* Improve message for errors in compiling anonymous PL/Python blocksPeter Eisentraut2011-01-19
| | | | | | The previous code would try to print out a null pointer. Jan Urbański
* Use PyObject_New instead of PyObject_NEWPeter Eisentraut2011-01-18
| | | | | | The latter is undocumented and the speed gain is negligible. Jan Urbański
* Skip dropped attributes when converting Python objects to tuplesPeter Eisentraut2011-01-18
| | | | | | | | Pay attention to the attisdropped field and skip over TupleDesc fields that have it set. Not a real problem until we get table returning functions, but it's the right thing to do anyway. Jan Urbański
* Use palloc in TopMemoryContext instead of mallocPeter Eisentraut2011-01-18
| | | | | | | As discussed, even if the PL needs a permanent memory location, it should use palloc, not malloc. It also makes error handling easier. Jan Urbański
* Fix an error when a set-returning function fails halfway through the executionPeter Eisentraut2011-01-18
| | | | | | | | | If the function using yield to return rows fails halfway, the iterator stays open and subsequent calls to the function will resume reading from it. The fix is to unref the iterator and set it to NULL if there has been an error. Jan Urbański
* In test_fsync, adjust test headings to match wal_sync_method values;Bruce Momjian2011-01-18
| | | | add more test cases for open_sync of different sizes.
* Avoid detoast in texteq/textne/byteaeq/byteane for unequal-length strings.Tom Lane2011-01-18
| | | | | | | | | | We can get the length of a compressed or out-of-line datum without actually detoasting it. If the lengths of two strings are unequal, we can then conclude they are unequal without detoasting. That saves considerable work in an admittedly less-common case, without costing anything much when the optimization doesn't apply. Noah Misch
* Log replication connections only when log_connections is onMagnus Hagander2011-01-18
| | | | | Previously we'd always log replication connections, with no way to turn them off.
* Fix thinko in comment. Spotted by Jim Nasby.Heikki Linnakangas2011-01-18
|
* Remove "github test" that somehow got into my tree. Sorry.Bruce Momjian2011-01-17
|
* github testBruce Momjian2011-01-17
|
* Use HTABs instead of Python dictionary objects to cache proceduresPeter Eisentraut2011-01-17
| | | | | | | | | | | | | | | | | Two separate hash tables are used for regular procedures and for trigger procedures, since the way trigger procedures work is quite different from normal stored procedures. Change the signatures of PLy_procedure_{get,create} to accept the function OID and a Boolean flag indicating whether it's a trigger. This should make implementing a PL/Python validator easier. Using HTABs instead of Python dictionaries makes error recovery easier, and allows for procedures to be cached based on their OIDs, not their names. It also allows getting rid of the PyCObject field that used to hold a pointer to PLyProcedure, since PyCObjects are deprecated in Python 2.7 and replaced by Capsules in Python 3. Jan Urbański
* Fix miscalculation of itemsafter in array_set_slice().Tom Lane2011-01-17
| | | | | | | | | | | If the slice to be assigned to was before the existing array lower bound (requiring at least one null element to spring into existence to fill the gap), the code miscalculated how many entries needed to be copied from the old array's null bitmap. This could result in trashing the array's data area (as seen in bug #5840 from Karsten Loesing), or worse. This has been broken since we first allowed the behavior of assigning to non-adjacent slices, in 8.2. Back-patch to all affected versions.
* Increment Py_None refcount for NULL array elementsAlvaro Herrera2011-01-17
| | | | | Per bug #5835 by Julien Demoor Author: Alex Hunsaker
* Add getopt() support to test_fsync; also fix printf() format problem.Bruce Momjian2011-01-17
|
* Set fallback_application_name in walreceiverMagnus Hagander2011-01-17
| | | | | Makes replication slaves identify themselves in the new pg_stat_replication view.
* Before exiting walreceiver, fsync() all the WAL received.Heikki Linnakangas2011-01-17
| | | | | | Otherwise WAL recovery will replay the un-flushed WAL after walreceiver has exited, which can lead to a non-recoverable standby if the system crashes hard at that point.
* In test_fsync, use #define for printf format of ops/sec.Bruce Momjian2011-01-16
|
* Use O_DIRECT in O_SYNC test of different size. Restructure O_DIRECTBruce Momjian2011-01-15
| | | | error reporting to be more consistent.
* Reverse number of stars used for test_fsync details.Bruce Momjian2011-01-15
|
* In test_fsync, warn about options without o_direct that are not used byBruce Momjian2011-01-15
| | | | Postgres, and cases where o_direct does not work with certain file systems.
* Move a couple of declarations to reflect where the routines really are.Tom Lane2011-01-15
|
* Add .gitignore to silence git complaints about parser/scanner output files.Tom Lane2011-01-15
|
* Have test_fsync output details that fdatasync is the defaultBruce Momjian2011-01-15
| | | | wal_sync_method on Linux.
* Restructure test_fync to use modular C so there is less duplicate codeBruce Momjian2011-01-15
| | | | and it can be enhanced easier.
* Enumerate available tablespaces after starting the backupMagnus Hagander2011-01-15
| | | | | | | | | | This closes a race condition where if a tablespace was created after the enumeration happened but before the do_pg_start_backup() was called, the backup would be incomplete. Now that it's done while we are in backup mode, WAL replay will recreate it during restore. Noted by Heikki.
* Improve output display of test_fsync.Bruce Momjian2011-01-15
|
* Apply patch for test_fsync to add tests for O_DIRECT.Bruce Momjian2011-01-15
| | | | Adjusted patch by Josh Berkus
* Treat a WAL sender process that hasn't started streaming yet as a regularHeikki Linnakangas2011-01-15
| | | | | | | | | backend, as far as the postmaster shutdown logic is concerned. That means, fast shutdown will wait for WAL sender processes to exit before signaling bgwriter to finish. This avoids race conditions between a base backup stopping or starting, and bgwriter writing the shutdown checkpoint WAL record. We don't want e.g the end-of-backup WAL record to be written after the shutdown checkpoint.
* Use a lexer and grammar for parsing walsender commandsMagnus Hagander2011-01-14
| | | | | | | | | | | Makes it easier to parse mainly the BASE_BACKUP command with it's options, and avoids having to manually deal with quoted identifiers in the label (previously broken), and makes it easier to add new commands and options in the future. In passing, refactor the case statement in the walsender to put each command in it's own function.
* Exit from base backups when shutdown is requestedMagnus Hagander2011-01-14
| | | | | | | | When the exit waits until the whole backup completes, it may take a very long time. In passing, add back an error check in the main loop so we detect clients that disconnect much earlier if the backup is large.
* Code review for postmaster.pid contents changes.Tom Lane2011-01-13
| | | | | | | | | | Fix broken test for pre-existing postmaster, caused by wrong code for appending lines to the lockfile; don't write a failed listen_address setting into the lockfile; don't arbitrarily change the location of the data directory in the lockfile compared to previous releases; provide more consistent and useful definitions of the socket path and listen_address entries; avoid assuming that pg_ctl has the same DEFAULT_PGSOCKET_DIR as the postmaster; assorted code style improvements.
* Revert incorrect memory-conservation hack in inheritance_planner().Tom Lane2011-01-13
| | | | | | | | | | This reverts commit d1001a78ce612a16ea622b558f5fc2b68c45ab4c of 2010-12-05, which was broken as reported by Jeff Davis. The problem is that the individual planning steps may have side-effects on substructures of PlannerGlobal, not only the current PlannerInfo root. Arranging to keep all such side effects in the main planning context is probably possible, but it would change this from a quick local hack into a wide-ranging and rather fragile endeavor. Which it's not worth.
* Make sure walsender state is only read while holding the spinlockMagnus Hagander2011-01-13
| | | | Noted by Robert Haas.
* Fix the logic in libpqrcv_receive() to determine if there's any incoming dataHeikki Linnakangas2011-01-13
| | | | | | | | | that can be read without blocking. It used to conclude that there isn't, even though there was data in the socket receive buffer. That lead walreceiver to flush the WAL after every received chunk, potentially causing big performance issues. Backpatch to 9.0, because the performance impact can be very significant.
* Workaround for recursive make breakagePeter Eisentraut2011-01-13
| | | | | | Changing a file two directory levels deep under src/backend/ would not cause the postgres binary to be rebuilt. This change fixes it, but no one knows why.
* Don't run regression tests in SQL_ASCII encoding by defaultPeter Eisentraut2011-01-13
| | | | | | | | Instead, run them in the encoding that the locale selects, which is more representative of real use. Also document how locale and encoding for regression test runs can be selected.
* Fix PlanRowMark/ExecRowMark structures to handle inheritance correctly.Tom Lane2011-01-12
| | | | | | | | | | | | | | | | | | In an inherited UPDATE/DELETE, each target table has its own subplan, because it might have a column set different from other targets. This means that the resjunk columns we add to support EvalPlanQual might be at different physical column numbers in each subplan. The EvalPlanQual rewrite I did for 9.0 failed to account for this, resulting in possible misbehavior or even crashes during concurrent updates to the same row, as seen in a recent report from Gordon Shannon. Revise the data structure so that we track resjunk column numbers separately for each subplan. I also chose to move responsibility for identifying the physical column numbers back to executor startup, instead of assuming that numbers derived during preprocess_targetlist would stay valid throughout subsequent massaging of the plan. That's a bit slower, so we might want to consider undoing it someday; but it would complicate the patch considerably and didn't seem justifiable in a bug fix that has to be back-patched to 9.0.
* Revert patch adding support for logging the current role.Robert Haas2011-01-12
| | | | | | | | This reverts commit a8a8867912c46a68c9ac14903b3dba2fab8f7097, committed by me earlier today (2011-01-12). This isn't safe inside an aborted transaction. Noted by Tom Lane.
* Add support for logging the current role.Robert Haas2011-01-12
| | | | Stephen Frost, with some editorialization by me.
* Unbreak regression tests, apparently broken by commit 4c8e20fAndrew Dunstan2011-01-11
|
* Re-add recursive coverage target in src/backend/Peter Eisentraut2011-01-12
| | | | This was lost during the recent recursive make change.
* Track walsender state in shared memory and expose in pg_stat_replicationMagnus Hagander2011-01-11
|
* Add missing function prototype, for consistencyMagnus Hagander2011-01-11
|