| Commit message (Collapse) | Author | Age |
... | |
|
|
|
| |
Simon Riggs
|
|
|
|
| |
Florian G. Pflug
|
|
|
|
| |
Kris Jurka
|
|
|
|
|
|
| |
fixup various places in the tree that were clearing a StringInfo by hand.
Making this function a part of the API simplifies client code slightly,
and avoids needlessly peeking inside the StringInfo interface.
|
|
|
|
| |
Simon Riggs
|
|
|
|
|
|
| |
toggle.
Chad Wagner
|
|
|
|
|
|
| |
log_min_messages does; and arrange to suppress the duplicative output
that would otherwise result from log_statement and log_duration messages.
Bruce Momjian and Tom Lane.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this, add a 16-bit "flags" field to page headers by stealing some bits from
pd_tli. We use one flag bit as a hint to indicate whether there are any
unused line pointers; the remaining 15 are available for future use.
This is a cut-down form of an idea proposed by Hiroki Kataoka in July 2005.
At the time it was rejected because the original patch increased the size of
page headers and it wasn't clear that the benefit outweighed the distributed
cost. The flag-bit approach gets most of the benefit without requiring an
increase in the page header size.
Heikki Linnakangas and Tom Lane
|
|
|
|
| |
1.117.
|
|
|
|
|
| |
It has been wrong for this case since it was first written for 7.1 :-(
Per report from Pavel Hanák.
|
|
|
|
| |
Pavel Stehule
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of VARATT_SIZE and VARATT_DATA, which were simply redundant with
VARSIZE and VARDATA, and as a consequence almost no code was using the
longer names. Rename the length fields of struct varlena and various
derived structures to catch anyplace that was accessing them directly;
and clean up various places so caught. In itself this patch doesn't
change any behavior at all, but it is necessary infrastructure if we hope
to play any games with the representation of varlena headers.
Greg Stark and Tom Lane
|
|
|
|
| |
casts to text.
|
| |
|
|
|
|
|
|
|
|
|
| |
parent query's EState. Now that there's a single flat rangetable for both
the main plan and subplans, there's no need anymore for a separate EState,
and removing it allows cleaning up some crufty code in nodeSubplan.c and
nodeSubqueryscan.c. Should be a tad faster too, although any difference
will probably be hard to measure. This is the last bit of subsidiary
mop-up work from changing to a flat rangetable.
|
|
|
|
|
|
| |
is still needed despite cleanups in setrefs.c, because the point is to
let the inserted Result node compute a different tlist than its input
node does. Per example from Jeremy Drake.
|
|
|
|
|
|
|
|
|
|
|
|
| |
drill down into subplan targetlists to print the referent expression for an
OUTER or INNER var in an upper plan node. Hence, make it do that always, and
banish the old hack of showing "?columnN?" when things got too complicated.
Along the way, fix an EXPLAIN bug I introduced by suppressing subqueries from
execution-time range tables: get_name_for_var_field() assumed it could look at
rte->subquery to find out the real type of a RECORD var. That doesn't work
anymore, but instead we can look at the input plan of the SubqueryScan plan
node.
|
| |
|
|
|
|
| |
Chad Wagner
|
|
|
|
|
|
|
| |
and quals have varno OUTER, rather than zero, to indicate a reference to
an output of their lefttree subplan. This is consistent with the way
that every other upper-level node type does it, and allows some simplifications
in setrefs.c and EXPLAIN.
|
|
|
|
|
| |
immediately: ExecHashGetHashValue failed to restore the caller's memory
context before taking the failure exit.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
useless substructure for its RangeTblEntry nodes. (I chose to keep using the
same struct node type and just zero out the link fields for unneeded info,
rather than making a separate ExecRangeTblEntry type --- it seemed too
fragile to have two different rangetable representations.)
Along the way, put subplans into a list in the toplevel PlannedStmt node,
and have SubPlan nodes refer to them by list index instead of direct pointers.
Vadim wanted to do that years ago, but I never understood what he was on about
until now. It makes things a *whole* lot more robust, because we can stop
worrying about duplicate processing of subplans during expression tree
traversals. That's been a constant source of bugs, and it's finally gone.
There are some consequent simplifications yet to be made, like not using
a separate EState for subplans in the executor, but I'll tackle that later.
|
| |
|
|
|
|
|
|
|
| |
function might reduce the number of free pages in the table. Recommend
VACUUM FULL only if 20% free.
Simon Riggs.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I refactored findsplitloc and checksplitloc so that the division of
labor is more clear IMO. I pushed all the space calculation inside the
loop to checksplitloc.
I also fixed the off by 4 in free space calculation caused by
PageGetFreeSpace subtracting sizeof(ItemIdData), even though it was
harmless, because it was distracting and I felt it might come back to
bite us in the future if we change the page layout or alignments.
There's now a new function PageGetExactFreeSpace that doesn't do the
subtraction.
findsplitloc now tries the "just the new item to right page" split as
well. If people don't like the refactoring, I can write a patch to just
add that.
Heikki Linnakangas
|
|
|
|
| |
Korry Douglas and Nikhil S
|
|
|
|
|
| |
to have such entries, and want to be notified when we do...
Leave the plain bugfix in genbki.
|
|
|
|
| |
standard type aliases as well as those known in pg_type. Similar to recent change in plperl.
|
|
|
|
| |
BLCKSZ value.
|
|
|
|
| |
shared link line.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
storing mostly-redundant Query trees in prepared statements, portals, etc.
To replace Query, a new node type called PlannedStmt is inserted by the
planner at the top of a completed plan tree; this carries just the fields of
Query that are still needed at runtime. The statement lists kept in portals
etc. now consist of intermixed PlannedStmt and bare utility-statement nodes
--- no Query. This incidentally allows us to remove some fields from Query
and Plan nodes that shouldn't have been there in the first place.
Still to do: simplify the execution-time range table; at the moment the
range table passed to the executor still contains Query trees for subqueries.
initdb forced due to change of stored rules.
|
|
|
|
| |
permission, per Magnus.
|
|
|
|
| |
by Bernd Helmle
|
| |
|
| |
|
|
|
|
| |
binary dump formats.
|
| |
|
|
|
|
|
|
|
|
|
| |
this code was last gone over, there wasn't really any alternative to
globals because we didn't have the PlannerInfo struct being passed all
through the planner code. Now that we do, we can restructure things
to avoid non-reentrancy. I'm fooling with this because otherwise I'd
have had to add another global variable for the planned compact
range table list.
|
|
|
|
| |
Per example from Jeff Ross.
|
|
|
|
|
|
| |
plan nodes, so that the executor does not need to get these items from
the range table at runtime. This will avoid needing to include these
fields in the compact range table I'm expecting to make the executor use.
|
|
|
|
|
|
| |
portals using PORTAL_UTIL_SELECT strategy. This is currently significant only
for FETCH queries, which are supposed to include a count in the tag. Seems
it's been broken since 7.4, but nobody noticed before Knut Lehre.
|
|
|
|
|
|
| |
equal functions are checked for raw parse trees as well as post-analysis
trees. This was never very important before, but the upcoming plan cache
control module will need to be able to do copyObject() on raw parse trees.
|
|
|
|
|
| |
we can't overflow to the next higher units, and we might print the lower
units for MS.
|
|
|
|
| |
Brendan Jurd
|
|
|
|
|
|
| |
as a performance enhancement.
Mark Kirkwood
|
|
|
|
|
|
| |
forces a particular relation nonnullable, then we can say that the OR does.
This is worth a little extra trouble since it may allow reduction of
outer joins to plain joins.
|
|
|
|
|
|
|
| |
an opclass for a generic type such as ANYARRAY. The original coding failed
to check that PK and FK columns were of the same array type. Per discussion
with Tom Dunstan. Also, make the code a shade more readable by not trying
to economize on variables.
|
|
|
|
|
| |
on platforms that need this. This is done by only writing past the
previously stored message, if it was longer.
|
|
|
|
|
|
|
|
|
| |
JOIN quals, just like WHERE quals, even if they reference every one of the
join's relations. Now that we can reorder outer and inner joins, it's
possible for such a qual to end up being assigned to an outer join plan node,
and we mustn't have it treated as a join qual rather than a filter qual for
the node. (If it were, the join could produce null-extended rows that it
shouldn't.) Per bug report from Pelle Johansson.
|