| Commit message (Collapse) | Author | Age |
| |
|
|
|
|
|
| |
results due to underspecified ordering. Per report from buildfarm member
pika.
|
|
|
|
| |
Hitoshi Harada, with some kibitzing from Heikki and Tom.
|
|
|
|
|
|
|
|
|
|
|
|
| |
upcoming window-functions patch. First, tuplestore_trim is now an
exported function that must be explicitly invoked by callers at
appropriate times, rather than something that tuplestore tries to do
behind the scenes. Second, a read pointer that is marked as allowing
backward scan no longer prevents truncation. This means that a read pointer
marked as having BACKWARD but not REWIND capability can only safely read
backwards as far as the oldest other read pointer. (The expected use pattern
for this involves having another read pointer that serves as the truncation
fencepost.)
|
|
|
|
| |
dead code since Postgres95.
|
|
|
|
|
|
| |
TRACE_POSTGRESQL_WAL_BUFFER_WRITE_DIRTY
Robert Lor
|
|
|
|
| |
Should fix recent buildfarm breakage.
|
| |
|
|
|
|
| |
etc. I think this will fix the current buildfarm issues ...
|
|
|
|
|
|
| |
because transformGenericOptions returns an array, not an Oid. I'm not
sure if this fixes the crashes seen in buildfarm, but it should be fixed
anyway.
|
|
|
|
|
| |
useful yet, but I'm tired of re-merging this aspect of the window functions
patch.
|
|
|
|
|
|
|
|
| |
This doesn't do any remote or external things yet, but it gives modules
like plproxy and dblink a standardized and future-proof system for
managing their connection information.
Martin Pihlak and Peter Eisentraut
|
|
|
|
|
|
| |
reloptions patch for autovacuum and revised by me.
Note that there doesn't seem to be a way to display an index's reloptions.
|
|
|
|
|
|
| |
explicit cast to show the intended array type, we forgot to teach ruleutils.c
to print out such constructs properly. Found by noting bogus output from
recent changes in polymorphism regression test.
|
|
|
|
|
|
|
| |
materialize-mode set results. Since it now uses the ReturnSetInfo node
to hold internal state, we need to be sure to set up the node even when
the immediately called function doesn't return set (but does have a set-valued
argument). Per report from Anupama Aherrao.
|
|
|
|
|
| |
per recent discussions. In passing this also fixes a couple of bugs in
the previous variadic-parameters patch.
|
|
|
|
| |
fix segfault on non-glibc systems.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
skipped. We could update relpages anyway, but it seems better to only
update it together with reltuples, because we use the reltuples/relpages
ratio in the planner. Also don't update n_live_tuples in pgstat.
ANALYZE in VACUUM ANALYZE now needs to update pg_class, if the
VACUUM-phase didn't do so. Added some boolean-passing to let analyze_rel
know if it should update pg_class or not.
I also moved the relcache invalidation (to update rd_targblock) from
vac_update_relstats to where RelationTruncate is called, because
vac_update_relstats is not called for partial vacuums anymore. It's more
obvious to send the invalidation close to the truncation that requires it.
Per report by Ned T. Crigler.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
includes a few new ones.
- Fixed compilation errors on OS X for probes that use typedefs
- Fixed a number of probes to pass ForkNumber per the relation forks
patch
- The new probes are those that were taken out from the previous
submitted patch and required simple fixes. Will submit the other probes
that may require more discussion in a separate patch.
Robert Lor
|
|
|
|
|
|
|
|
|
|
| |
the other major heapam.c functions. The only known consequence of this
omission is that UPDATE RETURNING failed to return the correct value for
"tableoid", as per report from KaiGai Kohei.
Back-patch to 8.2. Arguably it's wrong all the way back; but without
evidence of visible breakage before RETURNING was added, I'll desist from
patching the older branches.
|
| |
|
|
|
|
|
| |
VIEW suggests that it'd be worth spelling the error messages out in a little
more detail. This seems to help with localizing the problem.
|
|
|
|
|
| |
result in hopefully-less-confusing error messages when the new definition
isn't compatible with the old; minor other cleanup.
|
|
|
|
| |
size.
|
|
|
|
|
|
|
|
|
|
|
| |
to return NULL, instead of erroring out, if the target object is specified by
OID and we can't find that OID in the catalogs. Since these functions operate
internally on SnapshotNow rules, there is a race condition when using them
in user queries: the query's MVCC snapshot might "see" a catalog row that's
already committed dead, leading to a failure when the inquiry function is
applied. Returning NULL should generally provide more convenient behavior.
This issue has been complained of before, and in particular we are now seeing
it in the regression tests due to another recent patch.
|
| |
|
|
|
|
|
|
|
| |
to 10, to compensate for the recent change in default statistics target.
The original number was pulled out of the air anyway :-(, but it was picked
in the context of the old default, so holding the default size of the
MCELEM array constant seems the best thing. Per discussion.
|
|
|
|
|
|
|
|
|
|
| |
pg_database_encoding_max_length() predicts the maximum character length
returned by wchar2char(). Per Hiroshi Inoue, MB_CUR_MAX isn't usable on
Windows because we allow encoding = UTF8 when the locale says differently;
and getting rid of it seems a good idea on general principles because it
narrows our dependence on libc's locale API just a little bit more.
Also install a check for overflow of the buffer size computation.
|
|
|
|
|
|
|
|
| |
and certificate revokation list by using connection parameters or environment
variables.
Original patch by Mark Woodward, heavily reworked by Alvaro Herrera and
Magnus Hagander.
|
|
|
|
|
|
|
| |
actual argument type of ANYARRAY to match an argument declared ANYARRAY,
so long as ANYELEMENT etc aren't used. I had overlooked the fact that this
is a possible case while fixing bug #3852; but it is possible because
pg_statistic contains columns declared ANYARRAY. Per gripe from Corey Horton.
|
|
|
|
|
| |
calling recv() and send(). This makes the calls go through the socket
emulation code on Win32, making them for example properly interruptible.
|
|
|
|
|
| |
and its maximum value from 1000 to 10000. ALTER TABLE SET STATISTICS
similarly now allows a value up to 10000. Per discussion.
|
|
|
|
|
| |
in 8.3, too, but I'm not back-patching this change since it would break any
extension modules that might be calling that function.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when they are invoked by the parser. We had been setting up a snapshot at
plan time but really it needs to be done earlier, before parse analysis.
Per report from Dmitry Koterov.
Also fix two related problems discovered while poking at this one:
exec_bind_message called datatype input functions without establishing a
snapshot, and SET CONSTRAINTS IMMEDIATE could call trigger functions without
establishing a snapshot.
Backpatch to 8.2. The underlying problem goes much further back, but it is
masked in 8.1 and before because we didn't attempt to invoke domain check
constraints within datatype input. It would only be exposed if a C-language
datatype input function used the snapshot; which evidently none do, or we'd
have heard complaints sooner. Since this code has changed a lot over time,
a back-patch is hardly risk-free, and so I'm disinclined to patch further
than absolutely necessary.
|
| |
|
| |
|
|
|
|
|
|
| |
vacuuming (it's not), say "database-wide VACUUM" instead of "full-database
VACUUM" in the relevant hint messages. Also, document the permissions needed
to do this. Per today's discussion.
|
|
|
|
|
| |
platform-specific spellings of /dev/null. But one should be enough, so
settle on DEVNULL.
|
|
|
|
|
| |
header file. SunOS 4 is probably broken anyway, but this item stuck out as
completely weird.
|
|
|
|
|
|
|
| |
to the gettext domain name, to simplify parallel installations.
Also, rename set_text_domain() to pg_bindtextdomain(), because that is what
it does.
|
|
|
|
|
|
| |
right child if it doesn't need to. This saves some miniscule number
of cycles, but the ulterior motive is to avoid an optimization bug
known to exist in SCO's C compiler (and perhaps others?)
|
| |
|
|
|
|
|
|
| |
replication patch needs a signal, but we've already used SIGUSR1 and
SIGUSR2 in normal backends. This patch allows reusing SIGUSR1 for that,
and for other purposes too if the need arises.
|
|
|
|
|
|
| |
where no function stats entries exist. Partial response to Pavel's
observation that small VACUUM operations are noticeably slower in CVS HEAD
than 8.3.
|
|
|
|
|
|
| |
form a join and that case doesn't have anything to join to. (We could
probably make it work if we didn't pull up the subquery, but it seems to
me that the case isn't worth extra code.) Per report from Greg Stark.
|
|
|
|
|
|
| |
Plus some makefile cleanup.
part of a patch from Richard Evans
|
|
|
|
| |
Robert Haas
|
|
|
|
|
| |
SizeOfPageHeaderData, like PageGetContents does. Per report by Pavan
Deolasee.
|
|
|
|
|
| |
appendix on key words. catdesc was originally intended as computer-readable,
but since we ended up adding catcode, we can have more elaborate descriptions.
|
|
|
|
| |
Pavel Stehule, with some tweaks by Peter Eisentraut
|