aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
...
* Add casts from int4 and int8 to numeric.Robert Haas2011-04-05
| | | | Joey Adams, per gripe from Ramanujam. Review by myself and Tom Lane.
* Avoid assuming there will be only 3 states for synchronous_commit.Simon Riggs2011-04-04
| | | | | | Also avoid hardcoding the current default state by giving it the name "on" and replace with a meaningful name that reflects its behaviour. Coding only, no change in behaviour.
* Update MSVC toolchain to match SGML entity uppercasingAlvaro Herrera2011-04-04
| | | | Per Robert Haas
* Merge synchronous_replication setting into synchronous_commit.Robert Haas2011-04-04
| | | | | | | | This means one less thing to configure when setting up synchronous replication, and also avoids some ambiguity around what the behavior should be when the settings of these variables conflict. Fujii Masao, with additional hacking by me.
* Include pid in pg_lock_status() results even for SIREAD locks.Robert Haas2011-04-04
| | | | Dan Ports
* Rearrange "add column" logic to merge columns at exec time.Robert Haas2011-04-03
| | | | | | | | | The previous coding set attinhcount too high in some cases, resulting in an undumpable, undroppable column. Per bug #5856, reported by Naoya Anzai. See also commit 31b6fc06d83c6de3644c8f2921eb7de0eb92fac3, which fixes a similar bug in ALTER TABLE .. ADD CONSTRAINT. Patch by Noah Misch.
* Avoid possible hang during smart shutdown.Robert Haas2011-04-03
| | | | | | | | | | | | | | | If a smart shutdown occurs just as a child is starting up, and the child subsequently becomes a walsender, there is a race condition: the postmaster might count the exstant backends, determine that there is one normal backend, and wait for it to die off. Had the walsender transition already occurred before the postmaster counted, it would have proceeded with the shutdown. To fix this, have each child that transforms into a walsender kick the postmaster just after doing so, so that the state machine is certain to advance. Fujii Masao
* Fix typo in PQconnectStartParams().Tom Lane2011-04-02
| | | | | | | | This would lead to leaking the PGconn structure after an error detected by conninfo_array_parse(), as well as failing to return a useful error message in such cases. Backpatch to 9.0 where the error was introduced. Joseph Adams
* Avoid palloc before CurrentMemoryContext is set up on win32Magnus Hagander2011-04-01
| | | | | | | Instead, write the unconverted output - it will be in the wrong encoding, but at least we don't crash. Rushabh Lathia
* Tab completion for COMMENT ON FOREIGN DATA WRAPPER / SERVER.Robert Haas2011-04-01
|
* pg_dump support for comments on FOREIGN DATA WRAPPER and SERVER objects.Robert Haas2011-04-01
| | | | Shigeru Hanada, with some corrections.
* Support comments on FOREIGN DATA WRAPPER and SERVER objects.Robert Haas2011-04-01
| | | | | | | | | | This mostly involves making it work with the objectaddress.c framework, which does most of the heavy lifting. In that vein, change GetForeignDataWrapperOidByName to get_foreign_data_wrapper_oid and GetForeignServerOidByName to get_foreign_server_oid, to match the pattern we use for other object types. Robert Haas and Shigeru Hanada
* Fix compiler warning.Robert Haas2011-04-01
|
* Fix two missing spaces in error messages.Heikki Linnakangas2011-04-01
| | | | Josh Kupershmidt
* Fix a tiny race condition in predicate locking. Need to hold the lock whileHeikki Linnakangas2011-03-31
| | | | | | | | examining the head of predicate locks list. Also, fix the comment of RemoveTargetIfNoLongerUsed, it was neglected when we changed the way update chains are handled. Kevin Grittner
* Increase SHMEM_INDEX_SIZE from 32 to 64. We're currently at 40 entries inHeikki Linnakangas2011-03-31
| | | | | | ShmemIndex, so 64 leaves some headroom. Kevin Grittner
* Don't leak the temporary PLyProcedure struct we create for inline plpythonHeikki Linnakangas2011-03-31
| | | | | | blocks. Investigation by Jan Urbański, though I didn't use his patch.
* Improve error message when WAL ends before reaching end of online backup.Heikki Linnakangas2011-03-31
|
* Attempt to unbreak windows builds broken by commit 754baa2.Andrew Dunstan2011-03-30
|
* Check that we've reached end-of-backup also when we're not performingHeikki Linnakangas2011-03-30
| | | | | | | | | | | | | | archive recovery. It's possible to restore an online backup without recovery.conf, by simply copying all the necessary WAL files to pg_xlog. "pg_basebackup -x" does that too. That's the use case where this cross-check is useful. Backpatch to 9.0. We used to do this in earlier versins, but in 9.0 the code was inadvertently changed so that the check is only performed after archive recovery. Fujii Masao.
* Automatically terminate replication connections that are idle for moreHeikki Linnakangas2011-03-30
| | | | | | | | | than replication_timeout (a new GUC) milliseconds. The TCP timeout is often too long, you want the master to notice a dead connection much sooner. People complained about that in 9.0 too, but with synchronous replication it's even more important to notice dead connections promptly. Fujii Masao and Heikki Linnakangas
* Adjust error message, now that we expect other message types than connectionHeikki Linnakangas2011-03-30
| | | | | | close at this point. Fix PQsetnonblocking() comment. Fujii Masao
* Update SQL features listPeter Eisentraut2011-03-29
| | | | | | | | | Feature F692 "Extended collation support" is now also supported. This refers to allowing the COLLATE clause anywhere in a column or domain definition instead of just directly after the type. Also correct the name of the feature in accordance with the latest SQL standard.
* Add maintainer-check targetPeter Eisentraut2011-03-28
| | | | | | This can do various source code checks that are not appropriate for either the build or the regression tests. Currently: duplicate_oids, SGML syntax and tabs check, NLS syntax check.
* Make duplicate_oids return nonzero exit status if duplicates were foundPeter Eisentraut2011-03-28
| | | | Automatic detection of errors is easier that way.
* Prevent a rowtype from being included in itself.Tom Lane2011-03-28
| | | | | | | | | | | | | | | | Eventually we might be able to allow that, but it's not clear how many places need to be fixed to prevent infinite recursion when there's a direct or indirect inclusion of a rowtype in itself. One such place is CheckAttributeType(), which will recurse to stack overflow in cases such as those exhibited in bug #5950 from Alex Perepelica. If we were sure it was the only such place, we could easily modify the code added by this patch to stop the recursion without a complaint ... but it probably isn't the only such place. Hence, throw error until such time as someone is excited enough about this type of usage to put work into making it safe. Back-patch as far as 8.3. 8.2 doesn't have the recursive call in CheckAttributeType in the first place, so I see no need to add code there in the absence of clear evidence of a problem elsewhere.
* fix up a couple non-prototypes of the form foo() to be foo(void) -- found ↵Greg Stark2011-03-27
| | | | using -Wstrict-prototypes
* Fix check_exclusion_constraint() to insert correct collations in ScanKeys.Tom Lane2011-03-27
|
* Fix plpgsql to release SPI plans when a function or DO block is freed.Tom Lane2011-03-27
| | | | | | | | | | This fixes the gripe I made a few months ago about DO blocks getting slower with repeated use. At least, it fixes it for the case where the DO block isn't aborted by an error. We could try running plpgsql_free_function_memory() even during error exit, but that seems a bit scary since it makes a lot of presumptions about the data structures being in good shape. It's probably reasonable to assume that repeated failures of DO blocks isn't a performance-critical case.
* Clean up cruft around collation initialization for tupdescs and scankeys.Tom Lane2011-03-26
| | | | | I found actual bugs in GiST and plpgsql; the rest of this is cosmetic but meant to decrease the odds of future bugs of omission.
* More collations cleanup, from trawling for missed collation assignments.Tom Lane2011-03-26
| | | | | Mostly cosmetic, though I did find that generateClonedIndexStmt failed to clone the index's collations.
* Clean up a few failures to set collation fields in expression nodes.Tom Lane2011-03-26
| | | | | | | | | I'm not sure these have any non-cosmetic implications, but I'm not sure they don't, either. In particular, ensure the CaseTestExpr generated by transformAssignmentIndirection to represent the base target column carries the correct collation, because parse_collate.c won't fix that. Tweak lsyscache.c API so that we can get the appropriate collation without an extra syscache lookup.
* Additional test for each commit in sync rep path to plug minuteSimon Riggs2011-03-26
| | | | | possibility of race condition that would effect performance only. Requested by Robert Haas. Re-arrange related comments.
* Pass collation to makeConst() instead of looking it up internally.Tom Lane2011-03-25
| | | | | | | | | In nearly all cases, the caller already knows the correct collation, and in a number of places, the value the caller has handy is more correct than the default for the type would be. (In particular, this patch makes it significantly less likely that eval_const_expressions will result in changing the exposed collation of an expression.) So an internal lookup is both expensive and wrong.
* Fix failure to propagate collation in negate_clause().Tom Lane2011-03-25
| | | | | Turns out it was this, and not so much plpgsql, that was at fault in Stefan Huehner's collation-error-in-a-trigger bug report of a couple weeks ago.
* Fix collation handling in plpgsql functions.Tom Lane2011-03-25
| | | | | | | | | | | | | | | | | | | Make plpgsql treat the input collation as a polymorphism variable, so that we cache separate plans for each input collation that's used in a particular session, as per recent discussion. Propagate the input collation to all collatable input parameters. I chose to also propagate the input collation to all declared variables of collatable types, which is a bit more debatable but seems to be necessary for non-astonishing behavior. (Copying a parameter into a separate local variable shouldn't result in a change of behavior, for example.) There is enough infrastructure here to support declaring a collation for each local variable to override that default, but I thought we should wait to see what the field demand is before adding such a feature. In passing, remove exec_get_rec_fieldtype(), which wasn't used anywhere. Documentation patch to follow.
* Make walreceiver send a reply after receiving data but before flushing it.Robert Haas2011-03-25
| | | | | | | It originally worked this way, but was changed by commit a8a8a3e0965201df88bdfdff08f50e5c06c552b7, since which time it's been impossible for walreceiver to ever send a reply with write_location and flush_location set to different values.
* Fix handling of collation in SQL-language functions.Tom Lane2011-03-24
| | | | | | | | | | Ensure that parameter symbols receive collation from the function's resolved input collation, and fix inlining to behave properly. BTW, this commit lays about 90% of the infrastructure needed to support use of argument names in SQL functions. Parsing of parameters is now done via the parser-hook infrastructure ... we'd just need to supply a column-ref hook ...
* Add post-creation hook for extensions, consistent with other object types.Robert Haas2011-03-24
| | | | KaiGai Kohei
* Clean up handling of COLLATE clauses in index column definitions.Tom Lane2011-03-24
| | | | | | Ensure that COLLATE at the top level of an index expression is treated the same as a grammatically separate COLLATE. Fix bogus reverse-parsing logic in pg_get_indexdef.
* Minor changes to recovery pause behaviour.Simon Riggs2011-03-23
| | | | | | | | | Change location LOG message so it works each time we pause, not just for final pause. Ensure that we pause only if we are in Hot Standby and can connect to allow us to run resume function. This change supercedes the code to override parameter recoveryPauseAtTarget to false if not attempting to enter Hot Standby, which is now removed.
* Remove synchronous_replication/max_wal_senders cross-check.Robert Haas2011-03-23
| | | | | | | | This is no longer necessary, and might result in a situation where the configuration file is reloaded (and everything seems OK) but a subsequent restart of the database fails. Per an observation from Fujii Masao.
* Prevent intermittent hang in recovery from bgwriter interaction.Simon Riggs2011-03-23
| | | | | | Startup process waited for cleanup lock but when hot_standby = off the pid was not registered, so that the bgwriter would not wake the waiting process as intended.
* Make FKs valid at creation when added as column constraints.Simon Riggs2011-03-22
| | | | Bug report from Alvaro Herrera
* Make initdb ignore locales for client-only encodings.Tom Lane2011-03-22
| | | | | | While putting such entries into pg_collation is harmless (since backends will ignore entries that don't match the database encoding), it's also useless.
* Improve reporting of run-time-detected indeterminate-collation errors.Tom Lane2011-03-22
| | | | | | | | pg_newlocale_from_collation does not have enough context to give an error message that's even a little bit useful, so move the responsibility for complaining up to its callers. Also, reword ERRCODE_INDETERMINATE_COLLATION error messages in a less jargony, more message-style-guide-compliant fashion.
* Throw error for indeterminate collation of an ORDER/GROUP/DISTINCT target.Tom Lane2011-03-22
| | | | | | | | | | | | | | | | | | | | | | This restores a parse error that was thrown (though only in the ORDER BY case) by the original collation patch. I had removed it in my recent revisions because it was thrown at a place where collations now haven't been computed yet; but I thought of another way to handle it. Throwing the error at parse time, rather than leaving it to be done at runtime, is good because a syntax error pointer is helpful for localizing the problem. We can reasonably assume that the comparison function for a collatable datatype will complain if it doesn't have a collation to use. Now the planner might choose to implement GROUP or DISTINCT via hashing, in which case no runtime error would actually occur, but it seems better to throw error consistently rather than let the error depend on what the planner chooses to do. Another possible objection is that the user might specify a nondefault sort operator that doesn't care about collation ... but that's surely an uncommon usage, and it wouldn't hurt him to throw in a COLLATE clause anyway. This change also makes the ORDER BY/GROUP BY/DISTINCT case more consistent with the UNION/INTERSECT/EXCEPT case, which was already coded to throw this error even though the same objections could be raised there.
* Avoid potential deadlock in InitCatCachePhase2().Tom Lane2011-03-22
| | | | | | | | | | | | | | | Opening a catcache's index could require reading from that cache's own catalog, which of course would acquire AccessShareLock on the catalog. So the original coding here risks locking index before heap, which could deadlock against another backend trying to get exclusive locks in the normal order. Because InitCatCachePhase2 is only called when a backend has to start up without a relcache init file, the deadlock was seldom seen in the field. (And by the same token, there's no need to worry about any performance disadvantage; so not much point in trying to distinguish exactly which catalogs have the risk.) Bug report, diagnosis, and patch by Nikhil Sontakke. Additional commentary by me. Back-patch to all supported branches.
* Reimplement planner's handling of MIN/MAX aggregate optimization (again).Tom Lane2011-03-22
| | | | | | | | | | | | | | Instead of playing cute games with pathkeys, just build a direct representation of the intended sub-select, and feed it through query_planner to get a Path for the index access. This is a bit slower than 9.1's previous method, since we'll duplicate most of the overhead of query_planner; but since the whole optimization only applies to rather simple single-table queries, that probably won't be much of a problem in practice. The advantage is that we get to do the right thing when there's a partial index that needs the implicit IS NOT NULL clause to be usable. Also, although this makes planagg.c be a bit more closely tied to the ordering of operations in grouping_planner, we can get rid of some coupling to lower-level parts of the planner. Per complaint from Marti Raudsepp.
* When two base backups are started at the same time with pg_basebackup,Heikki Linnakangas2011-03-21
| | | | | | | | ensure that they use different checkpoints as the starting point. We use the checkpoint redo location as a unique identifier for the base backup in the end-of-backup record, and in the backup history file name. Bug spotted by Fujii Masao.
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-04 11:18:32 +0000