aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
...
* Teach tuplesort.c about "top N" sorting, in which only the first N tuplesTom Lane2007-05-04
| | | | | | | | | | need be returned. We keep a heap of the current best N tuples and sift-up new tuples into it as we scan the input. For M input tuples this means only about M*log(N) comparisons instead of M*log(M), not to mention a lot less workspace when N is small --- avoiding spill-to-disk for large M is actually the most attractive thing about it. Patch includes planner and executor support for invoking this facility in ORDER BY ... LIMIT queries. Greg Stark, with some editorialization by moi.
* Tweak hash index AM to use the new ReadOrZeroBuffer bufmgr API when fetchingTom Lane2007-05-03
| | | | | | | pages it intends to zero immediately. Just to show there is some use for that function besides WAL recovery :-). Along the way, fold _hash_checkpage and _hash_pageinit calls into _hash_getbuf and friends, instead of expecting callers to do that separately.
* Release builds generate different strangely formatted export namesMagnus Hagander2007-05-03
| | | | | | for local symbols, that shouldn't be exported. This patch excludes them, cutting down about 10,000 exported symbols and decreasing the binary size by 20%.
* Dept. of second thoughts: add comments cautioning against usingTom Lane2007-05-02
| | | | | | | ReadOrZeroBuffer to fetch pages from beyond physical EOF. This would usually work, but would cause problems for md.c if writes occurred beyond a segment boundary when the previous segment file hadn't been fully extended.
* During WAL recovery, when reading a page that we intend to overwrite completelyTom Lane2007-05-02
| | | | | | | | | | | | from the WAL data, don't bother to physically read it; just have bufmgr.c return a zeroed-out buffer instead. This speeds recovery significantly, and also avoids unnecessary failures when a page-to-be-overwritten has corrupt page headers on disk. This replaces a former kluge that accomplished the latter by pretending zero_damaged_pages was always ON during WAL recovery; which was OK when the kluge was put in, but is unsafe when restoring a WAL log that was written with full_page_writes off. Heikki Linnakangas
* Fix things so that when CREATE INDEX CONCURRENTLY sets pg_index.indisvalidTom Lane2007-05-02
| | | | | | | | | | | | true at the very end of its processing, the update is broadcast via a shared-cache-inval message for the index; without this, existing backends that already have relcache entries for the index might never see it become valid. Also, force a relcache inval on the index's parent table at the same time, so that any cached plans for that table are re-planned; this ensures that the newly valid index will be used if appropriate. Aside from making C.I.C. behave more reasonably, this is necessary infrastructure for some aspects of the HOT patch. Pavan Deolasee, with a little further stuff from me.
* Use the new TimestampDifferenceExceeds API instead of timestamp_cmp_internalAlvaro Herrera2007-05-02
| | | | | | and TimestampDifference, to make coding clearer. I think this should also fix the failure to start workers in platforms with low resolution timers, as reported by Itagaki Takahiro.
* Fix failure to check for INVALID worker entry in the new autovacuum code, whichAlvaro Herrera2007-05-02
| | | | | could happen when a worker took to long to start and was thus "aborted" by the launcher. Noticed by lionfish buildfarm member.
* Fix oversight in PG_RE_THROW processing: it's entirely possible that thereTom Lane2007-05-02
| | | | | | | | | | | | | | isn't any place to throw the error to. If so, we should treat the error as FATAL, just as we would have if it'd been thrown outside the PG_TRY block to begin with. Although this is clearly a *potential* source of bugs, it is not clear at the moment whether it is an *actual* source of bugs; there may not presently be any PG_TRY blocks in code that can be reached with no outer longjmp catcher. So for the moment I'm going to be conservative and not back-patch this. The change breaks ABI for users of PG_RE_THROW and hence might create compatibility problems for loadable modules, so we should not put it into released branches without proof that it's needed.
* Add wrapper script around install.pl that calls buildenv.bat before doingMagnus Hagander2007-05-01
| | | | | | the install. Dave Page
* Fix a thinko in my patch of a couple months ago for bug #3116: it did theTom Lane2007-05-01
| | | | | | | | | | wrong thing when inlining polymorphic SQL functions, because it was using the function's declared return type where it should have used the actual result type of the current call. In 8.1 and 8.2 this causes obvious failures even if you don't have assertions turned on; in 8.0 and 7.4 it would only be a problem if the inlined expression were used as an input to a function that did run-time type determination on its inputs. Add a regression test, since this is evidently an under-tested area.
* Change the timestamps recorded in transaction commit/abort xlog recordsTom Lane2007-04-30
| | | | | | | | | from time_t to TimestampTz representation. This provides full gettimeofday() resolution of the timestamps, which might be useful when attempting to do point-in-time recovery --- previously it was not possible to specify the stop point with sub-second resolution. But mostly this is to get rid of TimestampTz-to-time_t conversion overhead during commit. Per my proposal of a day or two back.
* Fix oversight in my patch of yesterday: forgot to ensure that stats wouldTom Lane2007-04-30
| | | | still be forced out at backend exit.
* Implement rate-limiting logic on how often backends will attempt to sendTom Lane2007-04-30
| | | | | | | | | | | | | | messages to the stats collector. This avoids the problem that enabling stats_row_level for autovacuum has a significant overhead for short read-only transactions, as noted by Arjen van der Meijden. We can avoid an extra gettimeofday call by piggybacking on the one done for WAL-logging xact commit or abort (although that doesn't help read-only transactions, since they don't WAL-log anything). In my proposal for this, I noted that we could change the WAL log entries for commit/abort to record full TimestampTz precision, instead of only time_t as at present. That's not done in this patch, but will be committed separately.
* Marginal performance hack: use a dedicated routine instead of copyObjectTom Lane2007-04-30
| | | | | to copy nodes that are known to be Vars during plan reference adjustment. Saves useless memzero operation as well as the big switch in copyObject.
* Marginal performance hack: avoid unnecessary work in expression_tree_mutator.Tom Lane2007-04-30
| | | | | | We can just palloc, instead of using makeNode, when we are going to overwrite the whole node anyway in the FLATCOPY macro. Also, use FLATCOPY instead of copyObject for common node types Var and Const.
* Marginal performance hack: remove the loop that used to be needed toTom Lane2007-04-30
| | | | | | | | | | | look through a freelist for a chunk of adequate size. For a long time now, all elements of a given freelist have been exactly the same allocated size, so we don't need a loop. Since the loop never iterated more than once, you'd think this wouldn't matter much, but it makes a noticeable savings in a simple test --- perhaps because the compiler isn't optimizing on a mistaken assumption that the loop would repeat. AllocSetAlloc is called often enough that saving even a couple of instructions is worthwhile.
* Support for MOVE in PL/PgSQL. Initial patch from Magnus, some improvementsNeil Conway2007-04-29
| | | | by Pavel Stehule, and reviewed by Neil Conway.
* Add support for IN as alternative to FROM in PL/PgSQL's FETCH statement,Neil Conway2007-04-28
| | | | | for consistency with the backend's FETCH command. Patch from Pavel Stehule, reviewed by Neil Conway.
* Modify processing of DECLARE CURSOR and EXPLAIN so that they can resolve theTom Lane2007-04-27
| | | | | | | | | | | | | | types of unspecified parameters when submitted via extended query protocol. This worked in 8.2 but I had broken it during plancache changes. DECLARE CURSOR is now treated almost exactly like a plain SELECT through parse analysis, rewrite, and planning; only just before sending to the executor do we divert it away to ProcessUtility. This requires a special-case check in a number of places, but practically all of them were already special-casing SELECT INTO, so it's not too ugly. (Maybe it would be a good idea to merge the two by treating IntoClause as a form of utility statement? Not going to worry about that now, though.) That approach doesn't work for EXPLAIN, however, so for that I punted and used a klugy solution of running parse analysis an extra time if under extended query protocol.
* Properly set MODULE_PATHNAME based on module name instead of incorrectly basedMagnus Hagander2007-04-27
| | | | | | on directory name. Fixes the generation of .sql files in contrib/spi. Per complaint from Dave Page.
* Removed non-existant function from extern.hMichael Meskes2007-04-27
|
* Inlined two functions to get rid of va_list problems on some archs.Michael Meskes2007-04-27
|
* Fix dynahash.c to suppress hash bucket splits while a hash_seq_search() scanTom Lane2007-04-26
| | | | | | | | | | | | | | | | | | | | | | | is in progress on the same hashtable. This seems the least invasive way to fix the recently-recognized problem that a split could cause the scan to visit entries twice or (with much lower probability) miss them entirely. The only field-reported problem caused by this is the "failed to re-find shared lock object" PANIC in COMMIT PREPARED reported by Michel Dorochevsky, which was caused by multiply visited entries. However, it seems certain that mdsync() is vulnerable to missing required fsync's due to missed entries, and I am fearful that RelationCacheInitializePhase2() might be at risk as well. Because of that and the generalized hazard presented by this bug, back-patch all the supported branches. Along the way, fix pg_prepared_statement() and pg_cursor() to not assume that the hashtables they are examining will stay static between calls. This is risky regardless of the newly noted dynahash problem, because hash_seq_search() has never promised to cope with deletion of table entries other than the just-returned one. There may be no bug here because the only supported way to call these functions is via ExecMakeTableFunctionResult() which will cycle them to completion before doing anything very interesting, but it seems best to get rid of the assumption. This affects 8.2 and HEAD only, since those functions weren't there earlier.
* Another tweak for tab completion of CREATE TEMP. Instead of onlyNeil Conway2007-04-26
| | | | | completing CREATE { TEMP | TEMPORARY } TABLE, we should also suggest VIEW and SEQUENCE. Per Greg Sabino Mullane.
* Minor enhancement to psql tab completion. If we see "CREATE TEMPORARY",Neil Conway2007-04-26
| | | | | | | | | we can complete "TABLE". The previous coding only looked for "CREATE TEMP". Note that I didn't add TEMPORARY to the list of suggested completions after we've seen "CREATE", since TEMP is equivalent and more concise. But if the user has already manually typed TEMPORARY, we may as well complete TABLE for them.
* Rename the newly-added commands for discarding session state.Neil Conway2007-04-26
| | | | | | | | RESET SESSION, RESET PLANS, and RESET TEMP are now DISCARD ALL, DISCARD PLANS, and DISCARD TEMP, respectively. This is to avoid confusion with the pre-existing RESET variants: the DISCARD commands are not actually similar to RESET. Patch from Marko Kreen, with some minor editorialization.
* libpgtypes is a client lib, should not link with backend.Magnus Hagander2007-04-26
|
* Generate "fake configure output" for pg_config, so that external buildsMagnus Hagander2007-04-26
| | | | like Slony can figure out which options were enabled in the build.
* Install libpgport.lib as needed by some client programs.Magnus Hagander2007-04-25
| | | | Dave Page
* Install headers in the same directory structure as Mingw.Magnus Hagander2007-04-25
| | | | Dave Page
* Set maximum semaphore count to 32767 instead of 1. FixesMagnus Hagander2007-04-24
| | | | | | errorcode 298 when unlocking a semaphore more than once. Per report from Marcin Waldowski.
* Don't try to install uuid-ossp since we don't build it.Magnus Hagander2007-04-23
| | | | Per buildfarm member mastodon.
* Remove some of the most blatant brain-fade in the recent guc patchTom Lane2007-04-22
| | | | | | | (it's so nice to have a buildfarm member that actively rejects naked uses of strcasecmp). This coding is still pretty awful, though, since it's going to be O(N^2) in the number of guc variables. May I direct your attention to bsearch?
* Some further performance tweaks for planning large inheritance trees thatTom Lane2007-04-21
| | | | | | | | are mostly excluded by constraints: do the CE test a bit earlier to save some adjust_appendrel_attrs() work on excluded children, and arrange to use array indexing rather than rt_fetch() to fetch RTEs in the main body of the planner. The latter is something I'd wanted to do for awhile anyway, but seeing list_nth_cell() as 35% of the runtime gets one's attention.
* Fix build for directories with spaces in them by quoting properly.Magnus Hagander2007-04-21
| | | | Joachim Wieland
* Make configuration parameters fall back to their default values when theyPeter Eisentraut2007-04-21
| | | | | | are removed from the configuration file. Joachim Wieland
* Don't try to build uuid-ossp on msvc.Magnus Hagander2007-04-21
|
* Contrib module uuid-ossp for generating UUID values using the OSSP UUIDPeter Eisentraut2007-04-21
| | | | library. New configure option --with-ossp-uuid to activate.
* Avoid useless work during set_plain_rel_pathlist() when the relationTom Lane2007-04-21
| | | | will be excluded by constraint exclusion anyway. Greg Stark
* Tweak make_inh_translation_lists() to check the common case wherein parent andTom Lane2007-04-21
| | | | | | child attnums are the same, before it grovels through each and every child column looking for a name match. Saves some time in large inheritance trees, per example from Greg.
* Improve the way in which CatalogCacheComputeHashValue combines multiple keyTom Lane2007-04-21
| | | | | | | | | | | values: don't throw away perfectly good hash bits, and increase the shift distances so as to provide more separation in the common case where some of the key values are small integers (and so their hashes are too, because hashfunc.c doesn't try all that hard). This reduces the runtime of SearchCatCache by a factor of 4 in an example provided by Greg Stark, in which the planner spends a whole lot of time searching the two-key STATRELATT cache. It seems unlikely to hurt in other cases, but maybe we could do even better?
* Adjust pgstat_initstats() to avoid repeated searches of the TabStat arraysTom Lane2007-04-21
| | | | | | | | | when a relation is opened multiple times in the same transaction. This is particularly useful for system catalogs, which we may heap_open or index_open many times in a transaction, and it doesn't really cost anything extra even if the rel is touched but once. Motivated by study of an example from Greg Stark, in which pgstat_initstats() accounted for an unreasonably large fraction of the runtime.
* Tweak set_rel_width() to avoid redundant executions of getrelid().Tom Lane2007-04-21
| | | | | In very large queries this accounts for a noticeable fraction of planning time. Per an example from Greg Stark.
* Add comment on why deadlock detection error messages only prints numbers.Bruce Momjian2007-04-20
|
* Add script major_release_split to simplify creating release notes forBruce Momjian2007-04-20
| | | | multiple releases.
* Add mention of checking <link> behavior of HISTORY.html to releaseBruce Momjian2007-04-20
| | | | checklist.
* Support explicit placement of the temporary-table schema within search_path.Tom Lane2007-04-20
| | | | | | | | | | | | | This is needed to allow a security-definer function to set a truly secure value of search_path. Without it, a malicious user can use temporary objects to execute code with the privileges of the security-definer function. Even pushing the temp schema to the back of the search path is not quite good enough, because a function or operator at the back of the path might still capture control from one nearer the front due to having a more exact datatype match. Hence, disable searching the temp schema altogether for functions and operators. Security: CVE-2007-2138
* Sync timezone data with 2007e zic release.Tom Lane2007-04-19
|
* Repair PANIC condition in hash indexes when a previous index extension attemptTom Lane2007-04-19
| | | | | | | | | | | failed (due to lock conflicts or out-of-space). We might have already extended the index's filesystem EOF before failing, causing the EOF to be beyond what the metapage says is the last used page. Hence the invariant maintained by the code needs to be "EOF is at or beyond last used page", not "EOF is exactly the last used page". Problem was created by my patch of 2006-11-19 that attempted to repair bug #2737. Since that was back-patched to 7.4, this needs to be as well. Per report and test case from Vlastimil Krejcir.